Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
8 | View Code Duplication | abstract class EmptyCommit implements CommitInterface, EmptyResourceInterface |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * @return int |
||
12 | */ |
||
13 | 2 | public function id() : int |
|
17 | |||
18 | /** |
||
19 | * @return string |
||
20 | */ |
||
21 | 2 | public function sha() : string |
|
25 | |||
26 | /** |
||
27 | * @return string |
||
28 | */ |
||
29 | 2 | public function branch() : string |
|
33 | |||
34 | /** |
||
35 | * @return string |
||
36 | */ |
||
37 | 2 | public function message() : string |
|
41 | |||
42 | /** |
||
43 | * @return DateTimeInterface |
||
44 | */ |
||
45 | 2 | public function comittedAt() : DateTimeInterface |
|
49 | |||
50 | /** |
||
51 | * @return string |
||
52 | */ |
||
53 | 2 | public function authorName() : string |
|
57 | |||
58 | /** |
||
59 | * @return string |
||
60 | */ |
||
61 | 2 | public function authorEmail() : string |
|
65 | |||
66 | /** |
||
67 | * @return string |
||
68 | */ |
||
69 | 2 | public function committerName() : string |
|
73 | |||
74 | /** |
||
75 | * @return string |
||
76 | */ |
||
77 | 2 | public function committerEmail() : string |
|
81 | |||
82 | /** |
||
83 | * @return string |
||
84 | */ |
||
85 | 2 | public function compareUrl() : string |
|
89 | } |
||
90 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.