Job - Code Metrics - php-api-clients/travis - Measure and Improve Code Quality continuously with Scrutinizer

Job A
last analyzed 2019-03-03 00:20 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	25
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	4
dl	25
loc	25
ccs	0
cts	18
cp	0
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	annotations()	10	10	1
A	refresh()	8	8	1

How to fix Duplicated Code

<?php declare(strict_types=1);

namespace ApiClients\Client\Travis\Resource\Sync;

use ApiClients\Client\Travis\Resource\Job as BaseJob;
use ApiClients\Client\Travis\Resource\JobInterface;
use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
use Rx\React\Promise;

class Job extends BaseJob

{
    /**
     * @return array
     */
    public function annotations(): array
    {
        return $this->wait(
            $this->handleCommand(
                new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
            )->then(function (JobInterface $job) {
                return Promise::fromObservable($job->annotations());

            })
        );
    }

    public function refresh(): Job
    {
        return $this->wait($this->handleCommand(
            new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
        )->then(function (JobInterface $job) {
            return $job->refresh();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }));
    }
}


GitHub Access Token became invalid

Job A
last analyzed 2019-03-03 00:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Travis\Resource\Sync;
4
5		use ApiClients\Client\Travis\Resource\Job as BaseJob;
6		use ApiClients\Client\Travis\Resource\JobInterface;
7		use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
8		use Rx\React\Promise;
9
10	View Code Duplication	class Job extends BaseJob
		0 ignored issues – show Duplication introduced 2017-05-26 06:13 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* @return array
14		*/
15		public function annotations(): array
16		{
17		return $this->wait(
18		$this->handleCommand(
19		new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
20		)->then(function (JobInterface $job) {
21		return Promise::fromObservable($job->annotations());
		0 ignored issues – show Bug introduced 2016-12-04 10:43 UTC by Report Bug Copy Issue Report The method `annotations()` does not exist on `ApiClients\Client\Travis\Resource\JobInterface`. Did you maybe mean `annotationIds()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
22		})
23		);
24		}
25
26		public function refresh(): Job
27		{
28		return $this->wait($this->handleCommand(
29		new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
30		)->then(function (JobInterface $job) {
31		return $job->refresh();
		0 ignored issues – show Bug introduced 2016-12-04 10:43 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ApiClients\Client\Travis\Resource\JobInterface` as the method `refresh()` does only exist in the following implementations of said interface: `ApiClients\Client\Travis\Resource\Async\Job`, `ApiClients\Client\Travis\Resource\Sync\Job`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
32		}));
33		}
34		}
35

php-api-clients / travis

GitHub Access Token became invalid

Job A last analyzed 2019-03-03 00:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

Job A
last analyzed 2019-03-03 00:20 UTC