Build - Code Metrics - php-api-clients/travis - Measure and Improve Code Quality continuously with Scrutinizer

Build A
last analyzed 2019-03-03 00:20 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	4
dl	0
loc	45
ccs	0
cts	30
cp	0
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	jobs()	10	1
A	job()	10	1
A	refresh()	10	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Travis\Resource\Sync;

use ApiClients\Client\Travis\Resource\Build as BaseBuild;
use ApiClients\Client\Travis\Resource\BuildInterface;
use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
use Rx\React\Promise;

class Build extends BaseBuild
{
    /**
     * @return array
     */
    public function jobs(): array
    {
        return $this->wait(
            $this->handleCommand(
                new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
            )->then(function (BuildInterface $build) {
                return Promise::fromObservable($build->jobs());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            })
        );
    }

    /**
     * @param  int $id
     * @return Job
     */
    public function job(int $id): Job
    {
        return $this->wait(
            $this->handleCommand(
                new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
            )->then(function (BuildInterface $build) use ($id) {
                return $build->job($id);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            })
        );
    }

    /**
     * @return Build
     */
    public function refresh(): Build
    {
        return $this->wait(
            $this->handleCommand(
                new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
            )->then(function (BuildInterface $build) {
                return $build->refresh();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            })
        );
    }
}


GitHub Access Token became invalid

Build A
last analyzed 2019-03-03 00:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Travis\Resource\Sync;
4
5			use ApiClients\Client\Travis\Resource\Build as BaseBuild;
6			use ApiClients\Client\Travis\Resource\BuildInterface;
7			use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
8			use Rx\React\Promise;
9
10			class Build extends BaseBuild
11			{
12			/**
13			* @return array
14			*/
15			public function jobs(): array
16			{
17			return $this->wait(
18			$this->handleCommand(
19			new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
20			)->then(function (BuildInterface $build) {
21			return Promise::fromObservable($build->jobs());
			0 ignored issues – show Bug introduced 2016-12-04 10:43 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ApiClients\Client\Travis\Resource\BuildInterface` as the method `jobs()` does only exist in the following implementations of said interface: `ApiClients\Client\Travis\Resource\Async\Build`, `ApiClients\Client\Travis\Resource\Sync\Build`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
22			})
23			);
24			}
25
26			/**
27			* @param int $id
28			* @return Job
29			*/
30			public function job(int $id): Job
31			{
32			return $this->wait(
33			$this->handleCommand(
34			new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
35			)->then(function (BuildInterface $build) use ($id) {
36			return $build->job($id);
			0 ignored issues – show Bug introduced 2016-12-04 10:43 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ApiClients\Client\Travis\Resource\BuildInterface` as the method `job()` does only exist in the following implementations of said interface: `ApiClients\Client\Travis\Resource\Async\Build`, `ApiClients\Client\Travis\Resource\Sync\Build`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37			})
38			);
39			}
40
41			/**
42			* @return Build
43			*/
44			public function refresh(): Build
45			{
46			return $this->wait(
47			$this->handleCommand(
48			new BuildAsyncFromSyncCommand(self::HYDRATE_CLASS, $this)
49			)->then(function (BuildInterface $build) {
50			return $build->refresh();
			0 ignored issues – show Bug introduced 2016-12-04 10:43 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `ApiClients\Client\Travis\Resource\BuildInterface` as the method `refresh()` does only exist in the following implementations of said interface: `ApiClients\Client\Travis\Resource\Async\Build`, `ApiClients\Client\Travis\Resource\Sync\Build`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51			})
52			);
53			}
54			}
55

php-api-clients / travis

GitHub Access Token became invalid

Build A last analyzed 2019-03-03 00:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Build A
last analyzed 2019-03-03 00:20 UTC