Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
12 | View Code Duplication | final class BranchesHandler |
|
|
|||
13 | { |
||
14 | /** |
||
15 | * @var FetchAndHydrateService |
||
16 | */ |
||
17 | private $service; |
||
18 | |||
19 | /** |
||
20 | * @param FetchAndIterateService $service |
||
21 | */ |
||
22 | 1 | public function __construct(FetchAndIterateService $service) |
|
26 | |||
27 | /** |
||
28 | * Fetch the given repository and hydrate it. |
||
29 | * |
||
30 | * @param BranchesCommand $command |
||
31 | * @return PromiseInterface |
||
32 | */ |
||
33 | 1 | public function handle(BranchesCommand $command): PromiseInterface |
|
41 | } |
||
42 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.