RequestService::__construct() - Code Metrics - Inspection of "Updated api-clients/service and extracted client i..." - php-api-clients/transport - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f21656...1ff9d3 )

by Cees-Jan

created 2016-12-16 22:41 UTC

RequestService::__construct() A

↳ Parent: RequestService

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php declare(strict_types=1);

namespace ApiClients\Foundation\Transport\Service;

use ApiClients\Foundation\Service\ServiceInterface;
use ApiClients\Foundation\Transport\Client;
use ApiClients\Foundation\Transport\Middleware\BufferedSinkMiddleware;
use ApiClients\Foundation\Transport\Options;
use Psr\Http\Message\RequestInterface;
use React\Promise\CancellablePromiseInterface;
use function React\Promise\resolve;

final class RequestService implements ServiceInterface
{
    /**
     * @var Client
     */
    private $client;

    /**
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * @param RequestInterface $request
     * @param array $options
     * @return CancellablePromiseInterface
     */
    public function handle(RequestInterface $request = null, array $options = []): CancellablePromiseInterface
    {
        if (!isset($options[Options::MIDDLEWARE])) {
            $options[Options::MIDDLEWARE] = [];
        }

        if (!in_array(BufferedSinkMiddleware::class, $options[Options::MIDDLEWARE])) {
            $options[Options::MIDDLEWARE][] = BufferedSinkMiddleware::class;
        }

        return $this->client->request(
            $request,
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
            $options
        );
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Foundation\Transport\Service;
4
5			use ApiClients\Foundation\Service\ServiceInterface;
6			use ApiClients\Foundation\Transport\Client;
7			use ApiClients\Foundation\Transport\Middleware\BufferedSinkMiddleware;
8			use ApiClients\Foundation\Transport\Options;
9			use Psr\Http\Message\RequestInterface;
10			use React\Promise\CancellablePromiseInterface;
11			use function React\Promise\resolve;
12
13			final class RequestService implements ServiceInterface
14			{
15			/**
16			* @var Client
17			*/
18			private $client;
19
20			/**
21			* @param Client $client
22			*/
23			public function __construct(Client $client)
24			{
25			$this->client = $client;
26			}
27
28			/**
29			* @param RequestInterface $request
30			* @param array $options
31			* @return CancellablePromiseInterface
32			*/
33			public function handle(RequestInterface $request = null, array $options = []): CancellablePromiseInterface
34			{
35			if (!isset($options[Options::MIDDLEWARE])) {
36			$options[Options::MIDDLEWARE] = [];
37			}
38
39			if (!in_array(BufferedSinkMiddleware::class, $options[Options::MIDDLEWARE])) {
40			$options[Options::MIDDLEWARE][] = BufferedSinkMiddleware::class;
41			}
42
43			return $this->client->request(
44			$request,
			0 ignored issues – show Bug introduced 2016-12-16 22:48 UTC by Report Bug Copy Issue Report It seems like `$request` defined by parameter `$request` on line `33` can be `null`; however, `ApiClients\Foundation\Transport\Client::request()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
45			$options
46			);
47			}
48			}
49

php-api-clients / transport

GitHub Access Token became invalid

Push — master ( f21656...1ff9d3 )

RequestService::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like