StreamHandler::__construct() - Code Metrics - Inspection of "Added AsyncClient and Client clients" - php-api-clients/skeleton - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 063be6...e2c735 )

by Cees-Jan

created 2017-08-27 20:51 UTC

StreamHandler::__construct() A

↳ Parent: StreamHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Skeleton\CommandBus\Handler;

use ApiClients\Client\Skeleton\CommandBus\Command\StreamCommand;
use ApiClients\Client\Skeleton\Resource\ExampleInterface;
use ApiClients\Tools\Services\Client\FetchAndHydrateService;
use ApiClients\Tools\Services\Client\FetchAndIterateService;
use React\Promise\PromiseInterface;
use function React\Promise\resolve;

final class StreamHandler
{
    /**
     * @var FetchAndHydrateService
     */
    private $service;

    /**
     * @param FetchAndIterateService $service
     */
    public function __construct(FetchAndIterateService $service)
    {
        $this->service = $service;

    }

    /**
     * Fetch the given repository and hydrate it.
     *
     * @param  StreamCommand    $command
     * @return PromiseInterface
     */
    public function handle(StreamCommand $command): PromiseInterface
    {
        return resolve($this->service->iterate(

            'stream/' . $command->getInput(),
            'stream',
            ExampleInterface::HYDRATE_CLASS
        ));
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Skeleton\CommandBus\Handler;
4
5		use ApiClients\Client\Skeleton\CommandBus\Command\StreamCommand;
6		use ApiClients\Client\Skeleton\Resource\ExampleInterface;
7		use ApiClients\Tools\Services\Client\FetchAndHydrateService;
8		use ApiClients\Tools\Services\Client\FetchAndIterateService;
9		use React\Promise\PromiseInterface;
10		use function React\Promise\resolve;
11
12		final class StreamHandler
13		{
14		/**
15		* @var FetchAndHydrateService
16		*/
17		private $service;
18
19		/**
20		* @param FetchAndIterateService $service
21		*/
22	1	public function __construct(FetchAndIterateService $service)
23		{
24	1	$this->service = $service;
		0 ignored issues – show Documentation Bug introduced 2017-08-27 20:56 UTC by Report Bug Copy Issue Report It seems like `$service` of type `object<ApiClients\Tools\...FetchAndIterateService>` is incompatible with the declared type `object<ApiClients\Tools\...FetchAndHydrateService>` of property `$service`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
25	1	}
26
27		/**
28		* Fetch the given repository and hydrate it.
29		*
30		* @param StreamCommand $command
31		* @return PromiseInterface
32		*/
33	1	public function handle(StreamCommand $command): PromiseInterface
34		{
35	1	return resolve($this->service->iterate(
		0 ignored issues – show Bug introduced 2017-08-27 20:56 UTC by Report Bug Copy Issue Report The method `iterate()` does not seem to exist on `object<ApiClients\Tools\...FetchAndHydrateService>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
36	1	'stream/' . $command->getInput(),
37	1	'stream',
38	1	ExampleInterface::HYDRATE_CLASS
39		));
40		}
41		}
42

php-api-clients / skeleton

GitHub Access Token became invalid

Push — master ( 063be6...e2c735 )

StreamHandler::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like