ApiClients\Foundation\Tests\AbstractResourceTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
	getClass()	0	1	?
A	provideProperties()	0	6	2
A	testProperties()	0	4	1
A	testInterface()	0	9	1

<?php
declare(strict_types=1);

namespace ApiClients\Foundation\Tests;

use ApiClients\Foundation\Resource\ResourceInterface;

abstract class AbstractResourceTest extends \PHPUnit_Framework_TestCase
{
    abstract function getClass(): string;

It is generally recommended to explicitly declare the visibility for methods.

    public function provideProperties()
    {
        foreach ((new \ReflectionClass($this->getClass()))->getProperties() as $property) {

This foreach statement is empty and can be removed.

            //
        }
    }

    /**
     * @dataProvider provideProperties
     */
    public function testProperties()
    {
        $this->assertTrue(true);
    }

    public function testInterface()
    {
        $this->assertTrue(
            is_subclass_of(

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \ApiClients\Foundation\Resource\ResourceInterface::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

                $this->getClass(),
                ResourceInterface::class
            )
        );
    }
}