Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
8 | View Code Duplication | class FloatType extends AbstractType implements Type |
|
|
|||
9 | { |
||
10 | const SCALAR = 'float'; |
||
11 | |||
12 | /** |
||
13 | * Generate random data |
||
14 | * |
||
15 | * @param int $count Amount of rows to generate and return |
||
16 | * @return Generator |
||
17 | */ |
||
18 | 12 | public function generate(int $count = 100): Generator |
|
24 | |||
25 | /** |
||
26 | * List of types that are compatible with this type |
||
27 | * |
||
28 | * @return Generator |
||
29 | */ |
||
30 | public function compatible(): Generator |
||
34 | |||
35 | /** |
||
36 | * List of types that are incompatible with this type |
||
37 | * |
||
38 | * @return Generator |
||
39 | */ |
||
40 | public function incompatible(): Generator |
||
46 | } |
||
47 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.