EmptyLineAboveDocblocksFixer::applyFix() - Code Metrics - Inspection of "Migrate to friendsofphp/php-cs-fixer v2.0" - php-api-clients/resource-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#23)

by Cees-Jan

created 2017-05-14 17:31 UTC

EmptyLineAboveDocblocksFixer::applyFix() A

↳ Parent: EmptyLineAboveDocblocksFixer

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	8
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	13
ccs	0
cts	13
cp	0
crap	20
rs	9.2

<?php declare(strict_types=1);

namespace ApiClients\Tools\ResourceGenerator;

use PhpCsFixer\AbstractFixer;
use PhpCsFixer\FixerDefinition\CodeSample;
use PhpCsFixer\FixerDefinition\FixerDefinition;
use PhpCsFixer\Tokenizer\Tokens;

class EmptyLineAboveDocblocksFixer extends AbstractFixer
{
    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'ApiClients/empty_line_above_docblocks';
    }

    public function getDefinition()
    {
        return new FixerDefinition(
            'Ensure there is an empty line behind abstract or interface methods.',
            [
                new CodeSample(
                    $this->BOM.'<?php
class MyClass { }

$x = new MyClass();
$x->foo = true;
            
            echo "Hello!";
            '
                ),
            ]
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getPriority()
    {
        return 1;
    }

    /**
     * {@inheritdoc}
     */
    public function isCandidate(Tokens $tokens)
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    protected function applyFix(\SplFileInfo $file, Tokens $tokens)
    {
        for ($index = 2; $index < count($tokens); $index++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $token = $tokens[$index];
            $previousToken = $tokens[$index - 1];
            $sndPreviousToken = $tokens[$index - 2];
            if ($sndPreviousToken->getContent() !== '{' &&
                substr($token->getContent(), 0, 3) === '/**'
            ) {
                $previousToken->setContent(PHP_EOL . $previousToken->getContent());
            }
        }
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Tools\ResourceGenerator;
4
5			use PhpCsFixer\AbstractFixer;
6			use PhpCsFixer\FixerDefinition\CodeSample;
7			use PhpCsFixer\FixerDefinition\FixerDefinition;
8			use PhpCsFixer\Tokenizer\Tokens;
9
10			class EmptyLineAboveDocblocksFixer extends AbstractFixer
11			{
12			/**
13			* {@inheritdoc}
14			*/
15			public function getName()
16			{
17			return 'ApiClients/empty_line_above_docblocks';
18			}
19
20			public function getDefinition()
21			{
22			return new FixerDefinition(
23			'Ensure there is an empty line behind abstract or interface methods.',
24			[
25			new CodeSample(
26			$this->BOM.'<?php
			0 ignored issues – show Bug introduced 2017-05-09 19:39 UTC by Report Bug Copy Issue Report The property `BOM` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27
28			echo "Hello!";
29			'
30			),
31			]
32			);
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			public function getPriority()
39			{
40			return 1;
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function isCandidate(Tokens $tokens)
47			{
48			return true;
49			}
50
51			/**
52			* {@inheritdoc}
53			*/
54			protected function applyFix(\SplFileInfo $file, Tokens $tokens)
55			{
56			for ($index = 2; $index < count($tokens); $index++) {
			0 ignored issues – show Performance Best Practice introduced 2016-07-27 12:05 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
57			$token = $tokens[$index];
58			$previousToken = $tokens[$index - 1];
59			$sndPreviousToken = $tokens[$index - 2];
60			if ($sndPreviousToken->getContent() !== '{' &&
61			substr($token->getContent(), 0, 3) === '/**'
62			) {
63			$previousToken->setContent(PHP_EOL . $previousToken->getContent());
64			}
65			}
66			}
67			}
68

php-api-clients / resource-generator

GitHub Access Token became invalid

Pull Request — master (#23)

EmptyLineAboveDocblocksFixer::applyFix() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like