SyncClassGenerator - Code Metrics - Inspection of "Merge pull request #14 from php-api-clients/improv..." - php-api-clients/resource-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d01879...32d13b )

by Cees-Jan

created 2016-11-29 16:51 UTC

SyncClassGenerator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	6.9 %

Coupling/Cohesion

Components	1
Dependencies	12

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	4
loc	58
ccs	30
cts	30
cp	1
rs	10
c	1
b	0
f	0
wmc	2
lcom	1
cbo	12

1 Method

Rating	Name	Duplication	Size	Complexity
A	generate()	4	50	2

How to fix Duplicated Code

<?php declare(strict_types=1);

namespace ApiClients\Tools\ResourceGenerator\FileGenerators;

use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
use ApiClients\Tools\ResourceGenerator\FileGeneratorInterface;
use PhpParser\BuilderFactory;
use PhpParser\Node;

final class SyncClassGenerator extends AbstractExtendingClassGenerator implements FileGeneratorInterface
{
    const NAMESPACE = 'Sync';

    /**
     * @return Node
     */
    public function generate(): Node
    {
        $classChunks = explode('\\', $this->yaml['class']);
        $className = array_pop($classChunks);
        $namespace = $this->yaml['src']['namespace'] . '\\' . static::NAMESPACE;
        if (count($classChunks) > 0) {

            $namespace .= '\\' . implode('\\', $classChunks);
            $namespace = str_replace('\\\\', '\\', $namespace);
        }
        $baseClass = $this->yaml['src']['namespace'] . '\\' . $this->yaml['class'];

        $factory = new BuilderFactory();

        $class = $factory->class($className)
            ->extend('Base' . $className);

        $class->addStmt($factory->method('refresh')
            ->makePublic()
            ->setReturnType($className)
            ->addStmt(
                new Node\Stmt\Return_(
                    new Node\Expr\MethodCall(
                        new Node\Expr\Variable('this'),
                        'wait',
                        [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            new Node\Expr\MethodCall(
                                new Node\Expr\Variable('this'),
                                'handleCommand',
                                [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                    new Node\Expr\New_(
                                        new Node\Name('BuildAsyncFromSyncCommand'),
                                        [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                            new Node\Scalar\String_($this->yaml['class']),
                                            new Node\Expr\Variable('this'),
                                        ]
                                    ),
                                ]
                            ),
                        ]
                    )
                )
            ));

        return $factory->namespace($namespace)
            ->addStmt($factory->use(BuildAsyncFromSyncCommand::class))
            ->addStmt($factory->use($baseClass)->as('Base' . $className))
            ->addStmt($class)
            ->getNode()
            ;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Tools\ResourceGenerator\FileGenerators;
4
5			use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
6			use ApiClients\Tools\ResourceGenerator\FileGeneratorInterface;
7			use PhpParser\BuilderFactory;
8			use PhpParser\Node;
9
10			final class SyncClassGenerator extends AbstractExtendingClassGenerator implements FileGeneratorInterface
11			{
12			const NAMESPACE = 'Sync';
13
14			/**
15			* @return Node
16			*/
17	1		public function generate(): Node
18			{
19	1		$classChunks = explode('\\', $this->yaml['class']);
20	1		$className = array_pop($classChunks);
21			$namespace = $this->yaml['src']['namespace'] . '\\' . static::NAMESPACE;
22	1	View Code Duplication	if (count($classChunks) > 0) {
			0 ignored issues – show Duplication introduced 2016-11-29 20:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23	1		$namespace .= '\\' . implode('\\', $classChunks);
24	1		$namespace = str_replace('\\\\', '\\', $namespace);
25			}
26	1		$baseClass = $this->yaml['src']['namespace'] . '\\' . $this->yaml['class'];
27
28	1		$factory = new BuilderFactory();
29
30	1		$class = $factory->class($className)
31	1		->extend('Base' . $className);
32
33	1		$class->addStmt($factory->method('refresh')
34	1		->makePublic()
35	1		->setReturnType($className)
36	1		->addStmt(
37	1		new Node\Stmt\Return_(
38	1		new Node\Expr\MethodCall(
39	1		new Node\Expr\Variable('this'),
40	1		'wait',
41			[
			0 ignored issues – show Documentation introduced 2016-11-29 20:02 UTC by Report Bug Copy Issue Report `array(new \PhpParser\Nod...r\Variable('this'))))))` is of type `array<integer,object<Php...e\\Expr\\MethodCall>"}>`, but the function expects a `array<integer,object<PhpParser\Node\Arg>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42	1		new Node\Expr\MethodCall(
43	1		new Node\Expr\Variable('this'),
44	1		'handleCommand',
45			[
			0 ignored issues – show Documentation introduced 2016-11-29 20:02 UTC by Report Bug Copy Issue Report `array(new \PhpParser\Nod...xpr\Variable('this'))))` is of type `array<integer,object<Php...r\\Node\\Expr\\New_>"}>`, but the function expects a `array<integer,object<PhpParser\Node\Arg>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46	1		new Node\Expr\New_(
47	1		new Node\Name('BuildAsyncFromSyncCommand'),
48			[
			0 ignored issues – show Documentation introduced 2016-11-29 20:02 UTC by Report Bug Copy Issue Report `array(new \PhpParser\Nod...\Expr\Variable('this'))` is of type `array<integer,object<Php...ode\\Expr\\Variable>"}>`, but the function expects a `array<integer,object<PhpParser\Node\Arg>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49	1		new Node\Scalar\String_($this->yaml['class']),
50	1		new Node\Expr\Variable('this'),
51			]
52			),
53			]
54			),
55			]
56			)
57			)
58			));
59
60	1		return $factory->namespace($namespace)
61	1		->addStmt($factory->use(BuildAsyncFromSyncCommand::class))
62	1		->addStmt($factory->use($baseClass)->as('Base' . $className))
63	1		->addStmt($class)
64	1		->getNode()
65			;
66			}
67			}
68

php-api-clients / resource-generator

GitHub Access Token became invalid

Push — master ( d01879...32d13b )

SyncClassGenerator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like