SyncClassGenerator::createRefreshClosure() - Code Metrics - Inspection of "Slowly started chopping down the x-mass three of d..." - php-api-clients/resource-generator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — improvement-chop-down-code-x-m... ( 69d8d1 )

by Cees-Jan

created 2016-11-29 21:51 UTC

SyncClassGenerator::createRefreshClosure() B

↳ Parent: SyncClassGenerator

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	13
nc	1
nop	2
dl	0
loc	24
ccs	10
cts	10
cp	1
crap	1
rs	8.9713
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace ApiClients\Tools\ResourceGenerator\FileGenerators;

use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
use ApiClients\Tools\ResourceGenerator\FileGeneratorInterface;
use Doctrine\Common\Inflector\Inflector;
use PhpParser\BuilderFactory;
use PhpParser\Node;

final class SyncClassGenerator extends AbstractExtendingClassGenerator implements FileGeneratorInterface
{
    const NAMESPACE = 'Sync';

    /**
     * @return Node
     */
    public function generate(): Node
    {
        $classChunks = explode('\\', $this->yaml['class']);
        $className = array_pop($classChunks);
        $interfaceName = $className . 'Interface';
        $namespace = $this->yaml['src']['namespace'] . '\\' . static::NAMESPACE;
        if (count($classChunks) > 0) {

            $namespace .= '\\' . implode('\\', $classChunks);
            $namespace = str_replace('\\\\', '\\', $namespace);
        }
        $baseClass = $this->yaml['src']['namespace'] . '\\' . $this->yaml['class'];
        $interfaceFQName = $this->yaml['src']['namespace'] . '\\' . $this->yaml['class'] . 'Interface';

        $factory = new BuilderFactory();

        $class = $factory->class($className)
            ->extend('Base' . $className);

        $class->addStmt($factory->method('refresh')
            ->makePublic()
            ->setReturnType($className)
            ->addStmt(
                new Node\Stmt\Return_(
                    new Node\Expr\MethodCall(
                        new Node\Expr\Variable('this'),
                        'wait',
                        [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            new Node\Expr\MethodCall(
                                $this->callCommandBus(),
                                'then',
                                [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                   $this->createRefreshClosure($className, $interfaceName),
                                ]
                            ),
                        ]
                    )
                )
            ));

        return $factory->namespace($namespace)
            ->addStmt($factory->use(BuildAsyncFromSyncCommand::class))
            ->addStmt($factory->use($baseClass)->as('Base' . $className))
            ->addStmt($factory->use($interfaceFQName))
            ->addStmt($class)
            ->getNode()
            ;
    }

    protected function callCommandBus(): Node\Expr\MethodCall
    {
        return new Node\Expr\MethodCall(
            new Node\Expr\Variable('this'),
            'handleCommand',
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $this->createCommand(),
            ]
        );
    }

    protected function createCommand(): Node\Expr\New_
    {
        return new Node\Expr\New_(
            new Node\Name('BuildAsyncFromSyncCommand'),
            [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                new Node\Expr\ClassConstFetch(
                    new Node\Name('self'),
                    'HYDRATE_CLASS'
                ),
                new Node\Expr\Variable('this'),
            ]
        );
    }

    protected function createRefreshClosure(string $className, string $interfaceName): Node\Expr\Closure
    {
        return new Node\Expr\Closure(
            [
                'params' => [
                    new Node\Param(
                        Inflector::camelize($className),
                        null,
                        $interfaceName
                    )
                ],
                'stmts' => [
                    new Node\Stmt\Return_(
                        new Node\Expr\MethodCall(
                            new Node\Expr\Variable(
                                Inflector::camelize($className)
                            ),
                            'refresh'
                        )
                    )
                ],
            ]
        );
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Tools\ResourceGenerator\FileGenerators;
4
5			use ApiClients\Foundation\Hydrator\CommandBus\Command\BuildAsyncFromSyncCommand;
6			use ApiClients\Tools\ResourceGenerator\FileGeneratorInterface;
7			use Doctrine\Common\Inflector\Inflector;
8			use PhpParser\BuilderFactory;
9			use PhpParser\Node;
10
11			final class SyncClassGenerator extends AbstractExtendingClassGenerator implements FileGeneratorInterface
12			{
13			const NAMESPACE = 'Sync';
14
15			/**
16			* @return Node
17			*/
18	1		public function generate(): Node
19			{
20	1		$classChunks = explode('\\', $this->yaml['class']);
21	1		$className = array_pop($classChunks);
22	1		$interfaceName = $className . 'Interface';
23			$namespace = $this->yaml['src']['namespace'] . '\\' . static::NAMESPACE;
24	1	View Code Duplication	if (count($classChunks) > 0) {
			0 ignored issues – show Duplication introduced 2016-11-29 20:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25	1		$namespace .= '\\' . implode('\\', $classChunks);
26	1		$namespace = str_replace('\\\\', '\\', $namespace);
27			}
28	1		$baseClass = $this->yaml['src']['namespace'] . '\\' . $this->yaml['class'];
29	1		$interfaceFQName = $this->yaml['src']['namespace'] . '\\' . $this->yaml['class'] . 'Interface';
30
31	1		$factory = new BuilderFactory();
32
33	1		$class = $factory->class($className)
34	1		->extend('Base' . $className);
35
36	1		$class->addStmt($factory->method('refresh')
37	1		->makePublic()
38	1		->setReturnType($className)
39	1		->addStmt(
40	1		new Node\Stmt\Return_(
41	1		new Node\Expr\MethodCall(
42	1		new Node\Expr\Variable('this'),
43	1		'wait',
44			[
			0 ignored issues – show Documentation introduced 2016-11-29 21:53 UTC by Report Bug Copy Issue Report `array(new \PhpParser\Nod...ame, $interfaceName))))` is of type `array<integer,object<Php...e\\Expr\\MethodCall>"}>`, but the function expects a `array<integer,object<PhpParser\Node\Arg>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45	1		new Node\Expr\MethodCall(
46	1		$this->callCommandBus(),
47	1		'then',
48			[
			0 ignored issues – show Documentation introduced 2016-11-29 21:53 UTC by Report Bug Copy Issue Report `array($this->createRefre...sName, $interfaceName))` is of type `array<integer,object<Php...Node\\Expr\\Closure>"}>`, but the function expects a `array<integer,object<PhpParser\Node\Arg>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49	1		$this->createRefreshClosure($className, $interfaceName),
50			]
51			),
52			]
53			)
54			)
55			));
56
57	1		return $factory->namespace($namespace)
58	1		->addStmt($factory->use(BuildAsyncFromSyncCommand::class))
59	1		->addStmt($factory->use($baseClass)->as('Base' . $className))
60	1		->addStmt($factory->use($interfaceFQName))
61	1		->addStmt($class)
62	1		->getNode()
63			;
64			}
65
66	1		protected function callCommandBus(): Node\Expr\MethodCall
67			{
68	1		return new Node\Expr\MethodCall(
69	1		new Node\Expr\Variable('this'),
70	1		'handleCommand',
71			[
			0 ignored issues – show Documentation introduced 2016-11-29 21:53 UTC by Report Bug Copy Issue Report `array($this->createCommand())` is of type `array<integer,object<Php...r\\Node\\Expr\\New_>"}>`, but the function expects a `array<integer,object<PhpParser\Node\Arg>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72	1		$this->createCommand(),
73			]
74			);
75			}
76
77	1		protected function createCommand(): Node\Expr\New_
78			{
79	1		return new Node\Expr\New_(
80	1		new Node\Name('BuildAsyncFromSyncCommand'),
81			[
			0 ignored issues – show Documentation introduced 2016-11-29 21:30 UTC by Report Bug Copy Issue Report `array(new \PhpParser\Nod...\Expr\Variable('this'))` is of type `array<integer,object<Php...ode\\Expr\\Variable>"}>`, but the function expects a `array<integer,object<PhpParser\Node\Arg>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
82	1		new Node\Expr\ClassConstFetch(
83	1		new Node\Name('self'),
84	1		'HYDRATE_CLASS'
85			),
86	1		new Node\Expr\Variable('this'),
87			]
88			);
89			}
90
91	1		protected function createRefreshClosure(string $className, string $interfaceName): Node\Expr\Closure
92			{
93	1		return new Node\Expr\Closure(
94			[
95			'params' => [
96	1		new Node\Param(
97	1		Inflector::camelize($className),
98	1		null,
99			$interfaceName
100			)
101			],
102			'stmts' => [
103	1		new Node\Stmt\Return_(
104	1		new Node\Expr\MethodCall(
105	1		new Node\Expr\Variable(
106	1		Inflector::camelize($className)
107			),
108	1		'refresh'
109			)
110			)
111			],
112			]
113			);
114			}
115			}
116

php-api-clients / resource-generator

GitHub Access Token became invalid

Push — improvement-chop-down-code-x-m... ( 69d8d1 )

SyncClassGenerator::createRefreshClosure() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like