ApiClients\Tools\ResourceGenerator\EmptyLineAboveDocblocksFixer::fix()

Complexity

Conditions	5
Paths	3

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	EmptyLineAboveDocblocksFixer::getName()	0	4	1

<?php

namespace ApiClients\Tools\ResourceGenerator;

use PhpCsFixer\AbstractFixer;
use PhpCsFixer\FixerDefinition\CodeSample;
use PhpCsFixer\FixerDefinition\FixerDefinition;
use PhpCsFixer\Tokenizer\Tokens;

class EmptyLineAboveDocblocksFixer extends AbstractFixer
{
    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'ApiClients/empty_line_above_docblocks';
    }

    public function getDefinition()
    {
        return new FixerDefinition(
            'Ensure there is an empty line behind abstract or interface methods.',
            [
                new CodeSample(
                    $this->BOM.'<?php

The property BOM does not exist. Did you maybe forget to declare it?

            
            echo "Hello!";
            '
                ),
            ]
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getPriority()
    {
        return 1;
    }

    /**
     * {@inheritdoc}
     */
    public function isCandidate(Tokens $tokens)
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    protected function applyFix(\SplFileInfo $file, Tokens $tokens)
    {
        for ($index = 2; $index < count($tokens); $index++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $token = $tokens[$index];
            $previousToken = $tokens[$index - 1];
            $sndPreviousToken = $tokens[$index - 2];
            if ($sndPreviousToken->getContent() !== '{' &&
                substr($token->getContent(), 0, 3) === '/**' /*&&

53% of this comment could be valid code. Did you maybe forget this after debugging?

                $previousToken->getLine() === $token->getLine() - 1*/
            ) {
                $previousToken->setContent(PHP_EOL . $previousToken->getContent());
            }
        }
    }
}