AsyncClient::__construct() - Code Metrics - Inspection of "Async client" - php-api-clients/rabbitmq-management - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ee40b2...664ab6 )

by Cees-Jan

created 2016-11-20 15:44 UTC

AsyncClient::__construct() A

↳ Parent: AsyncClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	5

<?php
declare(strict_types=1);

namespace ApiClients\Client\RabbitMQ\Management;

use ApiClients\Foundation\Hydrator\CommandBus\Command\HydrateCommand;
use ApiClients\Foundation\Transport\CommandBus\Command\SimpleRequestCommand;
use Psr\Http\Message\ResponseInterface;
use React\EventLoop\LoopInterface;
use React\Promise\PromiseInterface;
use Rx\Observable;
use Rx\ObservableInterface;
use Rx\React\Promise;
use ApiClients\Foundation\Client;
use ApiClients\Foundation\Factory;
use function React\Promise\resolve;

final class AsyncClient
{
    /**
     * @var Client
     */
    protected $client;

    /**
     * @param LoopInterface $loop
     * @param string $baseUrl
     * @param string $username
     * @param string $password
     * @param Client|null $client
     */
    public function __construct(
        LoopInterface $loop,
        string $baseUrl,
        string $username,
        string $password,
        Client $client = null
    ) {
        if (!($client instanceof Client)) {
            $options = ApiSettings::getOptions($baseUrl, $username, $password, 'Async');
            $client = Factory::create($loop, $options);
        }
        $this->client = $client;
    }

    /**
     * @return PromiseInterface
     */
    public function overview(): PromiseInterface
    {
        return $this->client->handle(
            new SimpleRequestCommand('overview')
        )->then(function (ResponseInterface $response) {
            return resolve($this->client->handle(
                new HydrateCommand('Overview', $response->getBody()->getJson())
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ));
        });
    }

    /**
     * @return ObservableInterface
     */
    public function queues(): ObservableInterface

    {
        return Promise::toObservable($this->client->handle(
            new SimpleRequestCommand('queues')
        ))->flatMap(function (ResponseInterface $response) {
            return Observable::fromArray($response->getBody()->getJson());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        })->flatMap(function ($queue) {
            return Promise::toObservable($this->client->handle(
                new HydrateCommand('Queue', $queue)
            ));
        });
    }

    /**
     * @return ObservableInterface
     */
    public function connections(): ObservableInterface

    {
        return Promise::toObservable($this->client->handle(
            new SimpleRequestCommand('connections')
        ))->flatMap(function (ResponseInterface $response) {
            return Observable::fromArray($response->getBody()->getJson());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        })->flatMap(function ($connection) {
            return Promise::toObservable($this->client->handle(
                new HydrateCommand('Connection', $connection)
            ));
        });
    }
}


GitHub Access Token became invalid

Push — master ( ee40b2...664ab6 )

AsyncClient::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		declare(strict_types=1);
3
4		namespace ApiClients\Client\RabbitMQ\Management;
5
6		use ApiClients\Foundation\Hydrator\CommandBus\Command\HydrateCommand;
7		use ApiClients\Foundation\Transport\CommandBus\Command\SimpleRequestCommand;
8		use Psr\Http\Message\ResponseInterface;
9		use React\EventLoop\LoopInterface;
10		use React\Promise\PromiseInterface;
11		use Rx\Observable;
12		use Rx\ObservableInterface;
13		use Rx\React\Promise;
14		use ApiClients\Foundation\Client;
15		use ApiClients\Foundation\Factory;
16		use function React\Promise\resolve;
17
18		final class AsyncClient
19		{
20		/**
21		* @var Client
22		*/
23		protected $client;
24
25		/**
26		* @param LoopInterface $loop
27		* @param string $baseUrl
28		* @param string $username
29		* @param string $password
30		* @param Client\|null $client
31		*/
32		public function __construct(
33		LoopInterface $loop,
34		string $baseUrl,
35		string $username,
36		string $password,
37		Client $client = null
38		) {
39		if (!($client instanceof Client)) {
40		$options = ApiSettings::getOptions($baseUrl, $username, $password, 'Async');
41		$client = Factory::create($loop, $options);
42		}
43		$this->client = $client;
44		}
45
46		/**
47		* @return PromiseInterface
48		*/
49		public function overview(): PromiseInterface
50		{
51		return $this->client->handle(
52		new SimpleRequestCommand('overview')
53		)->then(function (ResponseInterface $response) {
54		return resolve($this->client->handle(
55		new HydrateCommand('Overview', $response->getBody()->getJson())
		0 ignored issues – show Bug introduced 2016-11-20 15:51 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
56		));
57		});
58		}
59
60		/**
61		* @return ObservableInterface
62		*/
63	View Code Duplication	public function queues(): ObservableInterface
		0 ignored issues – show Duplication introduced 2016-11-20 15:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		return Promise::toObservable($this->client->handle(
66		new SimpleRequestCommand('queues')
67		))->flatMap(function (ResponseInterface $response) {
68		return Observable::fromArray($response->getBody()->getJson());
		0 ignored issues – show Bug introduced 2016-11-20 15:51 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
69		})->flatMap(function ($queue) {
70		return Promise::toObservable($this->client->handle(
71		new HydrateCommand('Queue', $queue)
72		));
73		});
74		}
75
76		/**
77		* @return ObservableInterface
78		*/
79	View Code Duplication	public function connections(): ObservableInterface
		0 ignored issues – show Duplication introduced 2016-11-20 15:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		{
81		return Promise::toObservable($this->client->handle(
82		new SimpleRequestCommand('connections')
83		))->flatMap(function (ResponseInterface $response) {
84		return Observable::fromArray($response->getBody()->getJson());
		0 ignored issues – show Bug introduced 2016-11-20 15:51 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
85		})->flatMap(function ($connection) {
86		return Promise::toObservable($this->client->handle(
87		new HydrateCommand('Connection', $connection)
88		));
89		});
90		}
91		}
92

php-api-clients / rabbitmq-management

GitHub Access Token became invalid

Push — master ( ee40b2...664ab6 )

AsyncClient::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like