SharedAppClientService::share() - Code Metrics - Inspection of "Merge pull request #3 from php-api-clients/improve..." - php-api-clients/pusher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b42dfd...ebd3a0 )

by Cees-Jan

created 2017-05-23 20:39 UTC

SharedAppClientService::share() A

↳ Parent: SharedAppClientService

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1
crap	2

<?php declare(strict_types=1);

namespace ApiClients\Client\Pusher\Service;

use ApiClients\Client\Pusher\AsyncClient;
use React\EventLoop\LoopInterface;
use React\Promise\CancellablePromiseInterface;
use function React\Promise\resolve;

final class SharedAppClientService
{
    /**
     * @var LoopInterface
     */
    private $loop;

    /**
     * @var array
     */
    private $apps = [];

    /**
     * SharedAppClientHandler constructor.
     * @param LoopInterface $loop
     */
    public function __construct(LoopInterface $loop)
    {
        $this->loop = $loop;
    }

    /**
     * @param  string|null                 $appId
     * @return CancellablePromiseInterface
     */
    public function share(string $appId): CancellablePromiseInterface
    {
        if (isset($this->apps[$appId])) {
            return resolve($this->apps[$appId]);
        }

        $this->apps[$appId] = AsyncClient::create($this->loop, $appId);

        return resolve($this->apps[$appId]);
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Pusher\Service;
4
5		use ApiClients\Client\Pusher\AsyncClient;
6		use React\EventLoop\LoopInterface;
7		use React\Promise\CancellablePromiseInterface;
8		use function React\Promise\resolve;
9
10		final class SharedAppClientService
11		{
12		/**
13		* @var LoopInterface
14		*/
15		private $loop;
16
17		/**
18		* @var array
19		*/
20		private $apps = [];
21
22		/**
23		* SharedAppClientHandler constructor.
24		* @param LoopInterface $loop
25		*/
26	2	public function __construct(LoopInterface $loop)
27		{
28	2	$this->loop = $loop;
29	2	}
30
31		/**
32		* @param string\|null $appId
33		* @return CancellablePromiseInterface
34		*/
35	2	public function share(string $appId): CancellablePromiseInterface
36		{
37	2	if (isset($this->apps[$appId])) {
38	2	return resolve($this->apps[$appId]);
39		}
40
41	2	$this->apps[$appId] = AsyncClient::create($this->loop, $appId);
42
43	2	return resolve($this->apps[$appId]);
44		}
45		}
46

php-api-clients / pusher

GitHub Access Token became invalid

Push — master ( b42dfd...ebd3a0 )

SharedAppClientService::share() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like