SharedAppClientService::share() - Code Metrics - Inspection of "Refactored AsyncClient so that it's more declarati..." - php-api-clients/pusher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by David

created 2017-09-05 22:12 UTC

SharedAppClientService::share() A

↳ Parent: SharedAppClientService

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	0
cts	5
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1
crap	6

<?php declare(strict_types=1);

namespace ApiClients\Client\Pusher\Service;

use ApiClients\Client\Pusher\AsyncClient;
use React\EventLoop\LoopInterface;
use React\Promise\CancellablePromiseInterface;
use function React\Promise\resolve;

final class SharedAppClientService
{
    /**
     * @var LoopInterface
     */
    private $loop;

    /**
     * @var array
     */
    private $apps = [];

    /**
     * SharedAppClientHandler constructor.
     * @param LoopInterface $loop
     */
    public function __construct(LoopInterface $loop)
    {
        $this->loop = $loop;
    }

    /**
     * @param  string|null                 $appId
     * @return CancellablePromiseInterface
     */
    public function share(string $appId): CancellablePromiseInterface
    {
        if (isset($this->apps[$appId])) {
            return resolve($this->apps[$appId]);
        }

        $this->apps[$appId] = AsyncClient::create($this->loop, $appId);

        return resolve($this->apps[$appId]);
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Pusher\Service;
4
5			use ApiClients\Client\Pusher\AsyncClient;
6			use React\EventLoop\LoopInterface;
7			use React\Promise\CancellablePromiseInterface;
8			use function React\Promise\resolve;
9
10			final class SharedAppClientService
11			{
12			/**
13			* @var LoopInterface
14			*/
15			private $loop;
16
17			/**
18			* @var array
19			*/
20			private $apps = [];
21
22			/**
23			* SharedAppClientHandler constructor.
24			* @param LoopInterface $loop
25			*/
26			public function __construct(LoopInterface $loop)
27			{
28			$this->loop = $loop;
29			}
30
31			/**
32			* @param string\|null $appId
33			* @return CancellablePromiseInterface
34			*/
35			public function share(string $appId): CancellablePromiseInterface
36			{
37			if (isset($this->apps[$appId])) {
38			return resolve($this->apps[$appId]);
39			}
40
41			$this->apps[$appId] = AsyncClient::create($this->loop, $appId);
42
43			return resolve($this->apps[$appId]);
44			}
45			}
46

php-api-clients / pusher

GitHub Access Token became invalid

Pull Request — master (#7)

SharedAppClientService::share() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like