SharedAppClientService::share() - Code Metrics - Inspection of "Improvement handle disconnects and reconnect when..." - php-api-clients/pusher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Cees-Jan

created 2017-05-10 05:52 UTC

SharedAppClientService::share() A

↳ Parent: SharedAppClientService

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	5
cts	5
cp	1
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1
crap	2

<?php declare(strict_types=1);

namespace ApiClients\Client\Pusher\Service;

use ApiClients\Client\Pusher\AsyncClient;
use ApiClients\Foundation\Service\ServiceInterface;
use React\EventLoop\LoopInterface;
use React\Promise\CancellablePromiseInterface;
use function React\Promise\resolve;

final class SharedAppClientService
{
    /**
     * @var LoopInterface
     */
    private $loop;

    /**
     * @var array
     */
    private $apps = [];

    /**
     * SharedAppClientHandler constructor.
     * @param LoopInterface $loop
     */
    public function __construct(LoopInterface $loop)
    {
        $this->loop = $loop;
    }

    /**
     * @param string|null $appId
     * @return CancellablePromiseInterface
     */
    public function share(string $appId): CancellablePromiseInterface
    {
        if (isset($this->apps[$appId])) {
            return resolve($this->apps[$appId]);
        }

        $this->apps[$appId] = AsyncClient::create($this->loop, $appId);
        return resolve($this->apps[$appId]);
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Pusher\Service;
4
5		use ApiClients\Client\Pusher\AsyncClient;
6		use ApiClients\Foundation\Service\ServiceInterface;
7		use React\EventLoop\LoopInterface;
8		use React\Promise\CancellablePromiseInterface;
9		use function React\Promise\resolve;
10
11		final class SharedAppClientService
12		{
13		/**
14		* @var LoopInterface
15		*/
16		private $loop;
17
18		/**
19		* @var array
20		*/
21		private $apps = [];
22
23		/**
24		* SharedAppClientHandler constructor.
25		* @param LoopInterface $loop
26		*/
27	2	public function __construct(LoopInterface $loop)
28		{
29	2	$this->loop = $loop;
30	2	}
31
32		/**
33		* @param string\|null $appId
34		* @return CancellablePromiseInterface
35		*/
36	2	public function share(string $appId): CancellablePromiseInterface
37		{
38	2	if (isset($this->apps[$appId])) {
39	2	return resolve($this->apps[$appId]);
40		}
41
42	2	$this->apps[$appId] = AsyncClient::create($this->loop, $appId);
43	2	return resolve($this->apps[$appId]);
44		}
45		}
46

php-api-clients / pusher

GitHub Access Token became invalid

Pull Request — master (#3)

SharedAppClientService::share() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like