ApiClients\Foundation\Middleware\MiddlewareRunner

Complexity

Total Complexity

11

Size/Duplication

Total Lines	128
Duplicated Lines	28.91 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

97.83%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	orderMiddlewares()	0	8	1
A	getPriority()	0	13	3
A	pre()	0	17	2
A	post()	18	18	2
A	error()	19	19	2

<?php declare(strict_types=1);

namespace ApiClients\Foundation\Middleware;

use ApiClients\Foundation\Middleware\Annotation\Priority as PriorityAnnotation;
use Doctrine\Common\Annotations\AnnotationReader;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use React\Promise\CancellablePromiseInterface;
use ReflectionMethod;
use Throwable;
use function React\Promise\reject;
use function React\Promise\resolve;

final class MiddlewareRunner
{
    /**
     * @var array
     */
    private $options;

    /**
     * @var MiddlewareInterface[]
     */
    private $middlewares;

    /**
     * @var AnnotationReader
     */
    private $annotationReader;

    /**
     * MiddlewareRunner constructor.
     * @param array $options
     * @param MiddlewareInterface[] $middlewares
     */
    public function __construct(array $options, MiddlewareInterface ...$middlewares)
    {
        $this->options = $options;
        $this->middlewares = $middlewares;

It seems like $middlewares of type array<integer,array<integer,object<ApiClients\Foundation\Middleware\MiddlewareInterface>>> is incompatible with the declared type array<integer,object<ApiClients\Foundation\Middleware\MiddlewareInterface>> of property $middlewares.

        $this->annotationReader = new AnnotationReader();
    }

    /**
     * Sort the middlewares by priority
     *
     * @param string $method
     * @param MiddlewareInterface[] $middlewares
     * @return array
     */
    protected function orderMiddlewares(string $method, MiddlewareInterface ...$middlewares): array
    {
        usort($middlewares, function (MiddlewareInterface $left, MiddlewareInterface $right) use ($method) {
            return $this->getPriority($method, $right) <=> $this->getPriority($method, $left);
        });

        return $middlewares;
    }

    private function getPriority(string $method, MiddlewareInterface $middleware): int
    {
        $methodReflection = new ReflectionMethod($middleware, $method);
        $annotation = $this->annotationReader->getMethodAnnotation($methodReflection, PriorityAnnotation::class);

        if ($annotation !== null &&
            get_class($annotation) === PriorityAnnotation::class
        ) {
            return $annotation->property;
        }

        return $middleware->priority();

The method ApiClients\Foundation\Middleware\MiddlewareInterface::priority() has been deprecated with message: Use annotations for more finegrained control

    }

    /**
     * @param RequestInterface $request
     * @return CancellablePromiseInterface
     */
    public function pre(
        RequestInterface $request
    ): CancellablePromiseInterface {
        $promise = resolve($request);

        $middlewares = $this->middlewares;
        $middlewares = $this->orderMiddlewares('pre', ...$middlewares);

        foreach ($middlewares as $middleware) {
            $requestMiddleware = $middleware;
            $promise = $promise->then(function (RequestInterface $request) use ($requestMiddleware) {
                return $requestMiddleware->pre($request, $this->options);
            });
        }

        return $promise;
    }

    /**
     * @param ResponseInterface $response
     * @return CancellablePromiseInterface
     */
    public function post(

This method seems to be duplicated in your project.

        ResponseInterface $response
    ): CancellablePromiseInterface {
        $promise = resolve($response);

        $middlewares = $this->middlewares;
        $middlewares = $this->orderMiddlewares('post', ...$middlewares);
        $middlewares = array_reverse($middlewares);

        foreach ($middlewares as $middleware) {
            $responseMiddleware = $middleware;
            $promise = $promise->then(function (ResponseInterface $response) use ($responseMiddleware) {
                return $responseMiddleware->post($response, $this->options);
            });
        }

        return $promise;
    }

    /**
     * @param Throwable $throwable
     * @return CancellablePromiseInterface
     */
    public function error(

This method seems to be duplicated in your project.

        Throwable $throwable
    ): CancellablePromiseInterface {

        $promise = reject($throwable);

        $middlewares = $this->middlewares;
        $middlewares = $this->orderMiddlewares('error', ...$middlewares);
        $middlewares = array_reverse($middlewares);

        foreach ($middlewares as $middleware) {
            $errorMiddleware = $middleware;
            $promise = $promise->then(null, function (Throwable $throwable) use ($errorMiddleware) {
                return reject($errorMiddleware->error($throwable, $this->options));
            });
        }

        return $promise;
    }
}