NestedHandler::hydrate() - Code Metrics - Inspection of "Turn the hydrator API async" - php-api-clients/hydrator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Cees-Jan

created 2016-11-24 22:07 UTC

NestedHandler::hydrate() A

↳ Parent: NestedHandler

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	16
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	16
loc	16
ccs	0
cts	13
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	4
nop	3
crap	20

<?php
declare(strict_types=1);

namespace ApiClients\Foundation\Hydrator\Annotations\Handler;

use ApiClients\Foundation\Hydrator\Annotations\Nested;
use ApiClients\Foundation\Hydrator\AnnotationInterface;
use ApiClients\Foundation\Hydrator\HandlerInterface;
use ApiClients\Foundation\Resource\ResourceInterface;

class NestedHandler extends AbstractHandler implements HandlerInterface
{
    public function hydrate(AnnotationInterface $annotation, array $json, ResourceInterface $object): array

    {
        if (!($annotation instanceof Nested)) {
            return $json;
        }

        foreach ($annotation->properties() as $property) {
            if (!is_array($json[$property])) {
                continue;
            }

            $json[$property] = $this->getHydrator()->hydrate($annotation->get($property), $json[$property]);
        }

        return $json;
    }

    public function extract(AnnotationInterface $annotation, ResourceInterface $object, array $json): array

    {
        if (!($annotation instanceof Nested)) {
            return $json;
        }

        foreach ($annotation->properties() as $property) {
            if (!($json[$property] instanceof ResourceInterface)) {
                continue;
            }

            $json[$property] = $this->getHydrator()->extract($annotation->get($property), $json[$property]);
        }

        return $json;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace ApiClients\Foundation\Hydrator\Annotations\Handler;
5
6		use ApiClients\Foundation\Hydrator\Annotations\Nested;
7		use ApiClients\Foundation\Hydrator\AnnotationInterface;
8		use ApiClients\Foundation\Hydrator\HandlerInterface;
9		use ApiClients\Foundation\Resource\ResourceInterface;
10
11		class NestedHandler extends AbstractHandler implements HandlerInterface
12		{
13	View Code Duplication	public function hydrate(AnnotationInterface $annotation, array $json, ResourceInterface $object): array
		0 ignored issues – show Duplication introduced 2016-08-12 22:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		if (!($annotation instanceof Nested)) {
16		return $json;
17		}
18
19		foreach ($annotation->properties() as $property) {
20		if (!is_array($json[$property])) {
21		continue;
22		}
23
24		$json[$property] = $this->getHydrator()->hydrate($annotation->get($property), $json[$property]);
25		}
26
27		return $json;
28		}
29
30	View Code Duplication	public function extract(AnnotationInterface $annotation, ResourceInterface $object, array $json): array
		0 ignored issues – show Duplication introduced 2016-08-12 22:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		if (!($annotation instanceof Nested)) {
33		return $json;
34		}
35
36		foreach ($annotation->properties() as $property) {
37		if (!($json[$property] instanceof ResourceInterface)) {
38		continue;
39		}
40
41		$json[$property] = $this->getHydrator()->extract($annotation->get($property), $json[$property]);
42		}
43
44		return $json;
45		}
46		}
47

php-api-clients / hydrator

GitHub Access Token became invalid

Pull Request — master (#14)

NestedHandler::hydrate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like