ApiClients\Client\Github\Service\IteratePagesService

Complexity

Total Complexity

10

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

85.29%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	handleResponseContentsComplete()	0	12	1
A	__construct()	0	4	1
A	handle()	0	23	1
B	handleResponse()	0	36	6
A	handleResponseContents()	0	7	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\Service;

use ApiClients\Foundation\Service\ServiceInterface;
use ApiClients\Foundation\Transport\Service\RequestService;
use Psr\Http\Message\ResponseInterface;
use React\Promise\CancellablePromiseInterface;
use React\Promise\FulfilledPromise;
use RingCentral\Psr7\Request;
use Rx\Disposable\CallbackDisposable;
use Rx\Observable;
use Rx\ObserverInterface;
use Rx\SchedulerInterface;
use function React\Promise\all;
use function React\Promise\resolve;

class IteratePagesService implements ServiceInterface
{
    /**
     * @var RequestService
     */
    private $requestService;

    /**
     * @param RequestService $requestService
     */
    public function __construct(RequestService $requestService)
    {
        $this->requestService = $requestService;
    }

    public function handle(string $path = null): CancellablePromiseInterface
    {
        return resolve(Observable::create(function (
            ObserverInterface $observer,
            SchedulerInterface $scheduler

The parameter $scheduler is not used and could be removed.

        ) use ($path) {
            $promise = $this->requestService->
                handle(new Request('GET', $path))->
                then(
                    function ($response) use ($observer) {
                        return $this->handleResponse($response, $observer);
                    },
                    function ($error) use ($observer) {
                        $observer->onError($error);
                    }
                )
            ;

            return new CallbackDisposable(function () use ($promise) {
                //$promise->cancel();

84% of this comment could be valid code. Did you maybe forget this after debugging?

            });
        }));
    }

    private function handleResponse(
        ResponseInterface $response,
        ObserverInterface $observer
    ): CancellablePromiseInterface {
        if (!$response->hasHeader('link')) {
            return $this->handleResponseContentsComplete($response, $observer);
        }

        $links = [
            'next' => false,
            'last' => false,
        ];
        foreach (explode(', ', $response->getHeader('link')[0]) as $link) {
            list($url, $rel) = explode('>; rel="', ltrim(rtrim($link, '"'), '<'));
            if (isset($links[$rel])) {
                $links[$rel] = $url;
            }
        }

        if ($links['next'] === false || $links['last'] === false) {
            return $this->handleResponseContentsComplete($response, $observer);
        }

        $promises = [];

        $promises[] = $this->requestService->
            handle(new Request('GET', $links['next']))->
            then(function (ResponseInterface $response) use ($observer) {
                return $this->handleResponse($response, $observer);
            })
        ;

        $promises[] = $this->handleResponseContents($response, $observer);

        return all($promises);
    }

    private function handleResponseContentsComplete(
        ResponseInterface $response,
        ObserverInterface $observer
    ): CancellablePromiseInterface {
        return $this->handleResponseContents($response, $observer)->then(function () use ($observer) {
            $observer->onCompleted();
            return new FulfilledPromise();
        }, function ($error) use ($observer) {
            $observer->onError($error);
            return new FulfilledPromise();
        });
    }

    private function handleResponseContents(
        ResponseInterface $response,
        ObserverInterface $observer
    ): CancellablePromiseInterface {
        $observer->onNext($response->getBody()->getJson());

It seems like you code against a concrete implementation and not the interface Psr\Http\Message\StreamInterface as the method getJson() does only exist in the following implementations of said interface: ApiClients\Foundation\Transport\JsonStream.

        return new FulfilledPromise();
    }
}