PingWebHookHandler::__construct() - Code Metrics - Inspection of "Webhooks" - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Cees-Jan

created 2018-02-13 16:20 UTC

PingWebHookHandler::__construct() A

↳ Parent: PingWebHookHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\CommandBus\Handler;

use ApiClients\Client\Github\CommandBus\Command\PingWebHookCommand;
use ApiClients\Foundation\Transport\Service\RequestService;
use Psr\Http\Message\ResponseInterface;
use React\Promise\PromiseInterface;

final class PingWebHookHandler
{
    /**
     * @var RequestService
     */
    private $requestService;

    /**
     * @param RequestService $requestService
     */
    public function __construct(RequestService $requestService)
    {
        $this->requestService = $requestService;
    }

    /**
     * @param  PingWebHookCommand $command
     * @return PromiseInterface
     */
    public function handle(PingWebHookCommand $command): PromiseInterface
    {
        return $this->requestService->request($command->getPingUrl())
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->then(function (ResponseInterface $response) {
                return $response->getStatusCode() == 204;
            });
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Github\CommandBus\Handler;
4
5			use ApiClients\Client\Github\CommandBus\Command\PingWebHookCommand;
6			use ApiClients\Foundation\Transport\Service\RequestService;
7			use Psr\Http\Message\ResponseInterface;
8			use React\Promise\PromiseInterface;
9
10			final class PingWebHookHandler
11			{
12			/**
13			* @var RequestService
14			*/
15			private $requestService;
16
17			/**
18			* @param RequestService $requestService
19			*/
20			public function __construct(RequestService $requestService)
21			{
22			$this->requestService = $requestService;
23			}
24
25			/**
26			* @param PingWebHookCommand $command
27			* @return PromiseInterface
28			*/
29			public function handle(PingWebHookCommand $command): PromiseInterface
30			{
31			return $this->requestService->request($command->getPingUrl())
			0 ignored issues – show Documentation introduced 2018-02-13 16:30 UTC by Report Bug Copy Issue Report `$command->getPingUrl()` is of type `string`, but the function expects a `object<Psr\Http\Message\RequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			->then(function (ResponseInterface $response) {
33			return $response->getStatusCode() == 204;
34			});
35			}
36			}
37

php-api-clients / github

GitHub Access Token became invalid

Pull Request — master (#20)

PingWebHookHandler::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like