ReplaceTopicsCommand::__construct() - Code Metrics - Inspection of "Merge pull request #28 from php-api-clients/reposi..." - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3ef44b...b60557 )

by Cees-Jan

created 2017-10-28 07:46 UTC

ReplaceTopicsCommand::__construct() A

↳ Parent: ReplaceTopicsCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2
crap	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\CommandBus\Command\Repository;

use WyriHaximus\Tactician\CommandHandler\Annotations\Handler;

/**
 * @Handler("ApiClients\Client\Github\CommandBus\Handler\Repository\ReplaceTopicsHandler")
 */
final class ReplaceTopicsCommand
{
    /**
     * @var string
     */
    private $repository;

    /**
     * @var string[]
     */
    private $topics;

    /**
     * @param string   $repository
     * @param string[] $topics
     */
    public function __construct($repository, string ...$topics)
    {
        $this->repository = $repository;
        $this->topics = $topics;

    }

    /**
     * @return string
     */
    public function getRepository(): string
    {
        return $this->repository;
    }

    /**
     * @return string[]
     */
    public function getTopics(): array
    {
        return $this->topics;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Github\CommandBus\Command\Repository;
4
5		use WyriHaximus\Tactician\CommandHandler\Annotations\Handler;
6
7		/**
8		* @Handler("ApiClients\Client\Github\CommandBus\Handler\Repository\ReplaceTopicsHandler")
9		*/
10		final class ReplaceTopicsCommand
11		{
12		/**
13		* @var string
14		*/
15		private $repository;
16
17		/**
18		* @var string[]
19		*/
20		private $topics;
21
22		/**
23		* @param string $repository
24		* @param string[] $topics
25		*/
26	1	public function __construct($repository, string ...$topics)
27		{
28	1	$this->repository = $repository;
29	1	$this->topics = $topics;
		0 ignored issues – show Documentation Bug introduced 2017-10-27 19:00 UTC by Report Bug Copy Issue Report It seems like `$topics` of type `array<integer,array<integer,string>>` is incompatible with the declared type `array<integer,string>` of property `$topics`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
30	1	}
31
32		/**
33		* @return string
34		*/
35	1	public function getRepository(): string
36		{
37	1	return $this->repository;
38		}
39
40		/**
41		* @return string[]
42		*/
43	1	public function getTopics(): array
44		{
45	1	return $this->topics;
46		}
47		}
48

php-api-clients / github

GitHub Access Token became invalid

Push — master ( 3ef44b...b60557 )

ReplaceTopicsCommand::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like