Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
8 | View Code Duplication | abstract class EmptyWebHook implements WebHookInterface, EmptyResourceInterface |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * @return int |
||
12 | */ |
||
13 | 2 | public function id(): int |
|
17 | |||
18 | /** |
||
19 | * @return string |
||
20 | */ |
||
21 | 2 | public function url(): string |
|
25 | |||
26 | /** |
||
27 | * @return string |
||
28 | */ |
||
29 | 2 | public function testUrl(): string |
|
33 | |||
34 | /** |
||
35 | * @return string |
||
36 | */ |
||
37 | 2 | public function pingUrl(): string |
|
41 | |||
42 | /** |
||
43 | * @return string |
||
44 | */ |
||
45 | 2 | public function name(): string |
|
49 | |||
50 | /** |
||
51 | * @return array |
||
52 | */ |
||
53 | 2 | public function events(): array |
|
57 | |||
58 | /** |
||
59 | * @return bool |
||
60 | */ |
||
61 | 2 | public function active(): bool |
|
65 | |||
66 | /** |
||
67 | * @return WebHook\Config |
||
68 | */ |
||
69 | 2 | public function config(): WebHook\Config |
|
73 | |||
74 | /** |
||
75 | * @return DateTimeInterface |
||
76 | */ |
||
77 | 2 | public function createdAt(): DateTimeInterface |
|
81 | |||
82 | /** |
||
83 | * @return DateTimeInterface |
||
84 | */ |
||
85 | 2 | public function updatedAt(): DateTimeInterface |
|
89 | } |
||
90 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.