AsyncClient::create() - Code Metrics - Inspection of "Merge pull request #9 from php-api-clients/middlew..." - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e8acb2...700bde )

by Cees-Jan

created 2017-03-26 20:37 UTC

AsyncClient::create() A

↳ Parent: AsyncClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2.0054

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	8
cts	9
cp	0.8889
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	14
nc	2
nop	3
crap	2.0054

<?php declare(strict_types=1);

namespace ApiClients\Client\Github;

use ApiClients\Client\Github\CommandBus\Command;
use ApiClients\Foundation\ClientInterface;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use ApiClients\Foundation\Factory;
use ApiClients\Foundation\Options;
use React\EventLoop\LoopInterface;
use React\Promise\PromiseInterface;
use Rx\Observable;
use function ApiClients\Tools\Rx\unwrapObservableFromPromise;
use function React\Promise\resolve;
use Rx\Scheduler;

final class AsyncClient implements AsyncClientInterface
{
    /**
     * @var ClientInterface
     */
    private $client;

    /**
     * @var RateLimitState
     */
    private $rateLimitState;

    /**
     * @param LoopInterface $loop
     * @param AuthenticationInterface $auth
     * @param array $options
     * @return AsyncClient
     */
    public static function create(
        LoopInterface $loop,
        AuthenticationInterface $auth,
        array $options = []
    ): self {
        $options = ApiSettings::getOptions($auth, $options, 'Async');
        $rateLimitState = new RateLimitState();
        $options[Options::CONTAINER_DEFINITIONS][RateLimitState::class] = $rateLimitState;
        $client = Factory::create($loop, $options);

        try {
            Scheduler::setAsyncFactory(function () use ($loop) {
                return new Scheduler\EventLoopScheduler($loop);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            });
        } catch (\Throwable $t) {

        }

        return new self($client, $rateLimitState);
    }

    /**
     * @param ClientInterface $client
     * @param RateLimitState $rateLimitState
     */
    private function __construct(ClientInterface $client, RateLimitState $rateLimitState)
    {
        $this->client = $client;
        $this->rateLimitState = $rateLimitState;
    }

    public function user(string $user): PromiseInterface
    {
        return $this->client->handle(new Command\UserCommand($user));
    }

    public function whoami(): PromiseInterface
    {
        return $this->client->handle(new Command\UserCommand());
    }

    public function myOrganizations(): Observable
    {
        return unwrapObservableFromPromise($this->client->handle(new Command\MyOrganizationsCommand()));
    }

    /**
     * @return RateLimitState
     */
    public function getRateLimitState(): RateLimitState
    {
        return clone $this->rateLimitState;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Github;
4
5		use ApiClients\Client\Github\CommandBus\Command;
6		use ApiClients\Foundation\ClientInterface;
		0 ignored issues – show Bug introduced 2017-02-18 16:25 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `ApiClients\Client\Github\ClientInterface`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
7		use ApiClients\Foundation\Factory;
8		use ApiClients\Foundation\Options;
9		use React\EventLoop\LoopInterface;
10		use React\Promise\PromiseInterface;
11		use Rx\Observable;
12		use function ApiClients\Tools\Rx\unwrapObservableFromPromise;
13		use function React\Promise\resolve;
14		use Rx\Scheduler;
15
16		final class AsyncClient implements AsyncClientInterface
17		{
18		/**
19		* @var ClientInterface
20		*/
21		private $client;
22
23		/**
24		* @var RateLimitState
25		*/
26		private $rateLimitState;
27
28		/**
29		* @param LoopInterface $loop
30		* @param AuthenticationInterface $auth
31		* @param array $options
32		* @return AsyncClient
33		*/
34	2	public static function create(
35		LoopInterface $loop,
36		AuthenticationInterface $auth,
37		array $options = []
38		): self {
39	2	$options = ApiSettings::getOptions($auth, $options, 'Async');
40	2	$rateLimitState = new RateLimitState();
41	2	$options[Options::CONTAINER_DEFINITIONS][RateLimitState::class] = $rateLimitState;
42	2	$client = Factory::create($loop, $options);
43
44		try {
45	2	Scheduler::setAsyncFactory(function () use ($loop) {
46		return new Scheduler\EventLoopScheduler($loop);
		0 ignored issues – show Documentation introduced 2017-03-25 16:00 UTC by Report Bug Copy Issue Report `$loop` is of type `object<React\EventLoop\LoopInterface>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47	2	});
48		} catch (\Throwable $t) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-25 16:00 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
49		}
50
51	2	return new self($client, $rateLimitState);
52		}
53
54		/**
55		* @param ClientInterface $client
56		* @param RateLimitState $rateLimitState
57		*/
58	2	private function __construct(ClientInterface $client, RateLimitState $rateLimitState)
59		{
60	2	$this->client = $client;
61	2	$this->rateLimitState = $rateLimitState;
62	2	}
63
64		public function user(string $user): PromiseInterface
65		{
66		return $this->client->handle(new Command\UserCommand($user));
67		}
68
69		public function whoami(): PromiseInterface
70		{
71		return $this->client->handle(new Command\UserCommand());
72		}
73
74		public function myOrganizations(): Observable
75		{
76		return unwrapObservableFromPromise($this->client->handle(new Command\MyOrganizationsCommand()));
77		}
78
79		/**
80		* @return RateLimitState
81		*/
82	2	public function getRateLimitState(): RateLimitState
83		{
84	2	return clone $this->rateLimitState;
85		}
86		}
87

php-api-clients / github

GitHub Access Token became invalid

Push — master ( e8acb2...700bde )

AsyncClient::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like