ApiClients\Client\Github\Service\IteratePagesService

Complexity

Total Complexity

17

Size/Duplication

Total Lines	110
Duplicated Lines	10.91 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

45.83%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	2
B	iterate()	6	37	6
A	sendRequest()	0	14	1
C	handleResponse()	6	34	8

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\Service;

use ApiClients\Foundation\Transport\Service\RequestService;
use Psr\Http\Message\ResponseInterface;
use React\Promise\CancellablePromiseInterface;
use RingCentral\Psr7\Request;
use Rx\AsyncSchedulerInterface;
use Rx\Disposable\CallbackDisposable;
use Rx\Observable;
use Rx\ObserverInterface;
use Rx\Scheduler;
use Rx\SchedulerInterface;
use Rx\Subject\Subject;
use function React\Promise\all;
use function React\Promise\resolve;

class IteratePagesService
{
    /**
     * @var RequestService
     */
    private $requestService;

    /**
     * @var AsyncSchedulerInterface
     */
    private $scheduler;

    /**
     * @param RequestService $requestService
     * @param AsyncSchedulerInterface $scheduler
     */
    public function __construct(RequestService $requestService, AsyncSchedulerInterface $scheduler = null)
    {
        $this->scheduler      = $scheduler ?: Scheduler::getAsync();
        $this->requestService = $requestService;
    }

    public function iterate(string $path): Observable
    {
        $paths = new Subject();

        return Observable::of($path, $this->scheduler)
            ->merge($paths)
            ->flatMap(function ($path) {
                return Observable::fromPromise($this->requestService->request(new Request('GET', $path)));
            })
            ->do(function (ResponseInterface $response) use ($paths) {
                if (!$response->hasHeader('link')) {
                    return;
                }

                $links = [
                    'next' => false,
                    'last' => false,
                ];
                foreach (explode(', ', $response->getHeader('link')[0]) as $link) {

This code seems to be duplicated across your project.

                    list($url, $rel) = explode('>; rel="', ltrim(rtrim($link, '"'), '<'));
                    if (isset($links[$rel])) {
                        $links[$rel] = $url;
                    }
                }

                if ($links['next'] === false || $links['last'] === false) {
                    return;
                }

                $this->scheduler->schedule(function () use ($paths, $links) {
                    $paths->onNext($links['next']);
                });
            })
            ->map(function (ResponseInterface $response) {
                return $response->getBody()->getJson();

It seems like you code against a concrete implementation and not the interface Psr\Http\Message\StreamInterface as the method getJson() does only exist in the following implementations of said interface: ApiClients\Middleware\Json\JsonStream.

            });
    }

    private function sendRequest(string $path, Subject $subject)
    {
        $this->requestService->
            request(new Request('GET', $path))->
            then(
                function ($response) use ($subject) {
                    $this->handleResponse($response, $subject);
                },
                function ($error) use ($subject) {
                    $subject->onError($error);
                }
            )
        ;
    }

    private function handleResponse(
        ResponseInterface $response,
        Subject $subject
    ) {
        $subject->onNext($response->getBody()->getJson());

It seems like you code against a concrete implementation and not the interface Psr\Http\Message\StreamInterface as the method getJson() does only exist in the following implementations of said interface: ApiClients\Middleware\Json\JsonStream.

        if ($subject->isDisposed() || !$subject->hasObservers()) {
            $subject->onCompleted();
            return;
        }

        if (!$response->hasHeader('link')) {
            $subject->onCompleted();
            return;
        }

        $links = [
            'next' => false,
            'last' => false,
        ];
        foreach (explode(', ', $response->getHeader('link')[0]) as $link) {

This code seems to be duplicated across your project.

            list($url, $rel) = explode('>; rel="', ltrim(rtrim($link, '"'), '<'));
            if (isset($links[$rel])) {
                $links[$rel] = $url;
            }
        }

        if ($links['next'] === false || $links['last'] === false) {
            $subject->onCompleted();
            return;
        }

        $this->sendRequest($links['next'], $subject);
    }
}