AsyncClient::create() - Code Metrics - Inspection of "Webhooks" - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Cees-Jan

created 2017-07-28 21:22 UTC

AsyncClient::create() A

↳ Parent: AsyncClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2.032

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	8
cts	10
cp	0.8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	14
nc	2
nop	3
crap	2.032

<?php declare(strict_types=1);

namespace ApiClients\Client\Github;

use ApiClients\Client\Github\CommandBus\Command;
use ApiClients\Foundation\ClientInterface;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use ApiClients\Foundation\Factory;
use ApiClients\Foundation\Options;
use ApiClients\Foundation\Resource\ResourceInterface;
use React\EventLoop\LoopInterface;
use React\Promise\CancellablePromiseInterface;
use React\Promise\PromiseInterface;
use Rx\Observable;
use Rx\Scheduler;
use function ApiClients\Tools\Rx\unwrapObservableFromPromise;

final class AsyncClient implements AsyncClientInterface
{
    /**
     * @var ClientInterface
     */
    private $client;

    /**
     * @var RateLimitState
     */
    private $rateLimitState;

    /**
     * @param ClientInterface $client
     * @param RateLimitState  $rateLimitState
     */
    private function __construct(ClientInterface $client, RateLimitState $rateLimitState)
    {
        $this->client = $client;
        $this->rateLimitState = $rateLimitState;
    }

    /**
     * @param  LoopInterface           $loop
     * @param  AuthenticationInterface $auth
     * @param  array                   $options
     * @return AsyncClient
     */
    public static function create(
        LoopInterface $loop,
        AuthenticationInterface $auth,
        array $options = []
    ): self {
        $options = ApiSettings::getOptions($auth, $options, 'Async');
        $rateLimitState = new RateLimitState();
        $options[Options::CONTAINER_DEFINITIONS][RateLimitState::class] = $rateLimitState;
        $client = Factory::create($loop, $options);

        try {
            Scheduler::setAsyncFactory(function () use ($loop) {
                return new Scheduler\EventLoopScheduler($loop);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            });
        } catch (\Throwable $t) {

        }

        return new self($client, $rateLimitState);
    }

    /**
     * @internal
     * @param  ClientInterface $client
     * @param  RateLimitState  $rateLimitState
     * @return AsyncClient
     */
    public static function createFromClient(ClientInterface $client, RateLimitState $rateLimitState): self
    {
        return new self($client, $rateLimitState);
    }

    public function hydrate(string $resource): CancellablePromiseInterface
    {
        return $this->client->hydrate($resource);
    }

    public function extract(ResourceInterface $resource): CancellablePromiseInterface
    {
        return $this->client->extract($resource);
    }

    public function meta(): PromiseInterface
    {
        return $this->client->handle(new Command\MetaCommand());
    }

    /**
     * @param  string           $user
     * @return PromiseInterface
     */
    public function user(string $user): PromiseInterface
    {
        return $this->client->handle(new Command\UserCommand($user));
    }

    /**
     * @param  string           $organization
     * @return PromiseInterface
     */
    public function organization(string $organization): PromiseInterface
    {
        return $this->client->handle(new Command\OrganizationCommand($organization));
    }

    /**
     * @return PromiseInterface
     */
    public function whoami(): PromiseInterface
    {
        return $this->client->handle(new Command\UserCommand());
    }

    /**
     * @return Observable
     */
    public function emojis(): Observable
    {
        return unwrapObservableFromPromise($this->client->handle(new Command\EmojisCommand()));
    }

    public function myOrganizations(): Observable
    {
        return unwrapObservableFromPromise($this->client->handle(new Command\MyOrganizationsCommand()));
    }

    public function licenses(): Observable
    {
        return unwrapObservableFromPromise($this->client->handle(new Command\LicensesCommand()));
    }

    public function watching(): Observable
    {
        return unwrapObservableFromPromise($this->client->handle(new Command\WatchingCommand()));
    }

    /**
     * @return RateLimitState
     */
    public function getRateLimitState(): RateLimitState
    {
        return clone $this->rateLimitState;
    }

    public function rateLimit(): PromiseInterface
    {
        return $this->client->handle(new Command\RateLimitCommand());
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Github;
4
5		use ApiClients\Client\Github\CommandBus\Command;
6		use ApiClients\Foundation\ClientInterface;
		0 ignored issues – show Bug introduced 2017-04-16 14:00 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `ApiClients\Client\Github\ClientInterface`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
7		use ApiClients\Foundation\Factory;
8		use ApiClients\Foundation\Options;
9		use ApiClients\Foundation\Resource\ResourceInterface;
10		use React\EventLoop\LoopInterface;
11		use React\Promise\CancellablePromiseInterface;
12		use React\Promise\PromiseInterface;
13		use Rx\Observable;
14		use Rx\Scheduler;
15		use function ApiClients\Tools\Rx\unwrapObservableFromPromise;
16
17		final class AsyncClient implements AsyncClientInterface
18		{
19		/**
20		* @var ClientInterface
21		*/
22		private $client;
23
24		/**
25		* @var RateLimitState
26		*/
27		private $rateLimitState;
28
29		/**
30		* @param ClientInterface $client
31		* @param RateLimitState $rateLimitState
32		*/
33	2	private function __construct(ClientInterface $client, RateLimitState $rateLimitState)
34		{
35	2	$this->client = $client;
36	2	$this->rateLimitState = $rateLimitState;
37	2	}
38
39		/**
40		* @param LoopInterface $loop
41		* @param AuthenticationInterface $auth
42		* @param array $options
43		* @return AsyncClient
44		*/
45	1	public static function create(
46		LoopInterface $loop,
47		AuthenticationInterface $auth,
48		array $options = []
49		): self {
50	1	$options = ApiSettings::getOptions($auth, $options, 'Async');
51	1	$rateLimitState = new RateLimitState();
52	1	$options[Options::CONTAINER_DEFINITIONS][RateLimitState::class] = $rateLimitState;
53	1	$client = Factory::create($loop, $options);
54
55		try {
56	1	Scheduler::setAsyncFactory(function () use ($loop) {
57		return new Scheduler\EventLoopScheduler($loop);
		0 ignored issues – show Documentation introduced 2017-03-25 16:00 UTC by Report Bug Copy Issue Report `$loop` is of type `object<React\EventLoop\LoopInterface>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58	1	});
59		} catch (\Throwable $t) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-25 16:00 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
60		}
61
62	1	return new self($client, $rateLimitState);
63		}
64
65		/**
66		* @internal
67		* @param ClientInterface $client
68		* @param RateLimitState $rateLimitState
69		* @return AsyncClient
70		*/
71	1	public static function createFromClient(ClientInterface $client, RateLimitState $rateLimitState): self
72		{
73	1	return new self($client, $rateLimitState);
74		}
75
76		public function hydrate(string $resource): CancellablePromiseInterface
77		{
78		return $this->client->hydrate($resource);
79		}
80
81		public function extract(ResourceInterface $resource): CancellablePromiseInterface
82		{
83		return $this->client->extract($resource);
84		}
85
86		public function meta(): PromiseInterface
87		{
88		return $this->client->handle(new Command\MetaCommand());
89		}
90
91		/**
92		* @param string $user
93		* @return PromiseInterface
94		*/
95		public function user(string $user): PromiseInterface
96		{
97		return $this->client->handle(new Command\UserCommand($user));
98		}
99
100		/**
101		* @param string $organization
102		* @return PromiseInterface
103		*/
104		public function organization(string $organization): PromiseInterface
105		{
106		return $this->client->handle(new Command\OrganizationCommand($organization));
107		}
108
109		/**
110		* @return PromiseInterface
111		*/
112		public function whoami(): PromiseInterface
113		{
114		return $this->client->handle(new Command\UserCommand());
115		}
116
117		/**
118		* @return Observable
119		*/
120		public function emojis(): Observable
121		{
122		return unwrapObservableFromPromise($this->client->handle(new Command\EmojisCommand()));
123		}
124
125		public function myOrganizations(): Observable
126		{
127		return unwrapObservableFromPromise($this->client->handle(new Command\MyOrganizationsCommand()));
128		}
129
130		public function licenses(): Observable
131		{
132		return unwrapObservableFromPromise($this->client->handle(new Command\LicensesCommand()));
133		}
134
135		public function watching(): Observable
136		{
137		return unwrapObservableFromPromise($this->client->handle(new Command\WatchingCommand()));
138		}
139
140		/**
141		* @return RateLimitState
142		*/
143	2	public function getRateLimitState(): RateLimitState
144		{
145	2	return clone $this->rateLimitState;
146		}
147
148		public function rateLimit(): PromiseInterface
149		{
150		return $this->client->handle(new Command\RateLimitCommand());
151		}
152		}
153

php-api-clients / github

GitHub Access Token became invalid

Pull Request — master (#20)

AsyncClient::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like