Commit - Code Metrics - Inspection of "Webhooks" - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Cees-Jan

created 2017-07-28 21:22 UTC

Commit A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	106
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

62.5%

Importance

Changes

Metric	Value
wmc	8
lcom	0
cbo	1
dl	106
loc	106
ccs	10
cts	16
cp	0.625
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	sha()	4	4	1
A	url()	4	4	1
A	author()	4	4	1
A	comitter()	4	4	1
A	message()	4	4	1
A	tree()	4	4	1
A	commentCount()	4	4	1
A	protectionUrl()	4	4	1

How to fix Duplicated Code

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\Resource\Git;

use ApiClients\Client\Github\Resource\TreeInterface;
use ApiClients\Foundation\Hydrator\Annotation\EmptyResource;
use ApiClients\Foundation\Hydrator\Annotation\Nested;
use ApiClients\Foundation\Resource\AbstractResource;

/**
 * @Nested(
 *     author="User",
 *     comitter="User",
 *     tree="Tree"
 * )
 * @EmptyResource("Git\EmptyCommit")
 */
abstract class Commit extends AbstractResource implements CommitInterface

{
    /**
     * @var string
     */
    protected $sha;

    /**
     * @var string
     */
    protected $url;

    /**
     * @var User
     */
    protected $author;

    /**
     * @var User
     */
    protected $comitter;

    /**
     * @var string
     */
    protected $message;

    /**
     * @var Tree
     */
    protected $tree;

    /**
     * @var int
     */
    protected $comment_count;

    /**
     * @var string
     */
    protected $protection_url;

    /**
     * @return string
     */
    public function sha(): string
    {
        return $this->sha;
    }

    /**
     * @return string
     */
    public function url(): string
    {
        return $this->url;
    }

    /**
     * @return User
     */
    public function author(): User
    {
        return $this->author;
    }

    /**
     * @return User
     */
    public function comitter(): User
    {
        return $this->comitter;
    }

    /**
     * @return string
     */
    public function message(): string
    {
        return $this->message;
    }

    /**
     * @return TreeInterface
     */
    public function tree(): TreeInterface
    {
        return $this->tree;
    }

    /**
     * @return int
     */
    public function commentCount(): int
    {
        return $this->comment_count;
    }

    /**
     * @return string
     */
    public function protectionUrl(): string
    {
        return $this->protection_url;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Github\Resource\Git;
4
5			use ApiClients\Client\Github\Resource\TreeInterface;
6			use ApiClients\Foundation\Hydrator\Annotation\EmptyResource;
7			use ApiClients\Foundation\Hydrator\Annotation\Nested;
8			use ApiClients\Foundation\Resource\AbstractResource;
9
10			/**
11			* @Nested(
12			* author="User",
13			* comitter="User",
14			* tree="Tree"
15			* )
16			* @EmptyResource("Git\EmptyCommit")
17			*/
18		View Code Duplication	abstract class Commit extends AbstractResource implements CommitInterface
			0 ignored issues – show Duplication introduced 2017-07-27 20:46 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19			{
20			/**
21			* @var string
22			*/
23			protected $sha;
24
25			/**
26			* @var string
27			*/
28			protected $url;
29
30			/**
31			* @var User
32			*/
33			protected $author;
34
35			/**
36			* @var User
37			*/
38			protected $comitter;
39
40			/**
41			* @var string
42			*/
43			protected $message;
44
45			/**
46			* @var Tree
47			*/
48			protected $tree;
49
50			/**
51			* @var int
52			*/
53			protected $comment_count;
54
55			/**
56			* @var string
57			*/
58			protected $protection_url;
59
60			/**
61			* @return string
62			*/
63	4		public function sha(): string
64			{
65	4		return $this->sha;
66			}
67
68			/**
69			* @return string
70			*/
71	4		public function url(): string
72			{
73	4		return $this->url;
74			}
75
76			/**
77			* @return User
78			*/
79			public function author(): User
80			{
81			return $this->author;
82			}
83
84			/**
85			* @return User
86			*/
87			public function comitter(): User
88			{
89			return $this->comitter;
90			}
91
92			/**
93			* @return string
94			*/
95	4		public function message(): string
96			{
97	4		return $this->message;
98			}
99
100			/**
101			* @return TreeInterface
102			*/
103			public function tree(): TreeInterface
104			{
105			return $this->tree;
106			}
107
108			/**
109			* @return int
110			*/
111	4		public function commentCount(): int
112			{
113	4		return $this->comment_count;
114			}
115
116			/**
117			* @return string
118			*/
119	4		public function protectionUrl(): string
120			{
121	4		return $this->protection_url;
122			}
123			}
124

php-api-clients / github

GitHub Access Token became invalid

Pull Request — master (#20)

Commit A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like