Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
8 | View Code Duplication | abstract class EmptyApp implements AppInterface, EmptyResourceInterface |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * @return int |
||
12 | */ |
||
13 | public function id(): int |
||
17 | |||
18 | /** |
||
19 | * @return string |
||
20 | */ |
||
21 | public function slug(): string |
||
25 | |||
26 | /** |
||
27 | * @return User |
||
28 | */ |
||
29 | public function owner(): User |
||
33 | |||
34 | /** |
||
35 | * @return string |
||
36 | */ |
||
37 | public function name(): string |
||
41 | |||
42 | /** |
||
43 | * @return string |
||
44 | */ |
||
45 | public function description(): string |
||
49 | |||
50 | /** |
||
51 | * @return string |
||
52 | */ |
||
53 | public function externalUrl(): string |
||
57 | |||
58 | /** |
||
59 | * @return string |
||
60 | */ |
||
61 | public function htmlUrl(): string |
||
65 | |||
66 | /** |
||
67 | * @return DateTimeInterface |
||
68 | */ |
||
69 | public function createdAt(): DateTimeInterface |
||
73 | |||
74 | /** |
||
75 | * @return DateTimeInterface |
||
76 | */ |
||
77 | public function updatedAt(): DateTimeInterface |
||
81 | |||
82 | /** |
||
83 | * @return array |
||
84 | */ |
||
85 | public function permissions(): array |
||
89 | |||
90 | /** |
||
91 | * @return array |
||
92 | */ |
||
93 | public function events(): array |
||
97 | |||
98 | /** |
||
99 | * @return int |
||
100 | */ |
||
101 | public function installationsCount(): int |
||
105 | } |
||
106 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.