File::update() - Code Metrics - Inspection of "Watching repositories" - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Cees-Jan

created 2017-07-13 19:23 UTC

File::update() A

↳ Parent: File

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	0
cp	0
cc	1
eloc	5
nc	1
nop	2
crap	2

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\Resource\Async\Contents;

use ApiClients\Client\Github\CommandBus\Command\RefreshCommand;
use ApiClients\Client\Github\Resource\Contents\File as BaseFile;
use React\Promise\CancellablePromiseInterface;
use React\Stream\ReadableStreamInterface;
use React\Stream\ThroughStream;

class File extends BaseFile
{
    public function refresh(): CancellablePromiseInterface
    {
        return $this->handleCommand(new RefreshCommand($this));
    }

    public function update(
        ReadableStreamInterface $contents,

        string $message = null

    ): CancellablePromiseInterface {
        $bodyStream = new ThroughStream();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Github\Resource\Async\Contents;
4
5			use ApiClients\Client\Github\CommandBus\Command\RefreshCommand;
6			use ApiClients\Client\Github\Resource\Contents\File as BaseFile;
7			use React\Promise\CancellablePromiseInterface;
8			use React\Stream\ReadableStreamInterface;
9			use React\Stream\ThroughStream;
10
11			class File extends BaseFile
12			{
13			public function refresh(): CancellablePromiseInterface
14			{
15			return $this->handleCommand(new RefreshCommand($this));
16			}
17
18			public function update(
19			ReadableStreamInterface $contents,
			0 ignored issues – show Unused Code introduced 2017-07-13 19:32 UTC by Report Bug Copy Issue Report The parameter `$contents` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
20			string $message = null
			0 ignored issues – show Unused Code introduced 2017-07-13 19:32 UTC by Report Bug Copy Issue Report The parameter `$message` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21			): CancellablePromiseInterface {
22			$bodyStream = new ThroughStream();
			0 ignored issues – show Unused Code introduced 2017-07-13 19:32 UTC by Report Bug Copy Issue Report `$bodyStream` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
23			}
24			}
25

php-api-clients / github

GitHub Access Token became invalid

Pull Request — master (#21)

File::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like