IteratePagesService::sendRequest() - Code Metrics - Inspection of "Merge pull request #6 from php-api-clients/transfo..." - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da3f05...bbcd68 )

by Cees-Jan

created 2017-03-24 15:23 UTC

IteratePagesService::sendRequest() A

↳ Parent: IteratePagesService

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	2
crap	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\Service;

use ApiClients\Foundation\Transport\Service\RequestService;
use Psr\Http\Message\ResponseInterface;
use React\Promise\CancellablePromiseInterface;
use RingCentral\Psr7\Request;
use Rx\Disposable\CallbackDisposable;
use Rx\Observable;
use Rx\ObserverInterface;
use Rx\SchedulerInterface;
use Rx\Subject\Subject;
use function React\Promise\all;
use function React\Promise\resolve;

class IteratePagesService
{
    /**
     * @var RequestService
     */
    private $requestService;

    /**
     * @param RequestService $requestService
     */
    public function __construct(RequestService $requestService)
    {
        $this->requestService = $requestService;
    }

    public function iterate(string $path): Observable
    {
        return Observable::create(function (
            ObserverInterface $observer
        ) use ($path) {
            $subject = new Subject();
            $subject->asObservable()->subscribe(
                [$observer, 'onNext'],
                [$observer, 'onError'],
                [$observer, 'onCompleted']
            );

            $this->sendRequest($path, $subject);

            return new CallbackDisposable(function () use ($subject) {
                $subject->dispose();
            });
        });
    }

    private function sendRequest(string $path, Subject $subject)
    {
        $this->requestService->
            handle(new Request('GET', $path))->
            then(
                function ($response) use ($subject) {
                    $this->handleResponse($response, $subject);
                },
                function ($error) use ($subject) {
                    $subject->onError($error);
                }
            )
        ;
    }

    private function handleResponse(
        ResponseInterface $response,
        Subject $subject
    ) {
        $subject->onNext($response->getBody()->getJson());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        if ($subject->isDisposed() || !$subject->hasObservers()) {
            $subject->onCompleted();
            return;
        }

        if (!$response->hasHeader('link')) {
            $subject->onCompleted();
            return;
        }

        $links = [
            'next' => false,
            'last' => false,
        ];
        foreach (explode(', ', $response->getHeader('link')[0]) as $link) {
            list($url, $rel) = explode('>; rel="', ltrim(rtrim($link, '"'), '<'));
            if (isset($links[$rel])) {
                $links[$rel] = $url;
            }
        }

        if ($links['next'] === false || $links['last'] === false) {
            $subject->onCompleted();
            return;
        }

        $this->sendRequest($links['next'], $subject);
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\Github\Service;
4
5		use ApiClients\Foundation\Transport\Service\RequestService;
6		use Psr\Http\Message\ResponseInterface;
7		use React\Promise\CancellablePromiseInterface;
8		use RingCentral\Psr7\Request;
9		use Rx\Disposable\CallbackDisposable;
10		use Rx\Observable;
11		use Rx\ObserverInterface;
12		use Rx\SchedulerInterface;
13		use Rx\Subject\Subject;
14		use function React\Promise\all;
15		use function React\Promise\resolve;
16
17		class IteratePagesService
18		{
19		/**
20		* @var RequestService
21		*/
22		private $requestService;
23
24		/**
25		* @param RequestService $requestService
26		*/
27	2	public function __construct(RequestService $requestService)
28		{
29	2	$this->requestService = $requestService;
30	2	}
31
32	2	public function iterate(string $path): Observable
33		{
34		return Observable::create(function (
35		ObserverInterface $observer
36		) use ($path) {
37	2	$subject = new Subject();
38	2	$subject->asObservable()->subscribe(
39	2	[$observer, 'onNext'],
40	2	[$observer, 'onError'],
41	2	[$observer, 'onCompleted']
42		);
43
44	2	$this->sendRequest($path, $subject);
45
46		return new CallbackDisposable(function () use ($subject) {
47	2	$subject->dispose();
48	2	});
49	2	});
50		}
51
52	2	private function sendRequest(string $path, Subject $subject)
53		{
54	2	$this->requestService->
55	2	handle(new Request('GET', $path))->
56	2	then(
57		function ($response) use ($subject) {
58	2	$this->handleResponse($response, $subject);
59	2	},
60	2	function ($error) use ($subject) {
61		$subject->onError($error);
62	2	}
63		)
64		;
65	2	}
66
67	2	private function handleResponse(
68		ResponseInterface $response,
69		Subject $subject
70		) {
71	2	$subject->onNext($response->getBody()->getJson());
		0 ignored issues – show Bug introduced 2017-01-14 12:57 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
72
73	2	if ($subject->isDisposed() \|\| !$subject->hasObservers()) {
74		$subject->onCompleted();
75		return;
76		}
77
78	2	if (!$response->hasHeader('link')) {
79		$subject->onCompleted();
80		return;
81		}
82
83		$links = [
84	2	'next' => false,
85		'last' => false,
86		];
87	2	foreach (explode(', ', $response->getHeader('link')[0]) as $link) {
88	2	list($url, $rel) = explode('>; rel="', ltrim(rtrim($link, '"'), '<'));
89	2	if (isset($links[$rel])) {
90	2	$links[$rel] = $url;
91		}
92		}
93
94	2	if ($links['next'] === false \|\| $links['last'] === false) {
95	1	$subject->onCompleted();
96	1	return;
97		}
98
99	2	$this->sendRequest($links['next'], $subject);
100	2	}
101		}
102

php-api-clients / github

GitHub Access Token became invalid

Push — master ( da3f05...bbcd68 )

IteratePagesService::sendRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like