IteratePagesHandler::handle() - Code Metrics - Inspection of "Updated user repositories example" - php-api-clients/github - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3e65ba...cab908 )

by Cees-Jan

created 2016-11-21 17:09 UTC

IteratePagesHandler::handle() A

↳ Parent: IteratePagesHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	11
nc	1
nop	1

<?php declare(strict_types=1);

namespace ApiClients\Client\Github\CommandBus\Handler;

use ApiClients\Foundation\Transport\CommandBus\Command\SimpleRequestCommand;
use ApiClients\Client\Github\CommandBus\Command\IteratePagesCommand;
use ApiClients\Tools\CommandBus\CommandBus;
use Psr\Http\Message\ResponseInterface;
use React\Promise\CancellablePromiseInterface;
use React\Promise\FulfilledPromise;
use Rx\Disposable\CallbackDisposable;
use Rx\Observable;
use Rx\ObserverInterface;
use Rx\SchedulerInterface;
use function React\Promise\all;
use function React\Promise\resolve;

class IteratePagesHandler
{
    /**
     * @var CommandBus
     */
    private $commandBus;

    /**
     * @param CommandBus $commandBus
     */
    public function __construct(CommandBus $commandBus)
    {
        $this->commandBus = $commandBus;
    }

    public function handle(IteratePagesCommand $command): CancellablePromiseInterface
    {
        return resolve(Observable::create(function (
            ObserverInterface $observer,
            SchedulerInterface $scheduler

        ) use ($command) {
            $promise = $this->commandBus->
                handle(new SimpleRequestCommand($command->getPath()))->
                done(function ($response) use ($observer) {
                    return $this->handleResponse($response, $observer);
                })
            ;

            return new CallbackDisposable(function () use ($promise) {
                $promise->cancel();
            });
        }));
    }

    private function handleResponse(
        ResponseInterface $response,
        ObserverInterface $observer
    ): CancellablePromiseInterface {
        if (!$response->hasHeader('link')) {
            return $this->handleResponseContentsComplete($response, $observer);
        }

        $links = [
            'next' => false,
            'last' => false,
        ];
        foreach (explode(', ', $response->getHeader('link')[0]) as $link) {
            list($url, $rel) = explode('>; rel="', ltrim(rtrim($link, '"'), '<'));
            if (isset($links[$rel])) {
                $links[$rel] = $url;
            }
        }

        if ($links['next'] === false || $links['last'] === false) {
            return $this->handleResponseContentsComplete($response, $observer);
        }

        if ($links['next'] == $links['last']) {
            return $this->handleResponseContentsComplete($response, $observer);
        }

        $promises = [];

        $promises[] = $this->commandBus->
            handle(new SimpleRequestCommand($links['next']))->
            then(function (ResponseInterface $response) use ($observer) {
                return $this->handleResponse($response, $observer);
            })
        ;

        $promises[] = $this->handleResponseContents($response, $observer);

        return all($promises);
    }

    private function handleResponseContentsComplete(
        ResponseInterface $response,
        ObserverInterface $observer
    ): CancellablePromiseInterface {
        return $this->handleResponseContents($response, $observer)->then(function () use ($observer) {
            $observer->onCompleted();
            return new FulfilledPromise();
        });
    }

    private function handleResponseContents(
        ResponseInterface $response,
        ObserverInterface $observer
    ): CancellablePromiseInterface {
        $observer->onNext($response->getBody()->getJson());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return new FulfilledPromise();
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\Github\CommandBus\Handler;
4
5			use ApiClients\Foundation\Transport\CommandBus\Command\SimpleRequestCommand;
6			use ApiClients\Client\Github\CommandBus\Command\IteratePagesCommand;
7			use ApiClients\Tools\CommandBus\CommandBus;
8			use Psr\Http\Message\ResponseInterface;
9			use React\Promise\CancellablePromiseInterface;
10			use React\Promise\FulfilledPromise;
11			use Rx\Disposable\CallbackDisposable;
12			use Rx\Observable;
13			use Rx\ObserverInterface;
14			use Rx\SchedulerInterface;
15			use function React\Promise\all;
16			use function React\Promise\resolve;
17
18			class IteratePagesHandler
19			{
20			/**
21			* @var CommandBus
22			*/
23			private $commandBus;
24
25			/**
26			* @param CommandBus $commandBus
27			*/
28			public function __construct(CommandBus $commandBus)
29			{
30			$this->commandBus = $commandBus;
31			}
32
33			public function handle(IteratePagesCommand $command): CancellablePromiseInterface
34			{
35			return resolve(Observable::create(function (
36			ObserverInterface $observer,
37			SchedulerInterface $scheduler
			0 ignored issues – show Unused Code introduced 2016-11-20 16:16 UTC by Report Bug Copy Issue Report The parameter `$scheduler` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
38			) use ($command) {
39			$promise = $this->commandBus->
40			handle(new SimpleRequestCommand($command->getPath()))->
41			done(function ($response) use ($observer) {
42			return $this->handleResponse($response, $observer);
43			})
44			;
45
46			return new CallbackDisposable(function () use ($promise) {
47			$promise->cancel();
48			});
49			}));
50			}
51
52			private function handleResponse(
53			ResponseInterface $response,
54			ObserverInterface $observer
55			): CancellablePromiseInterface {
56			if (!$response->hasHeader('link')) {
57			return $this->handleResponseContentsComplete($response, $observer);
58			}
59
60			$links = [
61			'next' => false,
62			'last' => false,
63			];
64			foreach (explode(', ', $response->getHeader('link')[0]) as $link) {
65			list($url, $rel) = explode('>; rel="', ltrim(rtrim($link, '"'), '<'));
66			if (isset($links[$rel])) {
67			$links[$rel] = $url;
68			}
69			}
70
71			if ($links['next'] === false \|\| $links['last'] === false) {
72			return $this->handleResponseContentsComplete($response, $observer);
73			}
74
75			if ($links['next'] == $links['last']) {
76			return $this->handleResponseContentsComplete($response, $observer);
77			}
78
79			$promises = [];
80
81			$promises[] = $this->commandBus->
82			handle(new SimpleRequestCommand($links['next']))->
83			then(function (ResponseInterface $response) use ($observer) {
84			return $this->handleResponse($response, $observer);
85			})
86			;
87
88			$promises[] = $this->handleResponseContents($response, $observer);
89
90			return all($promises);
91			}
92
93			private function handleResponseContentsComplete(
94			ResponseInterface $response,
95			ObserverInterface $observer
96			): CancellablePromiseInterface {
97			return $this->handleResponseContents($response, $observer)->then(function () use ($observer) {
98			$observer->onCompleted();
99			return new FulfilledPromise();
100			});
101			}
102
103			private function handleResponseContents(
104			ResponseInterface $response,
105			ObserverInterface $observer
106			): CancellablePromiseInterface {
107			$observer->onNext($response->getBody()->getJson());
			0 ignored issues – show Bug introduced 2016-11-21 17:17 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getJson()` does only exist in the following implementations of said interface: `ApiClients\Foundation\Transport\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
108			return new FulfilledPromise();
109			}
110			}
111

php-api-clients / github

GitHub Access Token became invalid

Push — master ( 3e65ba...cab908 )

IteratePagesHandler::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like