Mapping::gather() - Code Metrics - Inspection of "Merge pull request #17 from php-api-clients/update..." - php-api-clients/command-bus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ea7902...4799ee )

by Cees-Jan

created 2018-10-14 08:44 UTC

Mapping::gather() A

↳ Parent: Mapping

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3.0032

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	13
cts	14
cp	0.9286
rs	9.6333
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	3.0032

<?php declare(strict_types=1);

namespace ApiClients\Tools\CommandBus;

use PackageVersions\Versions;
use WyriHaximus\Tactician\CommandHandler\Mapper;

/**
 * @internal
 */
final class Mapping
{
    public static function resolve(iterable $directories, ?string $cacheFile): iterable
    {
        if ($cacheFile !== null && file_exists($cacheFile)) {
            $commandToHandlerMap = Cache::read($cacheFile);
            if (count($commandToHandlerMap) > 0) {
                return $commandToHandlerMap;
            }
        }

        $commandToHandlerMap = self::gather($directories);

        if ($cacheFile !== null && is_dir(dirname($cacheFile))) {
            Cache::write($cacheFile, $commandToHandlerMap);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $commandToHandlerMap;
    }

    private static function gather(iterable $directories): iterable
    {
        $mapperVersion = version_compare(
            explode(
                '@',
                Versions::getVersion('wyrihaximus/tactician-command-handler-mapper')
            )[0],
            '2.0.0',
            '<'
        );

        foreach ($directories as $path => $namespace) {
            $args = [$path];
            if ($mapperVersion) {
                $args[] = $namespace;
            }
            yield from Mapper::map(...$args);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Tools\CommandBus;
4
5		use PackageVersions\Versions;
6		use WyriHaximus\Tactician\CommandHandler\Mapper;
7
8		/**
9		* @internal
10		*/
11		final class Mapping
12		{
13	2	public static function resolve(iterable $directories, ?string $cacheFile): iterable
14		{
15	2	if ($cacheFile !== null && file_exists($cacheFile)) {
16		$commandToHandlerMap = Cache::read($cacheFile);
17		if (count($commandToHandlerMap) > 0) {
18		return $commandToHandlerMap;
19		}
20		}
21
22	2	$commandToHandlerMap = self::gather($directories);
23
24	2	if ($cacheFile !== null && is_dir(dirname($cacheFile))) {
25		Cache::write($cacheFile, $commandToHandlerMap);
		0 ignored issues – show Documentation introduced 2018-10-13 23:25 UTC by Report Bug Copy Issue Report `$commandToHandlerMap` is of type `object<Generator>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26		}
27
28	2	return $commandToHandlerMap;
29		}
30
31	2	private static function gather(iterable $directories): iterable
32		{
33	2	$mapperVersion = version_compare(
34	2	explode(
35	2	'@',
36	2	Versions::getVersion('wyrihaximus/tactician-command-handler-mapper')
37	2	)[0],
38	2	'2.0.0',
39	2	'<'
40		);
41
42	2	foreach ($directories as $path => $namespace) {
43	1	$args = [$path];
44	1	if ($mapperVersion) {
45		$args[] = $namespace;
46		}
47	1	yield from Mapper::map(...$args);
		0 ignored issues – show Documentation introduced 2018-10-14 08:30 UTC by Report Bug Copy Issue Report `$args` is of type `array<integer,?>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48		}
49	2	}
50		}
51

php-api-clients / command-bus

GitHub Access Token became invalid

Push — master ( ea7902...4799ee )

Mapping::gather() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like