AsyncClient::project() - Code Metrics - Inspection of "Brought this client up to spec with the latest way..." - php-api-clients/appveyor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1177c8...d9fbae )

by Cees-Jan

created 2017-05-05 07:26 UTC

AsyncClient::project() A

↳ Parent: AsyncClient::create()

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	6
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php declare(strict_types=1);

namespace ApiClients\Client\AppVeyor;

use ApiClients\Client\AppVeyor\CommandBus\Command\ProjectCommand;
use ApiClients\Client\AppVeyor\CommandBus\Command\ProjectsCommand;
use ApiClients\Foundation\ClientInterface;
use ApiClients\Foundation\Factory;
use React\EventLoop\LoopInterface;
use React\Promise\PromiseInterface;
use Rx\Observable;
use Rx\ObservableInterface;
use Rx\React\Promise;
use function ApiClients\Tools\Rx\unwrapObservableFromPromise;
use function React\Promise\resolve;
use Rx\Scheduler;

class AsyncClient
{
    /**
     * @var ClientInterface
     */
    private $client;

    /**
     * @param LoopInterface $loop
     * @param string $token
     * @param array $options
     * @return AsyncClient
     */
    public static function create(
        LoopInterface $loop,
        string $token,
        array $options = []
    ): self {
        $options = ApiSettings::getOptions($token, $options, 'Async');
        $client = Factory::create($loop, $options);

        try {
            Scheduler::setAsyncFactory(function () use ($loop) {
                return new Scheduler\EventLoopScheduler($loop);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            });
        } catch (\Throwable $t) {

        }

        return new self($client);
    }

    /**
     * @internal
     * @param ClientInterface $client
     * @return AsyncClient
     */
    public static function createFromClient(ClientInterface $client): self
    {
        return new self($client);
    }

    /**
     * @param ClientInterface $client
     */
    private function __construct(ClientInterface $client)
    {
        $this->client = $client;
    }

    public function projects(): ObservableInterface
    {
        return unwrapObservableFromPromise($this->client->handle(new ProjectsCommand()));
    }

    public function project(string $repository): PromiseInterface
    {
        return $this->client->handle(new ProjectCommand($repository));
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\AppVeyor;
4
5			use ApiClients\Client\AppVeyor\CommandBus\Command\ProjectCommand;
6			use ApiClients\Client\AppVeyor\CommandBus\Command\ProjectsCommand;
7			use ApiClients\Foundation\ClientInterface;
8			use ApiClients\Foundation\Factory;
9			use React\EventLoop\LoopInterface;
10			use React\Promise\PromiseInterface;
11			use Rx\Observable;
12			use Rx\ObservableInterface;
13			use Rx\React\Promise;
14			use function ApiClients\Tools\Rx\unwrapObservableFromPromise;
15			use function React\Promise\resolve;
16			use Rx\Scheduler;
17
18			class AsyncClient
19			{
20			/**
21			* @var ClientInterface
22			*/
23			private $client;
24
25			/**
26			* @param LoopInterface $loop
27			* @param string $token
28			* @param array $options
29			* @return AsyncClient
30			*/
31			public static function create(
32			LoopInterface $loop,
33			string $token,
34			array $options = []
35			): self {
36			$options = ApiSettings::getOptions($token, $options, 'Async');
37			$client = Factory::create($loop, $options);
38
39			try {
40			Scheduler::setAsyncFactory(function () use ($loop) {
41			return new Scheduler\EventLoopScheduler($loop);
			0 ignored issues – show Documentation introduced 2017-05-05 07:37 UTC by Report Bug Copy Issue Report `$loop` is of type `object<React\EventLoop\LoopInterface>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			});
43			} catch (\Throwable $t) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-05-05 07:37 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
44			}
45
46			return new self($client);
47			}
48
49			/**
50			* @internal
51			* @param ClientInterface $client
52			* @return AsyncClient
53			*/
54			public static function createFromClient(ClientInterface $client): self
55			{
56			return new self($client);
57			}
58
59			/**
60			* @param ClientInterface $client
61			*/
62			private function __construct(ClientInterface $client)
63			{
64			$this->client = $client;
65			}
66
67			public function projects(): ObservableInterface
68			{
69			return unwrapObservableFromPromise($this->client->handle(new ProjectsCommand()));
70			}
71
72			public function project(string $repository): PromiseInterface
73			{
74			return $this->client->handle(new ProjectCommand($repository));
75			}
76			}
77

php-api-clients / appveyor

GitHub Access Token became invalid

Push — master ( 1177c8...d9fbae )

AsyncClient::project() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like