Client - Code Metrics - Inspection of "Brought this client up to spec with the latest way..." - php-api-clients/appveyor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1177c8...d9fbae )

by Cees-Jan

created 2017-05-05 07:26 UTC

Client A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	16.67 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	4
dl	6
loc	36
ccs	0
cts	28
cp	0
rs	10
c	0
b	0
f	0

How to fix Duplicated Code

<?php declare(strict_types=1);

namespace ApiClients\Client\AppVeyor;

use ApiClients\Client\AppVeyor\Resource\Sync\Project;
use ApiClients\Foundation\Factory as FoundationClientFactory;
use ApiClients\Foundation\Transport\Client as Transport;
use ApiClients\Foundation\Transport\Factory;
use React\EventLoop\Factory as LoopFactory;
use React\EventLoop\LoopInterface;
use Rx\React\Promise;
use function Clue\React\Block\await;
use Rx\Scheduler;

class Client
{
    /**
     * @var LoopInterface
     */
    private $loop;

    /**
     * @var AsyncClient
     */
    private $client;

    /**
     * @param string $token
     * @param array $options
     * @return Client
     */
    public static function create(
        string $token,
        array $options = []
    ): self {
        $loop = LoopFactory::create();
        $options = ApiSettings::getOptions($token,$options, 'Sync');
        $client = FoundationClientFactory::create($loop, $options);

        try {
            Scheduler::setAsyncFactory(function () use ($loop) {
                return new Scheduler\EventLoopScheduler($loop);
            });
        } catch (\Throwable $t) {

        }

        $asyncClient = AsyncClient::createFromClient($client);

        return new self($loop, $asyncClient);
    }

    /**
     * @param LoopInterface $loop
     * @param AsyncClient $client
     */
    private function __construct(LoopInterface $loop, AsyncClient $client)
    {
        $this->loop = $loop;
        $this->client = $client;
    }

    public function projects(): array
    {
        return await(
            Promise::fromObservable(
                $this->client->projects()->toArray()
            ),
            $this->loop
        );
    }

    public function project(string $repository): Project
    {
        return await(
            $this->client->project($repository),
            $this->loop
        );
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiClients\Client\AppVeyor;
4
5			use ApiClients\Client\AppVeyor\Resource\Sync\Project;
6			use ApiClients\Foundation\Factory as FoundationClientFactory;
7			use ApiClients\Foundation\Transport\Client as Transport;
8			use ApiClients\Foundation\Transport\Factory;
9			use React\EventLoop\Factory as LoopFactory;
10			use React\EventLoop\LoopInterface;
11			use Rx\React\Promise;
12			use function Clue\React\Block\await;
13			use Rx\Scheduler;
14
15			class Client
16			{
17			/**
18			* @var LoopInterface
19			*/
20			private $loop;
21
22			/**
23			* @var AsyncClient
24			*/
25			private $client;
26
27			/**
28			* @param string $token
29			* @param array $options
30			* @return Client
31			*/
32			public static function create(
33			string $token,
34			array $options = []
35			): self {
36			$loop = LoopFactory::create();
37			$options = ApiSettings::getOptions($token,$options, 'Sync');
38			$client = FoundationClientFactory::create($loop, $options);
39
40			try {
41			Scheduler::setAsyncFactory(function () use ($loop) {
42			return new Scheduler\EventLoopScheduler($loop);
43			});
44			} catch (\Throwable $t) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-05-05 07:37 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
45			}
46
47			$asyncClient = AsyncClient::createFromClient($client);
48
49			return new self($loop, $asyncClient);
50			}
51
52			/**
53			* @param LoopInterface $loop
54			* @param AsyncClient $client
55			*/
56			private function __construct(LoopInterface $loop, AsyncClient $client)
57			{
58			$this->loop = $loop;
59			$this->client = $client;
60			}
61
62			public function projects(): array
63			{
64			return await(
65			Promise::fromObservable(
66			$this->client->projects()->toArray()
67			),
68			$this->loop
69			);
70			}
71
72			public function project(string $repository): Project
73			{
74			return await(
75			$this->client->project($repository),
76			$this->loop
77			);
78			}
79			}
80

php-api-clients / appveyor

GitHub Access Token became invalid

Push — master ( 1177c8...d9fbae )

Client A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like