AddProjectHandler::handle() - Code Metrics - php-api-clients/appveyor - Measure and Improve Code Quality continuously with Scrutinizer

AddProjectHandler::handle() A
last analyzed 2019-01-22 01:16 UTC

↳ Parent: AddProjectHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	19
ccs	14
cts	14
cp	1
crap	1
rs	9.6333
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace ApiClients\Client\AppVeyor\CommandBus\Handler;

use ApiClients\Client\AppVeyor\CommandBus\Command\AddProjectCommand;
use ApiClients\Client\AppVeyor\Resource\ProjectInterface;
use ApiClients\Foundation\Hydrator\Hydrator;
use ApiClients\Foundation\Transport\Service\RequestService;
use ApiClients\Middleware\Json\JsonStream;
use Psr\Http\Message\ResponseInterface;
use React\Promise\PromiseInterface;
use RingCentral\Psr7\Request;

final class AddProjectHandler
{
    /**
     * @var RequestService
     */
    private $requestService;

    /**
     * @var Hydrator
     */
    private $hydrator;

    /**
     * @param RequestService $requestService
     * @param Hydrator       $hydrator
     */
    public function __construct(RequestService $requestService, Hydrator $hydrator)
    {
        $this->requestService = $requestService;
        $this->hydrator = $hydrator;
    }

    /**
     * @param  AddProjectCommand $command
     * @return PromiseInterface
     */
    public function handle(AddProjectCommand $command): PromiseInterface
    {
        return $this->requestService->request(
            new Request(
                'POST',
                'projects',
                [],
                new JsonStream([
                    'repositoryProvider' => $command->getProvider(),
                    'repositoryName' => $command->getRepository(),
                ])
            )
        )->then(function (ResponseInterface $response) {
            return $this->hydrator->hydrate(
                ProjectInterface::HYDRATE_CLASS,
                $response->getBody()->getParsedContents()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            );
        });
    }
}


GitHub Access Token became invalid

AddProjectHandler::handle() A
last analyzed 2019-01-22 01:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

1		<?php declare(strict_types=1);
2
3		namespace ApiClients\Client\AppVeyor\CommandBus\Handler;
4
5		use ApiClients\Client\AppVeyor\CommandBus\Command\AddProjectCommand;
6		use ApiClients\Client\AppVeyor\Resource\ProjectInterface;
7		use ApiClients\Foundation\Hydrator\Hydrator;
8		use ApiClients\Foundation\Transport\Service\RequestService;
9		use ApiClients\Middleware\Json\JsonStream;
10		use Psr\Http\Message\ResponseInterface;
11		use React\Promise\PromiseInterface;
12		use RingCentral\Psr7\Request;
13
14		final class AddProjectHandler
15		{
16		/**
17		* @var RequestService
18		*/
19		private $requestService;
20
21		/**
22		* @var Hydrator
23		*/
24		private $hydrator;
25
26		/**
27		* @param RequestService $requestService
28		* @param Hydrator $hydrator
29		*/
30	1	public function __construct(RequestService $requestService, Hydrator $hydrator)
31		{
32	1	$this->requestService = $requestService;
33	1	$this->hydrator = $hydrator;
34	1	}
35
36		/**
37		* @param AddProjectCommand $command
38		* @return PromiseInterface
39		*/
40	1	public function handle(AddProjectCommand $command): PromiseInterface
41		{
42	1	return $this->requestService->request(
43	1	new Request(
44	1	'POST',
45	1	'projects',
46	1	[],
47	1	new JsonStream([
48	1	'repositoryProvider' => $command->getProvider(),
49	1	'repositoryName' => $command->getRepository(),
50		])
51		)
52	1	)->then(function (ResponseInterface $response) {
53	1	return $this->hydrator->hydrate(
54	1	ProjectInterface::HYDRATE_CLASS,
55	1	$response->getBody()->getParsedContents()
		0 ignored issues – show Bug introduced 2017-12-23 19:08 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Http\Message\StreamInterface` as the method `getParsedContents()` does only exist in the following implementations of said interface: `ApiClients\Middleware\Json\JsonStream`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
56		);
57	1	});
58		}
59		}
60

php-api-clients / appveyor

GitHub Access Token became invalid

AddProjectHandler::handle() A last analyzed 2019-01-22 01:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

AddProjectHandler::handle() A
last analyzed 2019-01-22 01:16 UTC