Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
8 | View Code Duplication | abstract class EmptyProject implements ProjectInterface, EmptyResourceInterface |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * @return int |
||
12 | */ |
||
13 | 2 | public function projectId(): int |
|
17 | |||
18 | /** |
||
19 | * @return int |
||
20 | */ |
||
21 | 2 | public function accountId(): int |
|
25 | |||
26 | /** |
||
27 | * @return string |
||
28 | */ |
||
29 | 2 | public function accountName(): string |
|
33 | |||
34 | /** |
||
35 | * @return array |
||
36 | */ |
||
37 | 2 | public function builds(): array |
|
41 | |||
42 | /** |
||
43 | * @return string |
||
44 | */ |
||
45 | 2 | public function name(): string |
|
49 | |||
50 | /** |
||
51 | * @return string |
||
52 | */ |
||
53 | 2 | public function slug(): string |
|
57 | |||
58 | /** |
||
59 | * @return string |
||
60 | */ |
||
61 | 2 | public function repositoryType(): string |
|
65 | |||
66 | /** |
||
67 | * @return string |
||
68 | */ |
||
69 | 2 | public function repositoryScm(): string |
|
73 | |||
74 | /** |
||
75 | * @return string |
||
76 | */ |
||
77 | 2 | public function repositoryName(): string |
|
81 | |||
82 | /** |
||
83 | * @return string |
||
84 | */ |
||
85 | 2 | public function repositoryBranch(): string |
|
89 | |||
90 | /** |
||
91 | * @return bool |
||
92 | */ |
||
93 | 2 | public function isPrivate(): bool |
|
97 | |||
98 | /** |
||
99 | * @return bool |
||
100 | */ |
||
101 | 2 | public function skipBranchesWithoutAppveyorYml(): bool |
|
105 | |||
106 | /** |
||
107 | * @return bool |
||
108 | */ |
||
109 | 2 | public function enableSecureVariablesInPullRequests(): bool |
|
113 | |||
114 | /** |
||
115 | * @return bool |
||
116 | */ |
||
117 | 2 | public function enableDeploymentInPullRequests(): bool |
|
121 | |||
122 | /** |
||
123 | * @return bool |
||
124 | */ |
||
125 | 2 | public function rollingBuilds(): bool |
|
129 | |||
130 | /** |
||
131 | * @return bool |
||
132 | */ |
||
133 | 2 | public function alwaysBuildClosedPullRequests(): bool |
|
137 | |||
138 | /** |
||
139 | * @return array |
||
140 | */ |
||
141 | 2 | public function nuGetFeed(): array |
|
145 | |||
146 | /** |
||
147 | * @return array |
||
148 | */ |
||
149 | 2 | public function securityDescriptor(): array |
|
153 | |||
154 | /** |
||
155 | * @return DateTimeInterface |
||
156 | */ |
||
157 | 2 | public function created(): DateTimeInterface |
|
161 | |||
162 | /** |
||
163 | * @return DateTimeInterface |
||
164 | */ |
||
165 | 2 | public function updated(): DateTimeInterface |
|
169 | } |
||
170 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.