Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
8 | View Code Duplication | abstract class EmptyBuild implements BuildInterface, EmptyResourceInterface |
|
|
|||
9 | { |
||
10 | /** |
||
11 | * @return int |
||
12 | */ |
||
13 | 2 | public function buildId(): int |
|
17 | |||
18 | /** |
||
19 | * @return array |
||
20 | */ |
||
21 | 2 | public function jobs(): array |
|
25 | |||
26 | /** |
||
27 | * @return int |
||
28 | */ |
||
29 | 2 | public function buildNumber(): int |
|
33 | |||
34 | /** |
||
35 | * @return string |
||
36 | */ |
||
37 | 2 | public function version(): string |
|
41 | |||
42 | /** |
||
43 | * @return string |
||
44 | */ |
||
45 | 2 | public function message(): string |
|
49 | |||
50 | /** |
||
51 | * @return string |
||
52 | */ |
||
53 | 2 | public function branch(): string |
|
57 | |||
58 | /** |
||
59 | * @return string |
||
60 | */ |
||
61 | 2 | public function commitId(): string |
|
65 | |||
66 | /** |
||
67 | * @return string |
||
68 | */ |
||
69 | 2 | public function authorName(): string |
|
73 | |||
74 | /** |
||
75 | * @return string |
||
76 | */ |
||
77 | 2 | public function authorUserName(): string |
|
81 | |||
82 | /** |
||
83 | * @return string |
||
84 | */ |
||
85 | 2 | public function comitterName(): string |
|
89 | |||
90 | /** |
||
91 | * @return string |
||
92 | */ |
||
93 | 2 | public function comitterUserName(): string |
|
97 | |||
98 | /** |
||
99 | * @return DateTimeInterface |
||
100 | */ |
||
101 | 2 | public function comitted(): DateTimeInterface |
|
105 | |||
106 | /** |
||
107 | * @return array |
||
108 | */ |
||
109 | 2 | public function messages(): array |
|
113 | |||
114 | /** |
||
115 | * @return string |
||
116 | */ |
||
117 | 2 | public function status(): string |
|
121 | |||
122 | /** |
||
123 | * @return DateTimeInterface |
||
124 | */ |
||
125 | 2 | public function started(): DateTimeInterface |
|
129 | |||
130 | /** |
||
131 | * @return DateTimeInterface |
||
132 | */ |
||
133 | 2 | public function finished(): DateTimeInterface |
|
137 | |||
138 | /** |
||
139 | * @return DateTimeInterface |
||
140 | */ |
||
141 | 2 | public function created(): DateTimeInterface |
|
145 | |||
146 | /** |
||
147 | * @return DateTimeInterface |
||
148 | */ |
||
149 | 2 | public function updated(): DateTimeInterface |
|
153 | } |
||
154 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.