php-ai / php-ml

src/Metric/ConfusionMatrix.php

<?php

declare(strict_types=1);

namespace Phpml\Metric;

class ConfusionMatrix
{
    public static function compute(array $actualLabels, array $predictedLabels, array $labels = []): array
    {
        $labels = count($labels) === 0 ? self::getUniqueLabels($actualLabels) : array_flip($labels);
        $matrix = self::generateMatrixWithZeros($labels);

It seems like $labels can also be of type null; however, parameter $labels of Phpml\Metric\ConfusionMatrix::generateMatrixWithZeros() does only seem to accept array, maybe add an additional type check?

        foreach ($actualLabels as $index => $actual) {
            $predicted = $predictedLabels[$index];

            if (!isset($labels[$actual], $labels[$predicted])) {
                continue;
            }

            if ($predicted === $actual) {
                $row = $column = $labels[$actual];
            } else {
                $row = $labels[$actual];
                $column = $labels[$predicted];
            }

            ++$matrix[$row][$column];
        }

        return $matrix;
    }

    private static function generateMatrixWithZeros(array $labels): array
    {
        $count = count($labels);
        $matrix = [];

        for ($i = 0; $i < $count; ++$i) {
            $matrix[$i] = array_fill(0, $count, 0);
        }

        return $matrix;
    }

    private static function getUniqueLabels(array $labels): array
    {
        $labels = array_values(array_unique($labels));
        sort($labels);

        return array_flip($labels);

The expression return array_flip($labels) could return the type null which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }
}