Phpml\NeuralNetwork\Node\Neuron

Complexity

Total Complexity

8

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	addSynapse()	0	4	1
A	getSynapses()	0	4	1
A	getOutput()	0	13	3
A	refresh()	0	4	1

<?php

declare (strict_types = 1);

namespace Phpml\NeuralNetwork\Node;

use Phpml\NeuralNetwork\ActivationFunction;
use Phpml\NeuralNetwork\Node;

class Neuron implements Node
{
    /**
     * @var Synapse[]
     */
    protected $synapses;

    /**
     * @var ActivationFunction
     */
    protected $activationFunction;

    /**
     * @var float
     */
    protected $output;

    /**
     * @param ActivationFunction|null $activationFunction
     */
    public function __construct(ActivationFunction $activationFunction = null)
    {
        $this->activationFunction = $activationFunction ?: new ActivationFunction\Sigmoid();
        $this->synapses = [];
        $this->output = 0;

The property $output was declared of type double, but 0 is of type integer. Maybe add a type cast?

    }

    /**
     * @param Synapse $synapse
     */
    public function addSynapse(Synapse $synapse)
    {
        $this->synapses[] = $synapse;
    }

    /**
     * @return Synapse[]
     */
    public function getSynapses()
    {
        return $this->synapses;
    }

    /**
     * @return float
     */
    public function getOutput(): float
    {
        if (0 === $this->output) {
            $sum = 0;
            foreach ($this->synapses as $synapse) {
                $sum += $synapse->getOutput();
            }

            $this->output = $this->activationFunction->compute($sum);
        }

        return $this->output;
    }

    public function refresh()
    {
        $this->output = 0;

The property $output was declared of type double, but 0 is of type integer. Maybe add a type cast?

    }
}