php-ai / php-ml

src/Phpml/Classification/Ensemble/Bagging.php

Unused Use Statements -2 removed lines

@@ -6,10 +6,8 @@
 
 use Phpml\Helper\Predictable;
 use Phpml\Helper\Trainable;
-use Phpml\Math\Statistic\Mean;
 use Phpml\Classification\Classifier;
 use Phpml\Classification\DecisionTree;
-use Phpml\Classification\NaiveBayes;
 
 class Bagging implements Classifier
 {

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification\Ensemble;
 
@@ -140,7 +140,7 @@ 
         $targets = [];
         srand($index);
         $bootstrapSize = $this->subsetRatio * $this->numSamples;
-        for ($i=0; $i < $bootstrapSize; $i++) {
+        for ($i = 0; $i < $bootstrapSize; $i++) {
             $rand = rand(0, $this->numSamples - 1);
             $samples[] = $this->samples[$rand];
             $targets[] = $this->targets[$rand];
@@ -154,7 +154,7 @@ 
     protected function initClassifiers()
     {
         $classifiers = [];
-        for ($i=0; $i<$this->numClassifier; $i++) {
+        for ($i = 0; $i < $this->numClassifier; $i++) {
             $ref = new \ReflectionClass($this->classifier);
             if ($this->classifierOptions) {
                 $obj = $ref->newInstanceArgs($this->classifierOptions);

src/Phpml/Classification/Ensemble/RandomForest.php

Spacing +4 added lines, -4 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification\Ensemble;
 
@@ -70,11 +70,11 @@ 
     protected function initSingleClassifier($classifier, $index)
     {
         if (is_float($this->featureSubsetRatio)) {
-            $featureCount = (int)($this->featureSubsetRatio * $this->featureCount);
+            $featureCount = (int) ($this->featureSubsetRatio * $this->featureCount);
         } elseif ($this->featureCount == 'sqrt') {
-            $featureCount = (int)sqrt($this->featureCount) + 1;
+            $featureCount = (int) sqrt($this->featureCount) + 1;
         } else {
-            $featureCount = (int)log($this->featureCount, 2) + 1;
+            $featureCount = (int) log($this->featureCount, 2) + 1;
         }
 
         if ($featureCount >= $this->featureCount) {

src/Phpml/Classification/Linear/Adaline.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      * If normalizeInputs is set to true, then every input given to the algorithm will be standardized
      * by use of standard deviation and mean calculation
      *
-     * @param int $learningRate
+     * @param double $learningRate
      * @param int $maxIterations
      */
     public function __construct(float $learningRate = 0.001, int $maxIterations = 1000,

Unused Use Statements -3 removed lines

@@ -4,9 +4,6 @@
 
 namespace Phpml\Classification\Linear;
 
-use Phpml\Helper\Predictable;
-use Phpml\Helper\Trainable;
-use Phpml\Classification\Classifier;
 use Phpml\Classification\Linear\Perceptron;
 
 class Adaline extends Perceptron

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification\Linear;
 
@@ -15,12 +15,12 @@ 
     /**
      * Batch training is the default Adaline training algorithm
      */
-    const BATCH_TRAINING    = 1;
+    const BATCH_TRAINING = 1;
 
     /**
      * Online training: Stochastic gradient descent learning
      */
-    const ONLINE_TRAINING    = 2;
+    const ONLINE_TRAINING = 2;
 
     /**
      * The function whose result will be used to calculate the network error
@@ -52,7 +52,7 @@ 
     public function __construct(float $learningRate = 0.001, int $maxIterations = 1000,
         bool $normalizeInputs = true, int $trainingType = self::BATCH_TRAINING)
     {
-        if (! in_array($trainingType, [self::BATCH_TRAINING, self::ONLINE_TRAINING])) {
+        if (!in_array($trainingType, [self::BATCH_TRAINING, self::ONLINE_TRAINING])) {
             throw new \Exception("Adaline can only be trained with batch and online/stochastic gradient descent algorithm");
         }
 
@@ -104,7 +104,7 @@ 
     protected function updateWeights(array $updates)
     {
         // Updates all weights at once
-        for ($i=0; $i <= $this->featureCount; $i++) {
+        for ($i = 0; $i <= $this->featureCount; $i++) {
             if ($i == 0) {
                 $this->weights[0] += $this->learningRate * array_sum($updates);
             } else {

src/Phpml/Preprocessing/Normalizer.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Preprocessing;
 
@@ -12,7 +12,7 @@ 
 {
     const NORM_L1 = 1;
     const NORM_L2 = 2;
-    const NORM_STD= 3;
+    const NORM_STD = 3;
 
     /**
      * @var int
@@ -117,7 +117,7 @@ 
         foreach ($sample as $feature) {
             $norm2 += $feature * $feature;
         }
-        $norm2 = sqrt((float)$norm2);
+        $norm2 = sqrt((float) $norm2);
 
         if (0 == $norm2) {
             $sample = array_fill(0, count($sample), 1);

src/Phpml/Classification/Linear/Perceptron.php

Indentation +2 added lines, -2 removed lines

@@ -20,7 +20,7 @@ 
      */
     protected static $errorFunction = 'outputClass';
 
-   /**
+    /**
      * @var array
      */
     protected $samples = [];
@@ -78,7 +78,7 @@ 
         $this->maxIterations = $maxIterations;
     }
 
-   /**
+    /**
      * @param array $samples
      * @param array $targets
      */

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification\Linear;
 
@@ -138,7 +138,7 @@ 
                 // Update bias
                 $this->weights[0] += $update * $this->learningRate; // Bias
                 // Update other weights
-                for ($i=1; $i <= $this->featureCount; $i++) {
+                for ($i = 1; $i <= $this->featureCount; $i++) {
                     $this->weights[$i] += $update * $sample[$i - 1] * $this->learningRate;
                 }
             }
@@ -190,6 +190,6 @@ 
 
         $predictedClass = $this->outputClass($sample);
 
-        return $this->labels[ $predictedClass ];
+        return $this->labels[$predictedClass];
     }
 }

src/Phpml/Classification/DecisionTree.php

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification;
 
@@ -112,7 +112,7 @@ 
     protected function getColumnTypes(array $samples)
     {
         $types = [];
-        for ($i=0; $i<$this->featureCount; $i++) {
+        for ($i = 0; $i < $this->featureCount; $i++) {
             $values = array_column($samples, $i);
             $isCategorical = $this->isCategoricalColumn($values);
             $types[] = $isCategorical ? self::NOMINAL : self::CONTINUOS;
@@ -136,7 +136,7 @@ 
         // otherwise group the records so that we can classify the leaf
         // in case maximum depth is reached
         $leftRecords = [];
-        $rightRecords= [];
+        $rightRecords = [];
         $remainingTargets = [];
         $prevRecord = null;
         $allSame = true;
@@ -154,12 +154,12 @@ 
             if ($split->evaluate($record)) {
                 $leftRecords[] = $recordNo;
             } else {
-                $rightRecords[]= $recordNo;
+                $rightRecords[] = $recordNo;
             }
 
             // Group remaining targets
             $target = $this->targets[$recordNo];
-            if (! array_key_exists($target, $remainingTargets)) {
+            if (!array_key_exists($target, $remainingTargets)) {
                 $remainingTargets[$target] = 1;
             } else {
                 $remainingTargets[$target]++;
@@ -175,7 +175,7 @@ 
                 $split->leftLeaf = $this->getSplitLeaf($leftRecords, $depth + 1);
             }
             if ($rightRecords) {
-                $split->rightLeaf= $this->getSplitLeaf($rightRecords, $depth + 1);
+                $split->rightLeaf = $this->getSplitLeaf($rightRecords, $depth + 1);
             }
         }
         return $split;
@@ -234,7 +234,7 @@ 
     protected function getSelectedFeatures()
     {
         $allFeatures = range(0, $this->featureCount - 1);
-        if ($this->numUsableFeatures == 0 && ! $this->selectedFeatures) {
+        if ($this->numUsableFeatures == 0 && !$this->selectedFeatures) {
             return $allFeatures;
         }
 
@@ -270,7 +270,7 @@ 
             $countMatrix[$label][$rowIndex]++;
         }
         $giniParts = [0, 0];
-        for ($i=0; $i<=1; $i++) {
+        for ($i = 0; $i <= 1; $i++) {
             $part = 0;
             $sum = array_sum(array_column($countMatrix, $i));
             if ($sum > 0) {
@@ -292,7 +292,7 @@ 
         // Detect and convert continuous data column values into
         // discrete values by using the median as a threshold value
         $columns = [];
-        for ($i=0; $i<$this->featureCount; $i++) {
+        for ($i = 0; $i < $this->featureCount; $i++) {
             $values = array_column($samples, $i);
             if ($this->columnTypes[$i] == self::CONTINUOS) {
                 $median = Mean::median($values);

Doc Comments +2 added lines, -4 removed lines

@@ -184,7 +184,7 @@ 
 
     /**
      * @param array $records
-     * @return DecisionTreeLeaf[]
+     * @return null|DecisionTreeLeaf
      */
     protected function getBestSplit($records)
     {
@@ -377,7 +377,7 @@ 
     /**
      * Used to set predefined features to consider while deciding which column to use for a split
      *
-     * @param array $selectedFeatures
+     * @param integer[] $selectedFeatures
      */
     protected function setSelectedFeatures(array $selectedFeatures)
     {
@@ -415,7 +415,6 @@ 
      * each column in the given dataset. The importance values are
      * normalized and their total makes 1.<br/>
      *
-     * @param array $labels
      * @return array
      */
     public function getFeatureImportances()
@@ -455,7 +454,6 @@ 
      *
      * @param int $column
      * @param DecisionTreeLeaf
-     * @param array $collected
      *
      * @return array
      */

src/Phpml/Classification/Linear/DecisionStump.php

Doc Comments +2 added lines, -2 removed lines

@@ -158,8 +158,8 @@
      * @param string $operator
      * @param array $values
      * @param array $targets
-     * @param mixed $leftLabel
-     * @param mixed $rightLabel
+     * @param string $leftLabel
+     * @param string $rightLabel
      */
     protected function calculateErrorRate(float $threshold, string $operator, array $values, array $targets, $leftLabel, $rightLabel)
     {

Unused Use Statements -2 removed lines

@@ -6,9 +6,7 @@
 
 use Phpml\Helper\Predictable;
 use Phpml\Helper\Trainable;
-use Phpml\Classification\Classifier;
 use Phpml\Classification\DecisionTree;
-use Phpml\Classification\DecisionTree\DecisionTreeLeaf;
 
 class DecisionStump extends DecisionTree
 {

Spacing +4 added lines, -4 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification\Linear;
 
@@ -122,7 +122,7 @@ 
         $stepSize = ($maxValue - $minValue) / 100.0;
 
         $leftLabel = $this->tree->leftLeaf->classValue;
-        $rightLabel= $this->tree->rightLeaf->classValue;
+        $rightLabel = $this->tree->rightLeaf->classValue;
 
         $bestOperator = $this->tree->operator;
         $bestThreshold = $this->tree->numericValue;
@@ -130,8 +130,8 @@ 
                 $bestThreshold, $bestOperator, $values, $targets, $leftLabel, $rightLabel);
 
         foreach (['<=', '>'] as $operator) {
-            for ($step = $minValue; $step <= $maxValue; $step+= $stepSize) {
-                $threshold = (float)$step;
+            for ($step = $minValue; $step <= $maxValue; $step += $stepSize) {
+                $threshold = (float) $step;
                 $errorRate = $this->calculateErrorRate(
                     $threshold, $operator, $values, $targets, $leftLabel, $rightLabel);
 

src/Phpml/Classification/Ensemble/AdaBoost.php

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification\Ensemble;
 
@@ -122,7 +122,7 @@ 
         //  classifiers as well
         $minErrorRate = 1.0;
         $bestClassifier = null;
-        for ($i=0; $i < $this->featureCount; $i++) {
+        for ($i = 0; $i < $this->featureCount; $i++) {
             $stump = new DecisionStump($i);
             $stump->setSampleWeights($this->weights);
             $stump->train($this->samples, $this->targets);
@@ -185,6 +185,6 @@ 
             $sum += $h * $alpha;
         }
 
-        return $this->labels[ $sum > 0 ? 1 : -1];
+        return $this->labels[$sum > 0 ? 1 : -1];
     }
 }

src/Phpml/Classification/DecisionTree/DecisionTreeLeaf.php

Spacing +14 added lines, -14 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Phpml\Classification\DecisionTree;
 
@@ -34,7 +34,7 @@ 
     /**
      * @var DecisionTreeLeaf
      */
-    public $rightLeaf= null;
+    public $rightLeaf = null;
 
     /**
      * @var array
@@ -79,7 +79,7 @@ 
 
         if ($this->isContinuous) {
             $op = $this->operator;
-            $value= $this->numericValue;
+            $value = $this->numericValue;
             $recordField = strval($recordField);
             eval("\$result = $recordField $op $value;");
             return $result;
@@ -100,16 +100,16 @@ 
             return 0.0;
         }
 
-        $nodeSampleCount = (float)count($this->records);
+        $nodeSampleCount = (float) count($this->records);
         $iT = $this->giniIndex;
 
         if ($this->leftLeaf) {
-            $pL = count($this->leftLeaf->records)/$nodeSampleCount;
+            $pL = count($this->leftLeaf->records) / $nodeSampleCount;
             $iT -= $pL * $this->leftLeaf->giniIndex;
         }
 
         if ($this->rightLeaf) {
-            $pR = count($this->rightLeaf->records)/$nodeSampleCount;
+            $pR = count($this->rightLeaf->records) / $nodeSampleCount;
             $iT -= $pR * $this->rightLeaf->giniIndex;
         }
 
@@ -133,25 +133,25 @@ 
             } else {
                 $col = "col_$this->columnIndex";
             }
-            if (! preg_match("/^[<>=]{1,2}/", $value)) {
+            if (!preg_match("/^[<>=]{1,2}/", $value)) {
                 $value = "=$value";
             }
-            $value = "<b>$col $value</b><br>Gini: ". number_format($this->giniIndex, 2);
+            $value = "<b>$col $value</b><br>Gini: ".number_format($this->giniIndex, 2);
         }
         $str = "<table ><tr><td colspan=3 align=center style='border:1px solid;'>
 				$value</td></tr>";
         if ($this->leftLeaf || $this->rightLeaf) {
-            $str .='<tr>';
+            $str .= '<tr>';
             if ($this->leftLeaf) {
-                $str .="<td valign=top><b>| Yes</b><br>" . $this->leftLeaf->getHTML($columnNames) . "</td>";
+                $str .= "<td valign=top><b>| Yes</b><br>".$this->leftLeaf->getHTML($columnNames)."</td>";
             } else {
-                $str .='<td></td>';
+                $str .= '<td></td>';
             }
-            $str .='<td>&nbsp;</td>';
+            $str .= '<td>&nbsp;</td>';
             if ($this->rightLeaf) {
-                $str .="<td valign=top align=right><b>No |</b><br>" . $this->rightLeaf->getHTML($columnNames) . "</td>";
+                $str .= "<td valign=top align=right><b>No |</b><br>".$this->rightLeaf->getHTML($columnNames)."</td>";
             } else {
-                $str .='<td></td>';
+                $str .= '<td></td>';
             }
             $str .= '</tr>';
         }