DecisionTree - Code Metrics - Inspection of "Ensemble Classifiers : Bagging and RandomForest (#..." - php-ai/php-ml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 72b25f...1d7350 )

by Arkadiusz

created 2017-02-07 11:38 UTC

DecisionTree B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	315
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	48
lcom	1
cbo	4
dl	0
loc	315
rs	8.4864
c	0
b	0
f	0

12 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	train()	10	1
A	getColumnTypes()	10	3
C	getSplitLeaf()	44	12
B	getBestSplit()	29	5
A	getSelectedFeatures()	17	3
C	getGiniIndex()	24	7
B	preprocess()	23	5
A	isCategoricalColumn()	18	3
A	setNumFeatures()	9	2
A	getHtml()	4	1
B	predictSample()	16	5

How to fix Complexity

<?php

declare(strict_types=1);

namespace Phpml\Classification;

use Phpml\Helper\Predictable;
use Phpml\Helper\Trainable;
use Phpml\Math\Statistic\Mean;
use Phpml\Classification\DecisionTree\DecisionTreeLeaf;

class DecisionTree implements Classifier
{
    use Trainable, Predictable;

    const CONTINUOS = 1;
    const NOMINAL = 2;

    /**
     * @var array
     */
    private $samples = [];

    /**
     * @var array
     */
    private $columnTypes;

    /**
     * @var array
     */
    private $labels = [];

    /**
     * @var int
     */
    private $featureCount = 0;

    /**
     * @var DecisionTreeLeaf
     */
    private $tree = null;

    /**
     * @var int
     */
    private $maxDepth;

    /**
     * @var int
     */
    public $actualDepth = 0;

    /**
     * @var int
     */
    private $numUsableFeatures = 0;

    /**
     * @param int $maxDepth
     */
    public function __construct($maxDepth = 10)
    {
        $this->maxDepth = $maxDepth;
    }
    /**
     * @param array $samples
     * @param array $targets
     */
    public function train(array $samples, array $targets)
    {
        $this->samples = array_merge($this->samples, $samples);
        $this->targets = array_merge($this->targets, $targets);

        $this->featureCount = count($this->samples[0]);
        $this->columnTypes = $this->getColumnTypes($this->samples);
        $this->labels = array_keys(array_count_values($this->targets));
        $this->tree = $this->getSplitLeaf(range(0, count($this->samples) - 1));
    }

    protected function getColumnTypes(array $samples)
    {
        $types = [];
        for ($i=0; $i<$this->featureCount; $i++) {
            $values = array_column($samples, $i);
            $isCategorical = $this->isCategoricalColumn($values);
            $types[] = $isCategorical ? self::NOMINAL : self::CONTINUOS;
        }
        return $types;
    }

    /**
     * @param null|array $records
     * @return DecisionTreeLeaf
     */
    protected function getSplitLeaf($records, $depth = 0)
    {
        $split = $this->getBestSplit($records);

        $split->level = $depth;
        if ($this->actualDepth < $depth) {
            $this->actualDepth = $depth;
        }
        $leftRecords = [];
        $rightRecords= [];
        $remainingTargets = [];
        $prevRecord = null;
        $allSame = true;
        foreach ($records as $recordNo) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $record = $this->samples[$recordNo];
            if ($prevRecord && $prevRecord != $record) {
                $allSame = false;
            }
            $prevRecord = $record;
            if ($split->evaluate($record)) {
                $leftRecords[] = $recordNo;
            } else {
                $rightRecords[]= $recordNo;
            }
            $target = $this->targets[$recordNo];
            if (! in_array($target, $remainingTargets)) {
                $remainingTargets[] = $target;
            }
        }

        if (count($remainingTargets) == 1 || $allSame || $depth >= $this->maxDepth) {
            $split->isTerminal = 1;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $classes = array_count_values($remainingTargets);
            arsort($classes);
            $split->classValue = key($classes);
        } else {
            if ($leftRecords) {

                $split->leftLeaf = $this->getSplitLeaf($leftRecords, $depth + 1);
            }
            if ($rightRecords) {

                $split->rightLeaf= $this->getSplitLeaf($rightRecords, $depth + 1);
            }
        }
        return $split;
    }

    /**
     * @param array $records
     * @return DecisionTreeLeaf[]
     */
    protected function getBestSplit($records)
    {
        $targets = array_intersect_key($this->targets, array_flip($records));
        $samples = array_intersect_key($this->samples, array_flip($records));
        $samples = array_combine($records, $this->preprocess($samples));
        $bestGiniVal = 1;
        $bestSplit = null;
        $features = $this->getSelectedFeatures();
        foreach ($features as $i) {
            $colValues = [];
            foreach ($samples as $index => $row) {
                $colValues[$index] = $row[$i];
            }
            $counts = array_count_values($colValues);
            arsort($counts);
            $baseValue = key($counts);
            $gini = $this->getGiniIndex($baseValue, $colValues, $targets);
            if ($bestSplit == null || $bestGiniVal > $gini) {
                $split = new DecisionTreeLeaf();
                $split->value = $baseValue;
                $split->giniIndex = $gini;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                $split->columnIndex = $i;
                $split->records = $records;
                $bestSplit = $split;
                $bestGiniVal = $gini;
            }
        }
        return $bestSplit;
    }

    /**
     * @return array
     */
    protected function getSelectedFeatures()
    {
        $allFeatures = range(0, $this->featureCount - 1);
        if ($this->numUsableFeatures == 0) {
            return $allFeatures;
        }

        $numFeatures = $this->numUsableFeatures;
        if ($numFeatures > $this->featureCount) {
            $numFeatures = $this->featureCount;
        }
        shuffle($allFeatures);
        $selectedFeatures = array_slice($allFeatures, 0, $numFeatures, false);
        sort($selectedFeatures);

        return $selectedFeatures;
    }

    /**
     * @param string $baseValue
     * @param array $colValues
     * @param array $targets
     */
    public function getGiniIndex($baseValue, $colValues, $targets)
    {
        $countMatrix = [];
        foreach ($this->labels as $label) {
            $countMatrix[$label] = [0, 0];
        }
        foreach ($colValues as $index => $value) {
            $label = $targets[$index];
            $rowIndex = $value == $baseValue ? 0 : 1;
            $countMatrix[$label][$rowIndex]++;
        }
        $giniParts = [0, 0];
        for ($i=0; $i<=1; $i++) {
            $part = 0;
            $sum = array_sum(array_column($countMatrix, $i));
            if ($sum > 0) {
                foreach ($this->labels as $label) {
                    $part += pow($countMatrix[$label][$i] / floatval($sum), 2);
                }
            }
            $giniParts[$i] = (1 - $part) * $sum;
        }
        return array_sum($giniParts) / count($colValues);
    }

    /**
     * @param array $samples
     * @return array
     */
    protected function preprocess(array $samples)
    {
        // Detect and convert continuous data column values into
        // discrete values by using the median as a threshold value
        $columns = [];
        for ($i=0; $i<$this->featureCount; $i++) {
            $values = array_column($samples, $i);
            if ($this->columnTypes[$i] == self::CONTINUOS) {
                $median = Mean::median($values);
                foreach ($values as &$value) {
                    if ($value <= $median) {
                        $value = "<= $median";
                    } else {
                        $value = "> $median";
                    }
                }
            }
            $columns[] = $values;
        }
        // Below method is a strange yet very simple & efficient method
        // to get the transpose of a 2D array
        return array_map(null, ...$columns);
    }

    /**
     * @param array $columnValues
     * @return bool
     */
    protected function isCategoricalColumn(array $columnValues)
    {
        $count = count($columnValues);
        // There are two main indicators that *may* show whether a
        // column is composed of discrete set of values:
        // 1- Column may contain string values
        // 2- Number of unique values in the column is only a small fraction of
        //	  all values in that column (Lower than or equal to %20 of all values)
        $numericValues = array_filter($columnValues, 'is_numeric');
        if (count($numericValues) != $count) {
            return true;
        }
        $distinctValues = array_count_values($columnValues);
        if (count($distinctValues) <= $count / 5) {
            return true;
        }
        return false;
    }

    /**
     * This method is used to set number of columns to be used
     * when deciding a split at an internal node of the tree.  <br>
     * If the value is given 0, then all features are used (default behaviour),
     * otherwise the given value will be used as a maximum for number of columns
     * randomly selected for each split operation.
     *
     * @param int $numFeatures
     * @return $this
     * @throws Exception
     */
    public function setNumFeatures(int $numFeatures)
    {
        if ($numFeatures < 0) {
            throw new \Exception("Selected column count should be greater or equal to zero");
        }

        $this->numUsableFeatures = $numFeatures;
        return $this;
    }

    /**
     * @return string
     */
    public function getHtml()
    {
        return $this->tree->__toString();
    }

    /**
     * @param array $sample
     * @return mixed
     */
    protected function predictSample(array $sample)
    {
        $node = $this->tree;
        do {
            if ($node->isTerminal) {
                break;
            }
            if ($node->evaluate($sample)) {
                $node = $node->leftLeaf;
            } else {
                $node = $node->rightLeaf;
            }
        } while ($node);

        return $node ? $node->classValue : $this->labels[0];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Phpml\Classification;
6
7			use Phpml\Helper\Predictable;
8			use Phpml\Helper\Trainable;
9			use Phpml\Math\Statistic\Mean;
10			use Phpml\Classification\DecisionTree\DecisionTreeLeaf;
11
12			class DecisionTree implements Classifier
13			{
14			use Trainable, Predictable;
15
16			const CONTINUOS = 1;
17			const NOMINAL = 2;
18
19			/**
20			* @var array
21			*/
22			private $samples = [];
23
24			/**
25			* @var array
26			*/
27			private $columnTypes;
28
29			/**
30			* @var array
31			*/
32			private $labels = [];
33
34			/**
35			* @var int
36			*/
37			private $featureCount = 0;
38
39			/**
40			* @var DecisionTreeLeaf
41			*/
42			private $tree = null;
43
44			/**
45			* @var int
46			*/
47			private $maxDepth;
48
49			/**
50			* @var int
51			*/
52			public $actualDepth = 0;
53
54			/**
55			* @var int
56			*/
57			private $numUsableFeatures = 0;
58
59			/**
60			* @param int $maxDepth
61			*/
62			public function __construct($maxDepth = 10)
63			{
64			$this->maxDepth = $maxDepth;
65			}
66			/**
67			* @param array $samples
68			* @param array $targets
69			*/
70			public function train(array $samples, array $targets)
71			{
72			$this->samples = array_merge($this->samples, $samples);
73			$this->targets = array_merge($this->targets, $targets);
74
75			$this->featureCount = count($this->samples[0]);
76			$this->columnTypes = $this->getColumnTypes($this->samples);
77			$this->labels = array_keys(array_count_values($this->targets));
78			$this->tree = $this->getSplitLeaf(range(0, count($this->samples) - 1));
79			}
80
81			protected function getColumnTypes(array $samples)
82			{
83			$types = [];
84			for ($i=0; $i<$this->featureCount; $i++) {
85			$values = array_column($samples, $i);
86			$isCategorical = $this->isCategoricalColumn($values);
87			$types[] = $isCategorical ? self::NOMINAL : self::CONTINUOS;
88			}
89			return $types;
90			}
91
92			/**
93			* @param null\|array $records
94			* @return DecisionTreeLeaf
95			*/
96			protected function getSplitLeaf($records, $depth = 0)
97			{
98			$split = $this->getBestSplit($records);
			0 ignored issues – show Bug introduced 2017-01-29 10:19 UTC by Report Bug Copy Issue Report It seems like `$records` defined by parameter `$records` on line 96 can also be of type `null`; however, `Phpml\Classification\DecisionTree::getBestSplit()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
99			$split->level = $depth;
100			if ($this->actualDepth < $depth) {
101			$this->actualDepth = $depth;
102			}
103			$leftRecords = [];
104			$rightRecords= [];
105			$remainingTargets = [];
106			$prevRecord = null;
107			$allSame = true;
108			foreach ($records as $recordNo) {
			0 ignored issues – show Bug introduced 2017-01-29 10:19 UTC by Report Bug Copy Issue Report The expression `$records` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
109			$record = $this->samples[$recordNo];
110			if ($prevRecord && $prevRecord != $record) {
111			$allSame = false;
112			}
113			$prevRecord = $record;
114			if ($split->evaluate($record)) {
115			$leftRecords[] = $recordNo;
116			} else {
117			$rightRecords[]= $recordNo;
118			}
119			$target = $this->targets[$recordNo];
120			if (! in_array($target, $remainingTargets)) {
121			$remainingTargets[] = $target;
122			}
123			}
124
125			if (count($remainingTargets) == 1 \|\| $allSame \|\| $depth >= $this->maxDepth) {
126			$split->isTerminal = 1;
			0 ignored issues – show Documentation Bug introduced 2017-01-29 10:19 UTC by Report Bug Copy Issue Report The property `$isTerminal` was declared of type `boolean`, but `1` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
127			$classes = array_count_values($remainingTargets);
128			arsort($classes);
129			$split->classValue = key($classes);
130			} else {
131			if ($leftRecords) {
			0 ignored issues – show Bug Best Practice introduced 2017-01-29 10:19 UTC by Report Bug Copy Issue Report The expression `$leftRecords` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
132			$split->leftLeaf = $this->getSplitLeaf($leftRecords, $depth + 1);
133			}
134			if ($rightRecords) {
			0 ignored issues – show Bug Best Practice introduced 2017-01-29 10:19 UTC by Report Bug Copy Issue Report The expression `$rightRecords` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
135			$split->rightLeaf= $this->getSplitLeaf($rightRecords, $depth + 1);
136			}
137			}
138			return $split;
139			}
140
141			/**
142			* @param array $records
143			* @return DecisionTreeLeaf[]
144			*/
145			protected function getBestSplit($records)
146			{
147			$targets = array_intersect_key($this->targets, array_flip($records));
148			$samples = array_intersect_key($this->samples, array_flip($records));
149			$samples = array_combine($records, $this->preprocess($samples));
150			$bestGiniVal = 1;
151			$bestSplit = null;
152			$features = $this->getSelectedFeatures();
153			foreach ($features as $i) {
154			$colValues = [];
155			foreach ($samples as $index => $row) {
156			$colValues[$index] = $row[$i];
157			}
158			$counts = array_count_values($colValues);
159			arsort($counts);
160			$baseValue = key($counts);
161			$gini = $this->getGiniIndex($baseValue, $colValues, $targets);
162			if ($bestSplit == null \|\| $bestGiniVal > $gini) {
163			$split = new DecisionTreeLeaf();
164			$split->value = $baseValue;
165			$split->giniIndex = $gini;
			0 ignored issues – show Documentation Bug introduced 2017-01-29 10:19 UTC by Report Bug Copy Issue Report It seems like `$gini` can also be of type `integer`. However, the property `$giniIndex` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
166			$split->columnIndex = $i;
167			$split->records = $records;
168			$bestSplit = $split;
169			$bestGiniVal = $gini;
170			}
171			}
172			return $bestSplit;
173			}
174
175			/**
176			* @return array
177			*/
178			protected function getSelectedFeatures()
179			{
180			$allFeatures = range(0, $this->featureCount - 1);
181			if ($this->numUsableFeatures == 0) {
182			return $allFeatures;
183			}
184
185			$numFeatures = $this->numUsableFeatures;
186			if ($numFeatures > $this->featureCount) {
187			$numFeatures = $this->featureCount;
188			}
189			shuffle($allFeatures);
190			$selectedFeatures = array_slice($allFeatures, 0, $numFeatures, false);
191			sort($selectedFeatures);
192
193			return $selectedFeatures;
194			}
195
196			/**
197			* @param string $baseValue
198			* @param array $colValues
199			* @param array $targets
200			*/
201			public function getGiniIndex($baseValue, $colValues, $targets)
202			{
203			$countMatrix = [];
204			foreach ($this->labels as $label) {
205			$countMatrix[$label] = [0, 0];
206			}
207			foreach ($colValues as $index => $value) {
208			$label = $targets[$index];
209			$rowIndex = $value == $baseValue ? 0 : 1;
210			$countMatrix[$label][$rowIndex]++;
211			}
212			$giniParts = [0, 0];
213			for ($i=0; $i<=1; $i++) {
214			$part = 0;
215			$sum = array_sum(array_column($countMatrix, $i));
216			if ($sum > 0) {
217			foreach ($this->labels as $label) {
218			$part += pow($countMatrix[$label][$i] / floatval($sum), 2);
219			}
220			}
221			$giniParts[$i] = (1 - $part) * $sum;
222			}
223			return array_sum($giniParts) / count($colValues);
224			}
225
226			/**
227			* @param array $samples
228			* @return array
229			*/
230			protected function preprocess(array $samples)
231			{
232			// Detect and convert continuous data column values into
233			// discrete values by using the median as a threshold value
234			$columns = [];
235			for ($i=0; $i<$this->featureCount; $i++) {
236			$values = array_column($samples, $i);
237			if ($this->columnTypes[$i] == self::CONTINUOS) {
238			$median = Mean::median($values);
239			foreach ($values as &$value) {
240			if ($value <= $median) {
241			$value = "<= $median";
242			} else {
243			$value = "> $median";
244			}
245			}
246			}
247			$columns[] = $values;
248			}
249			// Below method is a strange yet very simple & efficient method
250			// to get the transpose of a 2D array
251			return array_map(null, ...$columns);
252			}
253
254			/**
255			* @param array $columnValues
256			* @return bool
257			*/
258			protected function isCategoricalColumn(array $columnValues)
259			{
260			$count = count($columnValues);
261			// There are two main indicators that may show whether a
262			// column is composed of discrete set of values:
263			// 1- Column may contain string values
264			// 2- Number of unique values in the column is only a small fraction of
265			// all values in that column (Lower than or equal to %20 of all values)
266			$numericValues = array_filter($columnValues, 'is_numeric');
267			if (count($numericValues) != $count) {
268			return true;
269			}
270			$distinctValues = array_count_values($columnValues);
271			if (count($distinctValues) <= $count / 5) {
272			return true;
273			}
274			return false;
275			}
276
277			/**
278			* This method is used to set number of columns to be used
279			* when deciding a split at an internal node of the tree. <br>
280			* If the value is given 0, then all features are used (default behaviour),
281			* otherwise the given value will be used as a maximum for number of columns
282			* randomly selected for each split operation.
283			*
284			* @param int $numFeatures
285			* @return $this
286			* @throws Exception
287			*/
288			public function setNumFeatures(int $numFeatures)
289			{
290			if ($numFeatures < 0) {
291			throw new \Exception("Selected column count should be greater or equal to zero");
292			}
293
294			$this->numUsableFeatures = $numFeatures;
295			return $this;
296			}
297
298			/**
299			* @return string
300			*/
301			public function getHtml()
302			{
303			return $this->tree->__toString();
304			}
305
306			/**
307			* @param array $sample
308			* @return mixed
309			*/
310			protected function predictSample(array $sample)
311			{
312			$node = $this->tree;
313			do {
314			if ($node->isTerminal) {
315			break;
316			}
317			if ($node->evaluate($sample)) {
318			$node = $node->leftLeaf;
319			} else {
320			$node = $node->rightLeaf;
321			}
322			} while ($node);
323
324			return $node ? $node->classValue : $this->labels[0];
325			}
326			}
327

php-ai / php-ml

Push — master ( 72b25f...1d7350 )

DecisionTree B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like