LayeredNetwork - Code Metrics - Inspection of "test abstraction from LayeredNetwork" - php-ai/php-ml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 12ee62...64859f )

by Arkadiusz

created 2016-08-07 21:41 UTC

LayeredNetwork A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	56
c	0
b	0
f	0
wmc	7
lcom	1
cbo	2
rs	10

5 Methods

Rating	Name	Size	Complexity
A	addLayer()	4	1
A	getLayers()	4	1
A	getOutputLayer()	4	1
A	getOutput()	9	2
A	setInput()	8	2

<?php

declare (strict_types = 1);

namespace Phpml\NeuralNetwork\Network;

use Phpml\NeuralNetwork\Layer;
use Phpml\NeuralNetwork\Network;

abstract class LayeredNetwork implements Network
{
    /**
     * @var Layer[]
     */
    protected $layers;

    /**
     * @param Layer $layer
     */
    public function addLayer(Layer $layer)
    {
        $this->layers[] = $layer;
    }

    /**
     * @return Layer[]
     */
    public function getLayers(): array
    {
        return $this->layers;
    }

    /**
     * @return Layer
     */
    public function getOutputLayer(): Layer
    {
        return $this->layers[count($this->layers) - 1];
    }

    /**
     * @return array
     */
    public function getOutput(): array
    {
        $result = [];
        foreach ($this->getOutputLayer()->getNodes() as $neuron) {
            $result[] = $neuron->getOutput();
        }

        return $result;
    }

    /**
     * @param mixed $input
     */
    public function setInput($input)
    {
        $firstLayer = $this->layers[0];

        foreach ($firstLayer->getNodes() as $key => $neuron) {
            $neuron->setInput($input[$key]);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
    }
}


1			<?php
2
3			declare (strict_types = 1);
4
5			namespace Phpml\NeuralNetwork\Network;
6
7			use Phpml\NeuralNetwork\Layer;
8			use Phpml\NeuralNetwork\Network;
9
10			abstract class LayeredNetwork implements Network
11			{
12			/**
13			* @var Layer[]
14			*/
15			protected $layers;
16
17			/**
18			* @param Layer $layer
19			*/
20			public function addLayer(Layer $layer)
21			{
22			$this->layers[] = $layer;
23			}
24
25			/**
26			* @return Layer[]
27			*/
28			public function getLayers(): array
29			{
30			return $this->layers;
31			}
32
33			/**
34			* @return Layer
35			*/
36			public function getOutputLayer(): Layer
37			{
38			return $this->layers[count($this->layers) - 1];
39			}
40
41			/**
42			* @return array
43			*/
44			public function getOutput(): array
45			{
46			$result = [];
47			foreach ($this->getOutputLayer()->getNodes() as $neuron) {
48			$result[] = $neuron->getOutput();
49			}
50
51			return $result;
52			}
53
54			/**
55			* @param mixed $input
56			*/
57			public function setInput($input)
58			{
59			$firstLayer = $this->layers[0];
60
61			foreach ($firstLayer->getNodes() as $key => $neuron) {
62			$neuron->setInput($input[$key]);
			0 ignored issues – show Bug introduced 2016-08-07 21:44 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Phpml\NeuralNetwork\Node` as the method `setInput()` does only exist in the following implementations of said interface: `Phpml\NeuralNetwork\Node\Input`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
63			}
64			}
65			}
66

php-ai / php-ml

Push — develop ( 12ee62...64859f )

LayeredNetwork A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like