NGramTokenizer::__construct() - Code Metrics - Inspection of "Provide a new NGramTokenizer with minGram and maxG..." - php-ai/php-ml - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#350)

by Arkadiusz

created 2019-02-10 12:16 UTC

NGramTokenizer::__construct() A

↳ Parent: NGramTokenizer

Complexity

Conditions	4
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	4
nc	2
nop	2

<?php

declare(strict_types=1);

namespace Phpml\Tokenization;

use Phpml\Exception\InvalidArgumentException;

class NGramTokenizer extends WordTokenizer
{
    /**
     * @var int
     */
    private $minGram;

    /**
     * @var int
     */
    private $maxGram;

    public function __construct(int $minGram = 1, int $maxGram = 2)
    {
        if ($minGram < 1 || $maxGram < 1 || $minGram > $maxGram) {
            throw new InvalidArgumentException(sprintf('Invalid (%s, %s) minGram and maxGram value combination', $minGram, $maxGram));
        }

        $this->minGram = $minGram;
        $this->maxGram = $maxGram;
    }

    /**
     * {@inheritdoc}
     */
    public function tokenize(string $text): array
    {
        $words = [];
        preg_match_all('/\w\w+/u', $text, $words);

        $nGrams = [];
        foreach ($words[0] as $word) {
            $this->generateNGrams($word, $nGrams);
        }

        return $nGrams;
    }

    private function generateNGrams(string $word, array &$nGrams): void
    {
        $length = mb_strlen($word);

        for ($j = 1; $j <= $this->maxGram; $j++) {
            for ($k = 0; $k < $length - $j + 1; $k++) {
                if ($j >= $this->minGram) {
                    $nGrams[] = mb_substr($word, $k, $j);
                }
            }
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Phpml\Tokenization;
6
7			use Phpml\Exception\InvalidArgumentException;
8
9			class NGramTokenizer extends WordTokenizer
10			{
11			/**
12			* @var int
13			*/
14			private $minGram;
15
16			/**
17			* @var int
18			*/
19			private $maxGram;
20
21			public function __construct(int $minGram = 1, int $maxGram = 2)
22			{
23			if ($minGram < 1 \|\| $maxGram < 1 \|\| $minGram > $maxGram) {
24			throw new InvalidArgumentException(sprintf('Invalid (%s, %s) minGram and maxGram value combination', $minGram, $maxGram));
25			}
26
27			$this->minGram = $minGram;
28			$this->maxGram = $maxGram;
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function tokenize(string $text): array
35			{
36			$words = [];
37			preg_match_all('/\w\w+/u', $text, $words);
38
39			$nGrams = [];
40			foreach ($words[0] as $word) {
41			$this->generateNGrams($word, $nGrams);
42			}
43
44			return $nGrams;
45			}
46
47			private function generateNGrams(string $word, array &$nGrams): void
48			{
49			$length = mb_strlen($word);
50
51			for ($j = 1; $j <= $this->maxGram; $j++) {
52			for ($k = 0; $k < $length - $j + 1; $k++) {
53			if ($j >= $this->minGram) {
54			$nGrams[] = mb_substr($word, $k, $j);
55			}
56			}
57			}
58			}
59			}
60

php-ai / php-ml

Pull Request — master (#350)

NGramTokenizer::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like