DecisionStump - Code Metrics - Inspection of "Partial training base" - php-ai/php-ml - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#78)

unknown

created 2017-04-14 15:15 UTC

DecisionStump B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	344
Duplicated Lines	4.36 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	43
lcom	1
cbo	4
dl	15
loc	344
rs	8.3157
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	trainBinary()	0	52	9
A	setNumericalSplitCount()	0	4	1
B	getBestNumericalSplit()	10	38	6
B	getBestNominalSplit()	5	22	5
B	evaluate()	0	14	8
C	calculateErrorRate()	0	38	8
A	predictProbability()	0	9	2
A	predictSampleBinary()	0	8	2
A	__toString()	0	6	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like DecisionStump often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use DecisionStump, and based on these observations, apply Extract Interface, too.

<?php

declare(strict_types=1);

namespace Phpml\Classification\Linear;

use Phpml\Helper\Predictable;
use Phpml\Helper\OneVsRest;
use Phpml\Classification\WeightedClassifier;
use Phpml\Classification\DecisionTree;

class DecisionStump extends WeightedClassifier
{
    use Predictable, OneVsRest;

    const AUTO_SELECT = -1;

    /**
     * @var int
     */
    protected $givenColumnIndex;

    /**
     * @var array
     */
    protected $binaryLabels;

    /**
     * Lowest error rate obtained while training/optimizing the model
     *
     * @var float
     */
    protected $trainingErrorRate;

    /**
     * @var int
     */
    protected $column;

    /**
     * @var mixed
     */
    protected $value;

    /**
     * @var string
     */
    protected $operator;

    /**
     * @var array
     */
    protected $columnTypes;

    /**
     * @var int
     */
    protected $featureCount;

    /**
     * @var float
     */
    protected $numSplitCount = 100.0;

    /**
     * Distribution of samples in the leaves
     *
     * @var array
     */
    protected $prob;

    /**
     * A DecisionStump classifier is a one-level deep DecisionTree. It is generally
     * used with ensemble algorithms as in the weak classifier role. <br>
     *
     * If columnIndex is given, then the stump tries to produce a decision node
     * on this column, otherwise in cases given the value of -1, the stump itself
     * decides which column to take for the decision (Default DecisionTree behaviour)
     *
     * @param int $columnIndex
     */
    public function __construct(int $columnIndex = self::AUTO_SELECT)
    {
        $this->givenColumnIndex = $columnIndex;
    }

    /**
     * @param array $samples
     * @param array $targets
     * @throws \Exception
     */
    protected function trainBinary(array $samples, array $targets, array $labels)
    {
        $this->binaryLabels = $labels;
        $this->featureCount = count($samples[0]);

        // If a column index is given, it should be among the existing columns
        if ($this->givenColumnIndex > count($samples[0]) - 1) {
            $this->givenColumnIndex = self::AUTO_SELECT;
        }

        // Check the size of the weights given.
        // If none given, then assign 1 as a weight to each sample
        if ($this->weights) {

            $numWeights = count($this->weights);
            if ($numWeights != count($samples)) {
                throw new \Exception("Number of sample weights does not match with number of samples");
            }
        } else {
            $this->weights = array_fill(0, count($samples), 1);
        }

        // Determine type of each column as either "continuous" or "nominal"
        $this->columnTypes = DecisionTree::getColumnTypes($samples);

        // Try to find the best split in the columns of the dataset
        // by calculating error rate for each split point in each column
        $columns = range(0, count($samples[0]) - 1);
        if ($this->givenColumnIndex != self::AUTO_SELECT) {
            $columns = [$this->givenColumnIndex];
        }

        $bestSplit = [
            'value' => 0, 'operator' => '',
            'prob' => [], 'column' => 0,
            'trainingErrorRate' => 1.0];
        foreach ($columns as $col) {
            if ($this->columnTypes[$col] == DecisionTree::CONTINUOUS) {
                $split = $this->getBestNumericalSplit($samples, $targets, $col);
            } else {
                $split = $this->getBestNominalSplit($samples, $targets, $col);
            }

            if ($split['trainingErrorRate'] < $bestSplit['trainingErrorRate']) {
                $bestSplit = $split;
            }
        }

        // Assign determined best values to the stump
        foreach ($bestSplit as $name => $value) {
            $this->{$name} = $value;
        }
    }

    /**
     * While finding best split point for a numerical valued column,
     * DecisionStump looks for equally distanced values between minimum and maximum
     * values in the column. Given <i>$count</i> value determines how many split
     * points to be probed. The more split counts, the better performance but
     * worse processing time (Default value is 10.0)
     *
     * @param float $count
     */
    public function setNumericalSplitCount(float $count)
    {
        $this->numSplitCount = $count;
    }

    /**
     * Determines best split point for the given column
     *
     * @param array $samples
     * @param array $targets
     * @param int $col
     *
     * @return array
     */
    protected function getBestNumericalSplit(array $samples, array $targets, int $col)
    {
        $values = array_column($samples, $col);
        // Trying all possible points may be accomplished in two general ways:
        // 1- Try all values in the $samples array ($values)
        // 2- Artificially split the range of values into several parts and try them
        // We choose the second one because it is faster in larger datasets
        $minValue = min($values);
        $maxValue = max($values);
        $stepSize = ($maxValue - $minValue) / $this->numSplitCount;

        $split = null;

        foreach (['<=', '>'] as $operator) {
            // Before trying all possible split points, let's first try
            // the average value for the cut point
            $threshold = array_sum($values) / (float) count($values);
            list($errorRate, $prob) = $this->calculateErrorRate($targets, $threshold, $operator, $values);
            if ($split == null || $errorRate < $split['trainingErrorRate']) {

                $split = ['value' => $threshold, 'operator' => $operator,
                        'prob' => $prob, 'column' => $col,
                        'trainingErrorRate' => $errorRate];
            }

            // Try other possible points one by one
            for ($step = $minValue; $step <= $maxValue; $step+= $stepSize) {
                $threshold = (float)$step;
                list($errorRate, $prob) = $this->calculateErrorRate($targets, $threshold, $operator, $values);
                if ($errorRate < $split['trainingErrorRate']) {

                    $split = ['value' => $threshold, 'operator' => $operator,
                        'prob' => $prob, 'column' => $col,
                        'trainingErrorRate' => $errorRate];
                }
            }// for
        }

        return $split;
    }

    /**
     * @param array $samples
     * @param array $targets
     * @param int $col
     *
     * @return array
     */
    protected function getBestNominalSplit(array $samples, array $targets, int $col) : array
    {
        $values = array_column($samples, $col);
        $valueCounts = array_count_values($values);
        $distinctVals= array_keys($valueCounts);

        $split = null;

        foreach (['=', '!='] as $operator) {
            foreach ($distinctVals as $val) {
                list($errorRate, $prob) = $this->calculateErrorRate($targets, $val, $operator, $values);

                if ($split == null || $split['trainingErrorRate'] < $errorRate) {

                    $split = ['value' => $val, 'operator' => $operator,
                        'prob' => $prob, 'column' => $col,
                        'trainingErrorRate' => $errorRate];
                }
            }
        }

        return $split;
    }


    /**
     *
     * @param type $leftValue
     * @param type $operator
     * @param type $rightValue
     *
     * @return boolean
     */
    protected function evaluate($leftValue, $operator, $rightValue)
    {
        switch ($operator) {
            case '>': return $leftValue > $rightValue;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case '>=': return $leftValue >= $rightValue;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case '<': return $leftValue < $rightValue;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case '<=': return $leftValue <= $rightValue;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case '=': return $leftValue === $rightValue;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case '!=':
            case '<>': return $leftValue !== $rightValue;
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
        }

        return false;
    }

    /**
     * Calculates the ratio of wrong predictions based on the new threshold
     * value given as the parameter
     *
     * @param array $targets
     * @param float $threshold
     * @param string $operator
     * @param array $values
     *
     * @return array
     */
    protected function calculateErrorRate(array $targets, float $threshold, string $operator, array $values) : array
    {
        $wrong = 0.0;
        $prob = [];
        $leftLabel = $this->binaryLabels[0];
        $rightLabel= $this->binaryLabels[1];

        foreach ($values as $index => $value) {
            if ($this->evaluate($value, $operator, $threshold)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $predicted = $leftLabel;
            } else {
                $predicted = $rightLabel;
            }

            $target = $targets[$index];
            if (strval($predicted) != strval($targets[$index])) {
                $wrong += $this->weights[$index];
            }

            if (! isset($prob[$predicted][$target])) {
                $prob[$predicted][$target] = 0;
            }
            $prob[$predicted][$target]++;
        }

        // Calculate probabilities: Proportion of labels in each leaf
        $dist = array_combine($this->binaryLabels, array_fill(0, 2, 0.0));
        foreach ($prob as $leaf => $counts) {
            $leafTotal = (float)array_sum($prob[$leaf]);
            foreach ($counts as $label => $count) {
                if (strval($leaf) == strval($label)) {
                    $dist[$leaf] = $count / $leafTotal;
                }
            }
        }

        return [$wrong / (float) array_sum($this->weights), $dist];
    }

    /**
     * Returns the probability of the sample of belonging to the given label
     *
     * Probability of a sample is calculated as the proportion of the label
     * within the labels of the training samples in the decision node
     *
     * @param array $sample
     * @param mixed $label
     *
     * @return float
     */
    protected function predictProbability(array $sample, $label) : float
    {
        $predicted = $this->predictSampleBinary($sample);
        if (strval($predicted) == strval($label)) {
            return $this->prob[$label];
        }

        return 0.0;
    }

    /**
     * @param array $sample
     *
     * @return mixed
     */
    protected function predictSampleBinary(array $sample)
    {
        if ($this->evaluate($sample[$this->column], $this->operator, $this->value)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $this->binaryLabels[0];
        }

        return $this->binaryLabels[1];
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return "IF $this->column $this->operator $this->value " .
            "THEN " . $this->binaryLabels[0] . " ".
            "ELSE " . $this->binaryLabels[1];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Phpml\Classification\Linear;
6
7		use Phpml\Helper\Predictable;
8		use Phpml\Helper\OneVsRest;
9		use Phpml\Classification\WeightedClassifier;
10		use Phpml\Classification\DecisionTree;
11
12		class DecisionStump extends WeightedClassifier
13		{
14		use Predictable, OneVsRest;
15
16		const AUTO_SELECT = -1;
17
18		/**
19		* @var int
20		*/
21		protected $givenColumnIndex;
22
23		/**
24		* @var array
25		*/
26		protected $binaryLabels;
27
28		/**
29		* Lowest error rate obtained while training/optimizing the model
30		*
31		* @var float
32		*/
33		protected $trainingErrorRate;
34
35		/**
36		* @var int
37		*/
38		protected $column;
39
40		/**
41		* @var mixed
42		*/
43		protected $value;
44
45		/**
46		* @var string
47		*/
48		protected $operator;
49
50		/**
51		* @var array
52		*/
53		protected $columnTypes;
54
55		/**
56		* @var int
57		*/
58		protected $featureCount;
59
60		/**
61		* @var float
62		*/
63		protected $numSplitCount = 100.0;
64
65		/**
66		* Distribution of samples in the leaves
67		*
68		* @var array
69		*/
70		protected $prob;
71
72		/**
73		* A DecisionStump classifier is a one-level deep DecisionTree. It is generally
74		* used with ensemble algorithms as in the weak classifier role. <br>
75		*
76		* If columnIndex is given, then the stump tries to produce a decision node
77		* on this column, otherwise in cases given the value of -1, the stump itself
78		* decides which column to take for the decision (Default DecisionTree behaviour)
79		*
80		* @param int $columnIndex
81		*/
82		public function __construct(int $columnIndex = self::AUTO_SELECT)
83		{
84		$this->givenColumnIndex = $columnIndex;
85		}
86
87		/**
88		* @param array $samples
89		* @param array $targets
90		* @throws \Exception
91		*/
92		protected function trainBinary(array $samples, array $targets, array $labels)
93		{
94		$this->binaryLabels = $labels;
95		$this->featureCount = count($samples[0]);
96
97		// If a column index is given, it should be among the existing columns
98		if ($this->givenColumnIndex > count($samples[0]) - 1) {
99		$this->givenColumnIndex = self::AUTO_SELECT;
100		}
101
102		// Check the size of the weights given.
103		// If none given, then assign 1 as a weight to each sample
104		if ($this->weights) {
		0 ignored issues – show Bug Best Practice introduced 2017-02-19 10:47 UTC by Report Bug Copy Issue Report The expression `$this->weights` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
105		$numWeights = count($this->weights);
106		if ($numWeights != count($samples)) {
107		throw new \Exception("Number of sample weights does not match with number of samples");
108		}
109		} else {
110		$this->weights = array_fill(0, count($samples), 1);
111		}
112
113		// Determine type of each column as either "continuous" or "nominal"
114		$this->columnTypes = DecisionTree::getColumnTypes($samples);
115
116		// Try to find the best split in the columns of the dataset
117		// by calculating error rate for each split point in each column
118		$columns = range(0, count($samples[0]) - 1);
119		if ($this->givenColumnIndex != self::AUTO_SELECT) {
120		$columns = [$this->givenColumnIndex];
121		}
122
123		$bestSplit = [
124		'value' => 0, 'operator' => '',
125		'prob' => [], 'column' => 0,
126		'trainingErrorRate' => 1.0];
127		foreach ($columns as $col) {
128		if ($this->columnTypes[$col] == DecisionTree::CONTINUOUS) {
129		$split = $this->getBestNumericalSplit($samples, $targets, $col);
130		} else {
131		$split = $this->getBestNominalSplit($samples, $targets, $col);
132		}
133
134		if ($split['trainingErrorRate'] < $bestSplit['trainingErrorRate']) {
135		$bestSplit = $split;
136		}
137		}
138
139		// Assign determined best values to the stump
140		foreach ($bestSplit as $name => $value) {
141		$this->{$name} = $value;
142		}
143		}
144
145		/**
146		* While finding best split point for a numerical valued column,
147		* DecisionStump looks for equally distanced values between minimum and maximum
148		* values in the column. Given <i>$count</i> value determines how many split
149		* points to be probed. The more split counts, the better performance but
150		* worse processing time (Default value is 10.0)
151		*
152		* @param float $count
153		*/
154		public function setNumericalSplitCount(float $count)
155		{
156		$this->numSplitCount = $count;
157		}
158
159		/**
160		* Determines best split point for the given column
161		*
162		* @param array $samples
163		* @param array $targets
164		* @param int $col
165		*
166		* @return array
167		*/
168		protected function getBestNumericalSplit(array $samples, array $targets, int $col)
169		{
170		$values = array_column($samples, $col);
171		// Trying all possible points may be accomplished in two general ways:
172		// 1- Try all values in the $samples array ($values)
173		// 2- Artificially split the range of values into several parts and try them
174		// We choose the second one because it is faster in larger datasets
175		$minValue = min($values);
176		$maxValue = max($values);
177		$stepSize = ($maxValue - $minValue) / $this->numSplitCount;
178
179		$split = null;
180
181		foreach (['<=', '>'] as $operator) {
182		// Before trying all possible split points, let's first try
183		// the average value for the cut point
184		$threshold = array_sum($values) / (float) count($values);
185		list($errorRate, $prob) = $this->calculateErrorRate($targets, $threshold, $operator, $values);
186	View Code Duplication	if ($split == null \|\| $errorRate < $split['trainingErrorRate']) {
		0 ignored issues – show Duplication introduced 2017-02-25 14:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
187		$split = ['value' => $threshold, 'operator' => $operator,
188		'prob' => $prob, 'column' => $col,
189		'trainingErrorRate' => $errorRate];
190		}
191
192		// Try other possible points one by one
193		for ($step = $minValue; $step <= $maxValue; $step+= $stepSize) {
194		$threshold = (float)$step;
195		list($errorRate, $prob) = $this->calculateErrorRate($targets, $threshold, $operator, $values);
196	View Code Duplication	if ($errorRate < $split['trainingErrorRate']) {
		0 ignored issues – show Duplication introduced 2017-02-25 14:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
197		$split = ['value' => $threshold, 'operator' => $operator,
198		'prob' => $prob, 'column' => $col,
199		'trainingErrorRate' => $errorRate];
200		}
201		}// for
202		}
203
204		return $split;
205		}
206
207		/**
208		* @param array $samples
209		* @param array $targets
210		* @param int $col
211		*
212		* @return array
213		*/
214		protected function getBestNominalSplit(array $samples, array $targets, int $col) : array
215		{
216		$values = array_column($samples, $col);
217		$valueCounts = array_count_values($values);
218		$distinctVals= array_keys($valueCounts);
219
220		$split = null;
221
222		foreach (['=', '!='] as $operator) {
223		foreach ($distinctVals as $val) {
224		list($errorRate, $prob) = $this->calculateErrorRate($targets, $val, $operator, $values);
225
226	View Code Duplication	if ($split == null \|\| $split['trainingErrorRate'] < $errorRate) {
		0 ignored issues – show Duplication introduced 2017-02-25 14:37 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
227		$split = ['value' => $val, 'operator' => $operator,
228		'prob' => $prob, 'column' => $col,
229		'trainingErrorRate' => $errorRate];
230		}
231		}
232		}
233
234		return $split;
235		}
236
237
238		/**
239		*
240		* @param type $leftValue
241		* @param type $operator
242		* @param type $rightValue
243		*
244		* @return boolean
245		*/
246		protected function evaluate($leftValue, $operator, $rightValue)
247		{
248		switch ($operator) {
249		case '>': return $leftValue > $rightValue;
		0 ignored issues – show Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
250		case '>=': return $leftValue >= $rightValue;
		0 ignored issues – show Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
251		case '<': return $leftValue < $rightValue;
		0 ignored issues – show Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
252		case '<=': return $leftValue <= $rightValue;
		0 ignored issues – show Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-02-27 13:38 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
253		case '=': return $leftValue === $rightValue;
		0 ignored issues – show Coding Style introduced 2017-03-03 19:08 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-03-03 19:08 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
254		case '!=':
255		case '<>': return $leftValue !== $rightValue;
		0 ignored issues – show Coding Style introduced 2017-03-03 19:08 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2017-03-03 19:08 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
256		}
257
258		return false;
259		}
260
261		/**
262		* Calculates the ratio of wrong predictions based on the new threshold
263		* value given as the parameter
264		*
265		* @param array $targets
266		* @param float $threshold
267		* @param string $operator
268		* @param array $values
269		*
270		* @return array
271		*/
272		protected function calculateErrorRate(array $targets, float $threshold, string $operator, array $values) : array
273		{
274		$wrong = 0.0;
275		$prob = [];
276		$leftLabel = $this->binaryLabels[0];
277		$rightLabel= $this->binaryLabels[1];
278
279		foreach ($values as $index => $value) {
280		if ($this->evaluate($value, $operator, $threshold)) {
		0 ignored issues – show Documentation introduced 2017-03-03 19:08 UTC by Report Bug Copy Issue Report `$operator` is of type `string`, but the function expects a `object<Phpml\Classification\Linear\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-03-03 19:08 UTC by Report Bug Copy Issue Report `$threshold` is of type `double`, but the function expects a `object<Phpml\Classification\Linear\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
281		$predicted = $leftLabel;
282		} else {
283		$predicted = $rightLabel;
284		}
285
286		$target = $targets[$index];
287		if (strval($predicted) != strval($targets[$index])) {
288		$wrong += $this->weights[$index];
289		}
290
291		if (! isset($prob[$predicted][$target])) {
292		$prob[$predicted][$target] = 0;
293		}
294		$prob[$predicted][$target]++;
295		}
296
297		// Calculate probabilities: Proportion of labels in each leaf
298		$dist = array_combine($this->binaryLabels, array_fill(0, 2, 0.0));
299		foreach ($prob as $leaf => $counts) {
300		$leafTotal = (float)array_sum($prob[$leaf]);
301		foreach ($counts as $label => $count) {
302		if (strval($leaf) == strval($label)) {
303		$dist[$leaf] = $count / $leafTotal;
304		}
305		}
306		}
307
308		return [$wrong / (float) array_sum($this->weights), $dist];
309		}
310
311		/**
312		* Returns the probability of the sample of belonging to the given label
313		*
314		* Probability of a sample is calculated as the proportion of the label
315		* within the labels of the training samples in the decision node
316		*
317		* @param array $sample
318		* @param mixed $label
319		*
320		* @return float
321		*/
322		protected function predictProbability(array $sample, $label) : float
323		{
324		$predicted = $this->predictSampleBinary($sample);
325		if (strval($predicted) == strval($label)) {
326		return $this->prob[$label];
327		}
328
329		return 0.0;
330		}
331
332		/**
333		* @param array $sample
334		*
335		* @return mixed
336		*/
337		protected function predictSampleBinary(array $sample)
338		{
339		if ($this->evaluate($sample[$this->column], $this->operator, $this->value)) {
		0 ignored issues – show Documentation introduced 2017-03-03 19:08 UTC by Report Bug Copy Issue Report `$this->operator` is of type `string`, but the function expects a `object<Phpml\Classification\Linear\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
340		return $this->binaryLabels[0];
341		}
342
343		return $this->binaryLabels[1];
344		}
345
346		/**
347		* @return string
348		*/
349		public function __toString()
350		{
351		return "IF $this->column $this->operator $this->value " .
352		"THEN " . $this->binaryLabels[0] . " ".
353		"ELSE " . $this->binaryLabels[1];
354		}
355		}
356

php-ai / php-ml