Phpml\Optimization\Anneal

Complexity

Total Complexity

9

Size/Duplication

Total Lines	80
Duplicated Lines	7.5 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
C	run()	6	33	8

<?php

declare(strict_types=1);

namespace Phpml\Optimization;

class Anneal
{
    /**
    * @var array
    */
    private $domain;

    /**
    * @var Cost
    */    
    private $cost;

    /**
    * @var int
    */
    private $temperature;

    /**
    * @var float
    */
    private $cool;

    /**
    * @var int
    */
    private $step;

    /**
     * @param array      $domain
     * @param Cost       $cost
     * @param int        $temperature
     * @param float      $cool
     * @param int        $step
     */
    public function __construct(array $domain, Cost $cost, int $temperature = 1000, float $cool = 0.99, int $step=1)
    {
        $this->domain = $domain;
        $this->cost = $cost;
        $this->temperature = $temperature;
        $this->cool = $cool;
        $this->step = $step;
    }

    /**
     * @return array
     */
    public function run()
    {
        $i=0;

$i is not used, you could remove the assignment.

        $vec = [];
        for ($i=0 ; $i<count($this->domain); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $vec[]=rand($this->domain[$i][0], $this->domain[$i][1]);
        }
        while ($this->temperature > 0.1) {
            $idx = rand(0, count($this->domain) - 1);
            $dir = rand(-$this->step, $this->step);
            $newVec = [];
            for ($i=0; $i<count($vec); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $newVec[]=($vec[$i]);
            }
            $newVec[$idx]+=$dir;
            if ($newVec[$idx] < $this->domain[$idx][0]) {

This code seems to be duplicated across your project.

                $newVec[$idx] = $this->domain[$idx][0];
            }
            if ($newVec[$idx] > $this->domain[$idx][1]) {

This code seems to be duplicated across your project.

                $newVec[$idx] = $this->domain[$idx][1];
            }

            $ea = $this->cost->calc($vec);
            $eb = $this->cost->calc($newVec);
            $p = exp(-1*($eb-$ea)/$this->temperature);
            if ($eb < $ea || (rand(0, 1000)/1000) < $p) {
                $vec = $newVec;
            }

            $this->temperature *= $this->cool;
        }
        return $vec;
    }
}