php-ai /
php-ml
| Conditions | 11 |
| Paths | 11 |
| Total Lines | 25 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | public static function compare($a, $b, string $operator): bool |
||
| 15 | { |
||
| 16 | switch ($operator) { |
||
| 17 | case '>': |
||
| 18 | return $a > $b; |
||
| 19 | case '>=': |
||
| 20 | return $a >= $b; |
||
| 21 | case '=': |
||
| 22 | case '==': |
||
| 23 | return $a == $b; |
||
| 24 | case '===': |
||
| 25 | return $a === $b; |
||
| 26 | case '<=': |
||
| 27 | return $a <= $b; |
||
| 28 | case '<': |
||
| 29 | return $a < $b; |
||
| 30 | case '!=': |
||
| 31 | case '<>': |
||
| 32 | return $a != $b; |
||
| 33 | case '!==': |
||
| 34 | return $a !== $b; |
||
| 35 | default: |
||
| 36 | throw new InvalidArgumentException(sprintf('Invalid operator "%s" provided', $operator)); |
||
| 37 | } |
||
| 38 | } |
||
| 39 | } |
||
| 40 |
