Distance::deltas() - Code Metrics - Inspection of "Issue #347: Reduce duplicated code." - php-ai/php-ml - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#348)

by Pol

created 2019-02-05 08:50 UTC

Distance::deltas() A

↳ Parent: Distance

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	3
nc	3
nop	2

<?php

declare(strict_types=1);

namespace Phpml\Math\Distance;

use Phpml\Exception\InvalidArgumentException;
use Phpml\Math\Distance as DistanceInterface;

/**
 * Class Distance
 */
abstract class Distance implements DistanceInterface
{
    /**
     * @var float|int
     */
    public $norm;

    /**
     * Distance constructor.
     */
    public function __construct(float $norm = 3.0)
    {
        $this->norm = $norm;
    }

    /**
     * @throws InvalidArgumentException
     */
    public function distance(array $a, array $b): float
    {
        $distance = 0;

        foreach ($this->deltas($a, $b) as $delta) {
          $distance += $delta ** $this->norm;
        }

        return $distance ** (1 / $this->norm);
    }

    /**
     * @throws InvalidArgumentException
     */
    protected function deltas(array $a, array $b): array
    {
        $count = count($a);

        if ($count !== count($b)) {
            throw new InvalidArgumentException('Size of given arrays does not match');
        }

        $deltas = [];

        for ($i = 0; $i < $count; $i++)
        {
          $deltas[] = abs($a[$i] - $b[$i]);
        }

        return $deltas;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Phpml\Math\Distance;
6
7			use Phpml\Exception\InvalidArgumentException;
8			use Phpml\Math\Distance as DistanceInterface;
9
10			/**
11			* Class Distance
12			*/
13			abstract class Distance implements DistanceInterface
14			{
15			/**
16			* @var float\|int
17			*/
18			public $norm;
19
20			/**
21			* Distance constructor.
22			*/
23			public function __construct(float $norm = 3.0)
24			{
25			$this->norm = $norm;
26			}
27
28			/**
29			* @throws InvalidArgumentException
30			*/
31			public function distance(array $a, array $b): float
32			{
33			$distance = 0;
34
35			foreach ($this->deltas($a, $b) as $delta) {
36			$distance += $delta ** $this->norm;
37			}
38
39			return $distance ** (1 / $this->norm);
40			}
41
42			/**
43			* @throws InvalidArgumentException
44			*/
45			protected function deltas(array $a, array $b): array
46			{
47			$count = count($a);
48
49			if ($count !== count($b)) {
50			throw new InvalidArgumentException('Size of given arrays does not match');
51			}
52
53			$deltas = [];
54
55			for ($i = 0; $i < $count; $i++)
56			{
57			$deltas[] = abs($a[$i] - $b[$i]);
58			}
59
60			return $deltas;
61			}
62			}
63

php-ai / php-ml

Pull Request — master (#348)

Distance::deltas() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like