php-ai /
php-ml
| Conditions | 11 |
| Paths | 11 |
| Total Lines | 25 |
| Code Lines | 22 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 20 | public static function compare($a, $b, string $operator): bool |
||
| 21 | { |
||
| 22 | switch ($operator) { |
||
| 23 | case '>': |
||
| 24 | return $a > $b; |
||
| 25 | case '>=': |
||
| 26 | return $a >= $b; |
||
| 27 | case '=': |
||
| 28 | case '==': |
||
| 29 | return $a == $b; |
||
| 30 | case '===': |
||
| 31 | return $a === $b; |
||
| 32 | case '<=': |
||
| 33 | return $a <= $b; |
||
| 34 | case '<': |
||
| 35 | return $a < $b; |
||
| 36 | case '!=': |
||
| 37 | case '<>': |
||
| 38 | return $a != $b; |
||
| 39 | case '!==': |
||
| 40 | return $a !== $b; |
||
| 41 | default: |
||
| 42 | throw InvalidArgumentException::invalidOperator($operator); |
||
| 43 | } |
||
| 44 | } |
||
| 45 | } |
||
| 46 |
