Conditions | 11 |
Paths | 11 |
Total Lines | 23 |
Code Lines | 21 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
17 | public static function compare($a, $b, string $operator): bool |
||
18 | { |
||
19 | switch ($operator) { |
||
20 | case '>': |
||
21 | return $a > $b; |
||
22 | case '>=': |
||
23 | return $a >= $b; |
||
24 | case '=': |
||
25 | case '==': |
||
26 | return $a == $b; |
||
27 | case '===': |
||
28 | return $a === $b; |
||
29 | case '<=': |
||
30 | return $a <= $b; |
||
31 | case '<': |
||
32 | return $a < $b; |
||
33 | case '!=': |
||
34 | case '<>': |
||
35 | return $a != $b; |
||
36 | case '!==': |
||
37 | return $a !== $b; |
||
38 | default: |
||
39 | throw new InvalidArgumentException(sprintf('Invalid operator "%s" provided', $operator)); |
||
40 | } |
||
43 |