Uuid::get() - Code Metrics - phossa2/uuid - Measure and Improve Code Quality continuously with Scrutinizer

Uuid::get() A
last analyzed 2016-09-29 07:22 UTC

↳ Parent: Uuid

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	11
nc	1
nop	2

<?php
/**
 * Phossa Project
 *
 * PHP version 5.4
 *
 * @category  Library
 * @package   Phossa2\Uuid
 * @copyright Copyright (c) 2016 phossa.com
 * @license   http://mit-license.org/ MIT License
 * @link      http://www.phossa.com/
 */
/*# declare(strict_types=1); */

namespace Phossa2\Uuid;

use Phossa2\Uuid\Traits\UtilityTrait;
use Phossa2\Uuid\Interfaces\UuidInterface;
use Phossa2\Uuid\Interfaces\UtilityInterface;

/**
 * Uuid
 *
 * @package Phossa2\Uuid
 * @author  Hong Zhang <[email protected]>
 * @version 2.1.0
 * @since   2.0.0 added
 * @since   2.1.0 moved sequence related stuff to SequenceTrait
 */
class Uuid implements UuidInterface, UtilityInterface
{
    use UtilityTrait;

    /**
     * Default vendor code
     *
     * @var    string
     * @access protected
     */
    protected $vendor = '0001';

    /**
     * remaining part
     *
     * @var    string
     * @access protected
     */
    protected $remain = '0000';

    /**
     * Instances
     *
     * @var    UuidInterface[]
     * @access private
     */
    private static $instances = [];

    /**
     * {@inheritDoc}
     */
    public static function get(
        /*# string */ $dataType = self::TYPE_OID,
        /*# string */ $shardId = '0001'
    )/*# : string */ {
        $obj = static::getInstance();
        return
            substr(self::VERSION, 0, 1) .   // 0
            $dataType .                     // 1 - 4
            $obj->getTimestamp() .          // 5 - 19
            $shardId .                      // 20 - 23
            $obj->vendor .                  // 24 - 27
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $obj->remain;                   // 28 - 31
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * Get instance
     *
     * return  Uuid
     * @access protected
     * @static
     */
    protected static function getInstance()
    {
        $class = get_called_class();
        if (!isset(self::$instances[$class])) {
            self::$instances[$class] = new static();
        }
        return self::$instances[$class];
    }
}


Uuid::get() A
last analyzed 2016-09-29 07:22 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Phossa Project
4			*
5			* PHP version 5.4
6			*
7			* @category Library
8			* @package Phossa2\Uuid
9			* @copyright Copyright (c) 2016 phossa.com
10			* @license http://mit-license.org/ MIT License
11			* @link http://www.phossa.com/
12			*/
13			/# declare(strict_types=1); /
14
15			namespace Phossa2\Uuid;
16
17			use Phossa2\Uuid\Traits\UtilityTrait;
18			use Phossa2\Uuid\Interfaces\UuidInterface;
19			use Phossa2\Uuid\Interfaces\UtilityInterface;
20
21			/**
22			* Uuid
23			*
24			* @package Phossa2\Uuid
25			* @author Hong Zhang <[email protected]>
26			* @version 2.1.0
27			* @since 2.0.0 added
28			* @since 2.1.0 moved sequence related stuff to SequenceTrait
29			*/
30			class Uuid implements UuidInterface, UtilityInterface
31			{
32			use UtilityTrait;
33
34			/**
35			* Default vendor code
36			*
37			* @var string
38			* @access protected
39			*/
40			protected $vendor = '0001';
41
42			/**
43			* remaining part
44			*
45			* @var string
46			* @access protected
47			*/
48			protected $remain = '0000';
49
50			/**
51			* Instances
52			*
53			* @var UuidInterface[]
54			* @access private
55			*/
56			private static $instances = [];
57
58			/**
59			* {@inheritDoc}
60			*/
61			public static function get(
62			/# string / $dataType = self::TYPE_OID,
63			/# string / $shardId = '0001'
64			)/# : string / {
65			$obj = static::getInstance();
66			return
67			substr(self::VERSION, 0, 1) . // 0
68			$dataType . // 1 - 4
69			$obj->getTimestamp() . // 5 - 19
70			$shardId . // 20 - 23
71			$obj->vendor . // 24 - 27
			0 ignored issues – show Bug introduced 2016-09-19 11:44 UTC by Report Bug Copy Issue Report Accessing `vendor` on the interface `Phossa2\Uuid\Interfaces\UuidInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
72			$obj->remain; // 28 - 31
			0 ignored issues – show Bug introduced 2016-09-19 11:44 UTC by Report Bug Copy Issue Report Accessing `remain` on the interface `Phossa2\Uuid\Interfaces\UuidInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
73			}
74
75			/**
76			* Get instance
77			*
78			* return Uuid
79			* @access protected
80			* @static
81			*/
82			protected static function getInstance()
83			{
84			$class = get_called_class();
85			if (!isset(self::$instances[$class])) {
86			self::$instances[$class] = new static();
87			}
88			return self::$instances[$class];
89			}
90			}
91

phossa2 / uuid

Uuid::get() A last analyzed 2016-09-29 07:22 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Uuid::get() A
last analyzed 2016-09-29 07:22 UTC