Phossa2\Middleware\Middleware\WhoopsMiddleware

Complexity

Total Complexity

2

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	process()	0	11	2

<?php
/**
 * Phossa Project
 *
 * PHP version 5.4
 *
 * @category  Library
 * @package   Phossa2\Middleware
 * @copyright Copyright (c) 2016 phossa.com
 * @license   http://mit-license.org/ MIT License
 * @link      http://www.phossa.com/
 */
/*# declare(strict_types=1); */

namespace Phossa2\Middleware\Middleware;

use Psr\Http\Message\RequestInterface;
use Phossa2\Shared\Base\ObjectAbstract;
use Psr\Http\Message\ResponseInterface;
use Franzl\Middleware\Whoops\WhoopsRunner;
use Phossa2\Middleware\Interfaces\DelegateInterface;
use Phossa2\Middleware\Interfaces\MiddlewareInterface;

/**
 * WhoopsMiddleware
 *
 * Using "franzl/whoops-middleware" for Whoops
 *
 * @package Phossa2\Middleware
 * @author  Hong Zhang <phossa@126.com>
 * @version 2.1.0
 * @since   2.1.0 added
 */
class WhoopsMiddleware extends ObjectAbstract implements MiddlewareInterface
{
    /**
     * Should be the very first middleware in the queue
     *
     * {@inheritDoc}
     */
    public function process(
        RequestInterface $request,
        ResponseInterface $response,
        DelegateInterface $next = null
    ) {
        try {
            return $next->next($request, $response);

It seems like $next is not always an object, but can also be of type null. Maybe add an additional type check?

        } catch (\Exception $e) {
            return WhoopsRunner::handle($e, $request);
        }
    }
}